LKML Archive on
help / color / mirror / Atom feed
From: Ian Abbott <>
To: Dan Carpenter <>,
	Chris Opperman <>
Cc:, Frank Mori Hess <>,
	Simo Koskinen <>,
	Greg Kroah-Hartman <>,
Subject: Re: [PATCH v4] staging: comedi: Improved readability of function comedi_nsamples_left.
Date: Thu, 14 Jun 2018 12:08:53 +0100	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <20180613190549.ugl43yee4f3thk4t@mwanda>

On 13/06/18 20:05, Dan Carpenter wrote:
> On Wed, Jun 13, 2018 at 08:26:43PM +0200, Chris Opperman wrote:
>> Hi Dan/Ian,
>> Noted your comments regarding additional text, thanks! Just curious whether
>> the "scissors" format given at the link below is valid?
>> It is given as an alternative to placing additional text below the
>> cut-off line.
> Try it yourself.  Save your email as email.txt and then
> `cat email.txt | git am` and then review the patch with git log -p.
> I've seen people do the scissors thing, but I assume the maintainer has
> to hand edit the log which we refuse to do.

It can be done automatically with the git am -c or --scissors option, or 
by setting mailinfo.scissors to true in the git config.  But since the 
use of these special scissors lines is not documented in 
Documentation/process/submitting-patches.rst, I don't think it is safe 
to assume that no manual intervention would be required by the 
maintainer to deal with it.

I wonder where the "scissors" advice on the kernelnewbies page came from?

-=( Ian Abbott <> || Web: )=-
-=( MEV Ltd. is a company registered in England & Wales. )=-
-=( Registered number: 02862268.  Registered address:    )=-
-=( 15 West Park Road, Bramhall, STOCKPORT, SK7 3JZ, UK. )=-

  reply	other threads:[~2018-06-14 11:08 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-12 21:09 Chris Opperman
2018-06-13  9:29 ` Dan Carpenter
2018-06-13 18:26   ` Chris Opperman
2018-06-13 17:33     ` Ian Abbott
2018-06-13 19:05     ` Dan Carpenter
2018-06-14 11:08       ` Ian Abbott [this message]
2018-06-14 16:18         ` Chris Opperman
2018-06-13 12:01 ` Ian Abbott

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \
    --subject='Re: [PATCH v4] staging: comedi: Improved readability of function comedi_nsamples_left.' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).