LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Ian Abbott <abbotti@mev.co.uk>
To: Dan Carpenter <dan.carpenter@oracle.com>,
Chris Opperman <eklikeroomys@gmail.com>
Cc: devel@driverdev.osuosl.org, Frank Mori Hess <fmh6jj@gmail.com>,
Simo Koskinen <koskisoft@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4] staging: comedi: Improved readability of function comedi_nsamples_left.
Date: Thu, 14 Jun 2018 12:08:53 +0100 [thread overview]
Message-ID: <48e9826d-3f60-a79a-779a-2296a89afad0@mev.co.uk> (raw)
In-Reply-To: <20180613190549.ugl43yee4f3thk4t@mwanda>
On 13/06/18 20:05, Dan Carpenter wrote:
> On Wed, Jun 13, 2018 at 08:26:43PM +0200, Chris Opperman wrote:
>> Hi Dan/Ian,
>>
>> Noted your comments regarding additional text, thanks! Just curious whether
>> the "scissors" format given at the link below is valid?
>>
>> https://kernelnewbies.org/PatchTipsAndTricks
>>
>> It is given as an alternative to placing additional text below the
>> cut-off line.
>>
>
> Try it yourself. Save your email as email.txt and then
> `cat email.txt | git am` and then review the patch with git log -p.
>
> I've seen people do the scissors thing, but I assume the maintainer has
> to hand edit the log which we refuse to do.
It can be done automatically with the git am -c or --scissors option, or
by setting mailinfo.scissors to true in the git config. But since the
use of these special scissors lines is not documented in
Documentation/process/submitting-patches.rst, I don't think it is safe
to assume that no manual intervention would be required by the
maintainer to deal with it.
I wonder where the "scissors" advice on the kernelnewbies page came from?
--
-=( Ian Abbott <abbotti@mev.co.uk> || Web: www.mev.co.uk )=-
-=( MEV Ltd. is a company registered in England & Wales. )=-
-=( Registered number: 02862268. Registered address: )=-
-=( 15 West Park Road, Bramhall, STOCKPORT, SK7 3JZ, UK. )=-
next prev parent reply other threads:[~2018-06-14 11:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-12 21:09 Chris Opperman
2018-06-13 9:29 ` Dan Carpenter
2018-06-13 18:26 ` Chris Opperman
2018-06-13 17:33 ` Ian Abbott
2018-06-13 19:05 ` Dan Carpenter
2018-06-14 11:08 ` Ian Abbott [this message]
2018-06-14 16:18 ` Chris Opperman
2018-06-13 12:01 ` Ian Abbott
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48e9826d-3f60-a79a-779a-2296a89afad0@mev.co.uk \
--to=abbotti@mev.co.uk \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=eklikeroomys@gmail.com \
--cc=fmh6jj@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=koskisoft@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--subject='Re: [PATCH v4] staging: comedi: Improved readability of function comedi_nsamples_left.' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).