LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Lai Jiangshan <laijs@cn.fujitsu.com>
To: Mathieu Desnoyers <compudj@krystal.dyndns.org>
Cc: ltt-dev@lists.casi.polymtl.ca,
	"Martin J. Bligh" <mbligh@mbligh.org>,
	Steven Rostedt <rostedt@goodmis.org>, Ingo Molnar <mingo@elte.hu>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	kernel-trace-list@redhat.com, linux-kernel@vger.kernel.org,
	systemtap@sources.redhat.com
Subject: Re: [ltt-dev] LTTng 0.44 and LTTV 0.11.3
Date: Tue, 28 Oct 2008 11:55:22 +0800	[thread overview]
Message-ID: <49068D2A.9010308@cn.fujitsu.com> (raw)
In-Reply-To: <20081024004502.GA21759@Krystal>

Mathieu Desnoyers wrote:
> - I have also vastly simplified locking in the markers and tracepoints
>   by using _only_ the modules mutex. I actually took this mutex out of
>   module.c and created its own file so tracepoints and markers can use
>   it. That should please Lai Jiangshan. Although he may have some work
>   to do to see how his new probes manager might benefit from it.
> 
>   See :
>   http://git.kernel.org/?p=linux/kernel/git/compudj/linux-2.6-lttng.git;a=commitdiff;h=7aea87ac46df7613d68034f5904bc8d575069076
>   and
>   http://git.kernel.org/?p=linux/kernel/git/compudj/linux-2.6-lttng.git;a=commitdiff;h=5f6814237f7a67650e7b6214d916825e3f8fc1b7
>   http://git.kernel.org/?p=linux/kernel/git/compudj/linux-2.6-lttng.git;a=commitdiff;h=410ba66a1cbe27a611e1c18c0a53e87b4652a2c9
> 

Hi, Mathieu,

I strongly reject for removing tracepoint_mutex and marker_mutex.

As an independent subsystem, we should use our own locks. Do not use others.
otherwise coupling will be increased in linux kernel.
I condemn unnecessary coupling.

Our tracepoint & marker had tied to modules(for traveling all tracepoints
or markers). The best thing is that we do not increase the coupling.

[PATCH 2/2] tracepoint: introduce *_noupdate APIs.
is helpful for auto-active-tracepoint-mechanism.

		Thanx, Lai.

> So hopefully everyone will be happy with this new release. :)
> 
> Mathieu
> 



  reply	other threads:[~2008-10-28  3:58 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-24  0:45 Mathieu Desnoyers
2008-10-28  3:55 ` Lai Jiangshan [this message]
2008-10-29 17:40   ` [ltt-dev] " Mathieu Desnoyers
2008-10-30  3:32     ` [sadump 04308] " Lai Jiangshan
2008-10-30  6:01       ` [ltt-dev] [sadump 04308] " Mathieu Desnoyers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49068D2A.9010308@cn.fujitsu.com \
    --to=laijs@cn.fujitsu.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=akpm@linux-foundation.org \
    --cc=compudj@krystal.dyndns.org \
    --cc=kernel-trace-list@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ltt-dev@lists.casi.polymtl.ca \
    --cc=mbligh@mbligh.org \
    --cc=mingo@elte.hu \
    --cc=rostedt@goodmis.org \
    --cc=systemtap@sources.redhat.com \
    --cc=torvalds@linux-foundation.org \
    --subject='Re: [ltt-dev] LTTng 0.44 and LTTV 0.11.3' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).