LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Ulrich Drepper <drepper@redhat.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, torvalds@linux-foundation.org,
linux-api@vger.kernel.org
Subject: Re: [PATCH] reintroduce accept4
Date: Mon, 27 Oct 2008 21:22:59 -0700 [thread overview]
Message-ID: <490693A3.9070805@redhat.com> (raw)
In-Reply-To: <20081027204135.a139704e.akpm@linux-foundation.org>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Andrew Morton wrote:
> I'll confess to not having a clue what's going on here.
It has been discussed at length. accept created file descriptors and we
need flags for tis.
>> #elif __i386__
>> #define SYS_ACCEPT4 18
>> #define USE_SOCKETCALL 1
>> #define SOCK_CLOEXEC O_CLOEXEC
>> #else
>
> Well. This doesn't actually agree with the kernel patch.
What doesn't agree?
> I'd suggest that i386 is sufficiently common to warrant its inclusion
> in the initial patch.
The x86 code is included. x86 uses socketcall instead of a syscall.
I changed all paccept occurrences in the tree, not just x86-64.
- --
➧ Ulrich Drepper ➧ Red Hat, Inc. ➧ 444 Castro St ➧ Mountain View, CA ❖
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org
iEYEARECAAYFAkkGk6MACgkQ2ijCOnn/RHSwSgCfeb/PGDCm2qy0ZESqWb8wgyhX
cHoAoIIXvhBjdxcj2gy09eQBzNKOTwCU
=QSFh
-----END PGP SIGNATURE-----
next prev parent reply other threads:[~2008-10-28 4:23 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-26 16:41 [PATCH] reintroduce accept4 Ulrich Drepper
2008-10-28 3:41 ` Andrew Morton
2008-10-28 4:22 ` Ulrich Drepper [this message]
2008-10-28 4:52 ` Andrew Morton
2008-10-28 12:34 ` Michael Kerrisk
2008-11-13 21:51 ` Michael Kerrisk
2008-11-13 22:02 ` Michael Kerrisk
2008-11-13 22:11 ` Michael Kerrisk
2008-11-13 22:14 ` Michael Kerrisk
2008-11-13 22:05 ` Andrew Morton
2008-11-13 22:25 ` Paul Mackerras
2008-11-13 22:28 ` Paul Mackerras
2008-11-13 22:57 ` Andrew Morton
2008-11-14 0:07 ` David Miller
2008-11-14 15:24 ` Michael Kerrisk
2008-11-14 17:40 ` Michael Kerrisk
2008-11-14 15:24 ` Michael Kerrisk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=490693A3.9070805@redhat.com \
--to=drepper@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).