LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Randy Dunlap <randy.dunlap@oracle.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: LKML <linux-kernel@vger.kernel.org>, Ingo Molnar <mingo@elte.hu>,
	Thomas Gleixner <tglx@linutronix.de>,
	Peter Zijlstra <peterz@infradead.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH] ftrace: update txt document
Date: Fri, 31 Oct 2008 08:30:07 -0700	[thread overview]
Message-ID: <490B247F.5070603@oracle.com> (raw)
In-Reply-To: <alpine.DEB.1.10.0810311049090.20157@gandalf.stny.rr.com>

Steven Rostedt wrote:
> I finally got around to looking at the review notes.
> 
> On Sun, 26 Oct 2008, Randy Dunlap wrote:
>>>  
>>>   # sysctl kernel.ftrace_enabled=1
>>> - # echo ftrace > /debug/tracing/current_tracer
>>> + # echo function > /debug/tracing/current_tracer
>>>   # echo 1 > /debug/tracing/tracing_enabled
>>>   # usleep 1
>>>   # echo 0 > /debug/tracing/tracing_enabled
>>>   # cat /debug/tracing/trace
>>> -# tracer: ftrace
>>> +# tracer: function
>>>  #
>>>  #           TASK-PID   CPU#    TIMESTAMP  FUNCTION
>>>  #              | |      |          |         |
>> General comment #2: debugfs is normally mounted at /sys/kernel/debug
>> (which Doc/x86/pat.txt, Doc/filesystems/relay.txt,
>> Doc/infiniband/ipoib.txt, and Doc/usb/usbmon.txt know about).
>> Please either use /sys/kernel/debug or use what Doc/kernel-parameters.txt
>> uses: <debugfs> (for the mount point).  I.e., don't use a poor example
>> in the doc text.
> 
> In the beginning of the document I did have a disclaimer:

OK, sorry about that.  Somehow I missed seeing it.

> ------------------------
> To mount the debugfs system:
> 
>   # mkdir /debug
>   # mount -t debugfs nodev /debug
> 
> (Note: it is more common to mount at /sys/kernel/debug, but for simplicity
>  this document will use /debug)
> ------------------------
> 
> I know the recommended place is /sys/kernel/debug, but I never use it. And 
> I know many others that do not either. It is just easier to make the
> /debug directory. I feel this is more of a guideline than something
> that must be enforced.  But if you do feel strongly on this subject, I
> can change it to /sys/kernel/debug (which I absolutely loathe).


-- 
~Randy

  reply	other threads:[~2008-10-31 15:31 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-23 23:23 Steven Rostedt
2008-10-27  2:33 ` Randy Dunlap
2008-10-31 14:56   ` Steven Rostedt
2008-10-31 15:30     ` Randy Dunlap [this message]
2008-10-31 15:03   ` [PATCH v2] " Steven Rostedt
2008-10-31 15:04     ` Steven Rostedt
2008-10-31 16:22     ` Steven Rostedt
2008-10-31 16:23       ` Steven Rostedt
2008-10-31 16:31     ` Randy Dunlap
2008-10-31 16:46       ` [PATCH] ftrace document version update Steven Rostedt
2008-11-03 20:18         ` Steven Rostedt
2008-11-04  9:13           ` Ingo Molnar
2008-11-03 20:15     ` [PATCH] ftrace: update txt document Steven Rostedt
2008-11-03 20:16       ` Steven Rostedt
2008-11-04  9:12       ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=490B247F.5070603@oracle.com \
    --to=randy.dunlap@oracle.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    --subject='Re: [PATCH] ftrace: update txt document' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).