LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Chris Snook <csnook@redhat.com>
To: Huang Ying <ying.huang@intel.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATH -mm -v2] Fix a race condtion of oops_in_progress
Date: Fri, 31 Oct 2008 12:42:28 -0400	[thread overview]
Message-ID: <490B3574.1060501@redhat.com> (raw)
In-Reply-To: <1225332179.24095.61.camel@yhuang-dev.sh.intel.com>

Huang Ying wrote:
> Hi, Chris,
> 
> On Wed, 2008-10-29 at 08:51 -0600, Chris Snook wrote:
>> Huang Ying wrote:
>>> Fix a race condition accessing oops_in_progress.  Which may be changed on
>>> multiple CPU simultaneously, but it is changed via non-atomic operation
>>> ++/--.  This patch changes the definition of oops_in_process from int to
>>> atomic_t, and accessing method to atomic operations.
>> You also need barriers.  I believe rmb() before atomic_read() and wmb() after 
>> atomic_set() should suffice.
> 
> I don't think that is necessary. I haven't found there is particular
> consistent requirement about oops_in_progress.

atomic_read() and atomic_set() don't inherently cause changes to be visible on 
other CPUs any faster than ++ and -- operators.  Sometimes it happens to work 
out that way as a result of how the compiler and the CPU order operations, but 
there's no semantic guarantee, and it could even take arbitrarily long under 
some circumstances.  If you want to use atomic ops to close the race, you need 
to use barriers.

-- Chris

  reply	other threads:[~2008-10-31 16:42 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-29  8:26 Huang Ying
2008-10-29  8:34 ` Ingo Molnar
2008-10-29  8:42   ` Huang Ying
2008-10-29 14:51 ` Chris Snook
2008-10-30  2:02   ` Huang Ying
2008-10-31 16:42     ` Chris Snook [this message]
2008-11-03  1:52       ` Huang Ying
2008-11-03 18:44         ` Chris Snook
2008-11-04  1:41           ` Huang Ying
2008-11-10  7:35             ` KOSAKI Motohiro
2008-11-10 18:45               ` Chris Snook
2008-11-11  1:05               ` Huang Ying
2008-11-11  1:10                 ` Chris Snook
2008-11-11  1:19                   ` Huang Ying

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=490B3574.1060501@redhat.com \
    --to=csnook@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ying.huang@intel.com \
    --subject='Re: [PATH -mm -v2] Fix a race condtion of oops_in_progress' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).