LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Yinghai Lu <yinghai@kernel.org>
To: Ben Hutchings <bhutchings@solarflare.com>
Cc: Ingo Molnar <mingo@elte.hu>, Thomas Gleixner <tglx@linutronix.de>,
	"H. Peter Anvin" <hpa@zytor.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] x86: make NR_IRQS on 32bit is same to 64bit
Date: Tue, 04 Nov 2008 14:34:30 -0800	[thread overview]
Message-ID: <4910CDF6.1040901@kernel.org> (raw)
In-Reply-To: <1225837748.3074.54.camel@achroite>

Ben Hutchings wrote:
> On Tue, 2008-11-04 at 14:10 -0800, Yinghai Lu wrote:
>> Impact: so NR_IRQS is bigger enough for system with lots of apic/pins
>>
>> Now: if IO_APIC is there, will have big NR_IRQS
>>
>> otherwise still use 224
> [...]
> 
> I have no idea whether this is useful, but it doesn't solve the general
> problem that probe_nr_irqs() can return a value > NR_IRQS.  So far as I
> can see it can return up to 2 * 24 * MAX_IO_APICS which may be greater
> than NR_VECTORS + (32 * max(MAX_IO_APICS, NR_CPUS)).

your patch is still needed...
also please add one WARN_ON when nr > NR_IRQS.

YH

  reply	other threads:[~2008-11-04 22:36 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-04 22:10 Yinghai Lu
2008-11-04 22:29 ` Ben Hutchings
2008-11-04 22:34   ` Yinghai Lu [this message]
2008-11-06  6:26 ` Ingo Molnar
2008-11-06  6:42   ` Yinghai Lu
2008-11-06  6:52     ` H. Peter Anvin
2008-11-06  7:00       ` Yinghai Lu
2008-11-06  7:03         ` H. Peter Anvin
2008-11-06  7:10           ` Yinghai Lu
2008-11-06  7:28             ` Yinghai Lu
2008-11-06  7:36           ` Yinghai Lu
2008-11-06  8:35             ` Ingo Molnar
2008-11-06 21:59       ` Matt Mackall
2008-11-06 22:23         ` Ingo Molnar
2008-11-06 22:36           ` Matt Mackall

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4910CDF6.1040901@kernel.org \
    --to=yinghai@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=bhutchings@solarflare.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=tglx@linutronix.de \
    --subject='Re: [PATCH] x86: make NR_IRQS on 32bit is same to 64bit' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).