LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Nicolas Ferre <nicolas.ferre@atmel.com>
To: Julien Brunel <brunel@diku.dk>,
	adaplas@gmail.com, linux-fbdev-devel@lists.sourceforge.net,
	Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] drivers/video: Bad error test before a dereference
Date: Thu, 06 Nov 2008 16:33:36 +0100	[thread overview]
Message-ID: <49130E50.8090009@atmel.com> (raw)
In-Reply-To: <200809261553.45301.brunel@diku.dk>

Julien Brunel :
> The error test that follows the call to backlight_device_register
> semms not to concern the right variable.
> 
> A simplified version of the semantic match that finds this problem is
> as follows: 
> (http://www.emn.fr/x-info/coccinelle/)
> // <smpl>
> @def0@
> expression x;
> position p0;
> @@
> x@p0 = backlight_device_register(...)
> 
> @protected@
> expression def0.x,E;
> position def0.p0;
> position p;
> statement S;
> @@
> x@p0
> ... when != x = E
> if (!IS_ERR(x) && ...) {<... x@p ...>} else S
> 
> @unprotected@
> expression def0.x;
> identifier fld;
> position def0.p0;
> position p != protected.p;
> @@
> x@p0
> ... when != x = E
> * x@p->fld
> // </smpl>
> 
> Signed-off-by: Julien Brunel <brunel@diku.dk>
> Signed-off-by: Julia Lawall <julia@diku.dk>

Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>

> 
> ---
>  drivers/video/atmel_lcdfb.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff -u -p a/drivers/video/atmel_lcdfb.c b/drivers/video/atmel_lcdfb.c
> --- a/drivers/video/atmel_lcdfb.c
> +++ b/drivers/video/atmel_lcdfb.c
> @@ -132,7 +132,7 @@ static void init_backlight(struct atmel_
>  
>  	bl = backlight_device_register("backlight", &sinfo->pdev->dev,
>  			sinfo, &atmel_lcdc_bl_ops);
> -	if (IS_ERR(sinfo->backlight)) {
> +	if (IS_ERR(bl)) {
>  		dev_err(&sinfo->pdev->dev, "error %ld on backlight register\n",
>  				PTR_ERR(bl));
>  		return;
> 

Thanks, regards,
-- 
Nicolas Ferre


  reply	other threads:[~2008-11-06 15:34 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-26 13:53 Julien Brunel
2008-11-06 15:33 ` Nicolas Ferre [this message]
2008-11-13  8:26   ` [Linux-fbdev-devel] " Nicolas Ferre

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49130E50.8090009@atmel.com \
    --to=nicolas.ferre@atmel.com \
    --cc=adaplas@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=brunel@diku.dk \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-fbdev-devel@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    --subject='Re: [PATCH] drivers/video: Bad error test before a dereference' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).