LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Marco Stornelli <marco.stornelli@coritel.it>
To: mtk.manpages@gmail.com
Cc: rdunlap@xenotime.net, linux-doc@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [RESEND] documentation: xip documentation update
Date: Thu, 06 Nov 2008 17:25:36 +0100	[thread overview]
Message-ID: <49131A80.3000402@coritel.it> (raw)
In-Reply-To: <cfd18e0f0811060742v46dd3f9eod624954cd9dcda3d@mail.gmail.com>


Michael Kerrisk wrote:
> Marco,
> 
> A few comments below.
> 
> On Thu, Nov 6, 2008 at 10:33 AM, Marco Stornelli
> <marco.stornelli@coritel.it> wrote:
>> From: Marco Stornelli <marco.stornelli@gmail.com>
>>
>> xip documentation updated
>> Signed-off-by: Marco Stornelli <marco.stornelli@gmail.com>
>> ---
>>
>> --- a/Documentation/filesystems/xip.txt.orig    2008-08-20 20:11:37.000000000 +0200
>> +++ b/Documentation/filesystems/xip.txt 2008-11-06 12:47:48.000000000 +0200
>> @@ -39,10 +39,11 @@ The block device operation is optional,
>>  today:
>>  - dcssblk: s390 dcss block device driver
>>
>> -An address space operation named get_xip_page is used to retrieve reference
>> -to a struct page. To address the target page, a reference to an address_space,
>> -and a sector number is provided. A 3rd argument indicates whether the
> 
>> -function should allocate blocks if needed.
>> +An address space operation named get_xip_mem is used to retrieve reference
> 
> s/reference/a reference/?

Ok, it should actually be "references".

> 
>> +to a page frame number and a kernel address. To obtain these values a reference
>> +to an address_space is provided. This function assigns values to the kmem and
>> +pfn parameters. The 3rd argument indicates whether the function should allocate
> 
> It's a taste thing, but I would write "third" not "3rd".  (I
> appreciate that the existing text already used "3rd", but maybe that
> should be fixed.)

Ok.

> 
>> +blocks if needed.
>>
>>  This address space operation is mutually exclusive with readpage&writepage that
>>  do page cache read/write operations.
> 
> Cheers,
> 
> Michael
> 


I wait for other comments before re-send the patch.

  reply	other threads:[~2008-11-06 16:25 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-06 15:33 Marco Stornelli
2008-11-06 15:42 ` Michael Kerrisk
2008-11-06 16:25   ` Marco Stornelli [this message]
2008-11-07  7:46 Marco Stornelli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49131A80.3000402@coritel.it \
    --to=marco.stornelli@coritel.it \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mtk.manpages@gmail.com \
    --cc=rdunlap@xenotime.net \
    --subject='Re: [PATCH] [RESEND] documentation: xip documentation update' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).