LKML Archive on
help / color / mirror / Atom feed
From: Tejun Heo <>
To: Jens Axboe <>, Jeff Garzik <>,
	Linus Torvalds <>,
	IDE/ATA development list <>,
	Linux Kernel <>
Subject: Re: request to revert libata-convert-to-block-tagging patches
Date: Mon, 10 Nov 2008 14:30:05 +0900	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

Tejun Heo wrote:
> #1 is easy to fix but #2 requires either adding a spinlock or two atomic
> variables to struct blk_queue_tag to keep the current behavior while
> guaranteeing that tags are used in order.  Also, there's delay between
> libata marks a request complete and the request actually gets completed
> and the tag is freed.  If another request gets issued inbetween, the tag
> number can't be guaranteed.  This can be worked around by re-mapping tag
> number in libata depending on command type but, well then, it's worse
> than the original implementation.

I think this can be made to work by making tag free synchronous (ie.
doing it when the request is passed over to softirq) but I don't think
things like that should go into 2.6.28 at this point.



  reply	other threads:[~2008-11-10  5:30 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-10  5:19 Tejun Heo
2008-11-10  5:30 ` Tejun Heo [this message]
2008-11-10  5:48   ` [PATCH] libata: revert convert-to-block-tagging patches Tejun Heo
2008-11-10 12:05 ` request to revert libata-convert-to-block-tagging patches Jens Axboe
2008-11-10 12:09   ` Jens Axboe
2008-11-10 16:00     ` Linus Torvalds
2008-11-10 17:10       ` Jens Axboe
2008-11-10 13:24   ` Tejun Heo
2008-11-10 16:03     ` Linus Torvalds
2008-11-10 22:55 ` Jeff Garzik
2008-11-12  1:11   ` Linus Torvalds

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \
    --subject='Re: request to revert libata-convert-to-block-tagging patches' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).