LKML Archive on
help / color / mirror / Atom feed
From: Manfred Spraul <>
To: Nadia Derbey <>
Cc: Andrew Morton <>,,,
	Ingo Molnar <>
Subject: Re: [PATCH] SYSVIPC - Fix the ipc structures initialization
Date: Thu, 13 Nov 2008 18:53:57 +0100	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

Nadia Derbey wrote:
> That's what the patch I sent at the beginning of this thread
> ( fixes: the ipc structure is not
> completely initialized before being inserted in the tree.
> The patched kernel has been running for 4 days on my victim without any
> problem, but Clement is still facing a problem (that comes later).
> I think this patch should be included anyways, because ipc structures
> initialization is not correct the way it is done today.
Definitively: Your patch belongs into 2.6.28 and the next 2.6.27.

> I'm still reviewing the code to see what else could be wrong.
I started looking into the idr code: perhaps idr returns a stale entry? 
A race somewhere in the RCU code.
I.e. the new bug is not corruption due to access before 
spin_lock_init(), but due to access after kfree()?

Clement: Could you send us an ipcs output from before the test?
Do you have any sysv msg queues on your system?
And: Do you use PREEMPT, do you use PREEMPT_RCU?

If there are no message queues around, then every msgget()/IPC_RMID will 
create a new idr layer/tear the layer down again.


      reply	other threads:[~2008-11-13 17:54 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <>
2008-10-28 14:59 ` Nadia.Derbey
2008-10-28 17:22   ` Manfred Spraul
2008-10-29  9:11   ` cboulte
2008-11-11 22:16     ` Andrew Morton
2008-11-12  6:41       ` Manfred Spraul
2008-11-13  6:10       ` Manfred Spraul
2008-11-13  8:06         ` Peter Zijlstra
2008-11-13 10:08         ` Nadia Derbey
2008-11-13 17:53           ` Manfred Spraul [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \
    --subject='Re: [PATCH] SYSVIPC - Fix the ipc structures initialization' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).