LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Henrik Rydberg <rydberg@euromail.se>
To: Jiri Kosina <jkosina@suse.cz>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] hid: Complete support for the new unibody macbooks
Date: Thu, 20 Nov 2008 00:10:03 +0100 [thread overview]
Message-ID: <49249CCB.7060807@euromail.se> (raw)
In-Reply-To: <alpine.LNX.1.10.0811192339560.19853@jikos.suse.cz>
Jiri Kosina wrote:
> On Wed, 19 Nov 2008, Henrik Rydberg wrote:
>
>> Without the mouse ignore quirk, HID will find the "normal" usb mouse
>> interface. The current situation is much worse than to throw the bcm5974
>> patches in untested. And this is not even the case; the updated driver
>> has been in use as a dkms package for almost a month.
>
> Therefore my memory must have been wrong -- I thought that you told me
> when I was merging f89bd95c5c that the devices are not standard HID
> devices at all, and therefore they can be safely ignored by the driver
> right away, as they can't be driven by HID driver anyway.
These usb devices provide several different functions through the same
interface. By default, it looks like a regular mouse interface, which
HID will claim. This is why we need the quirks.
> If this is not the case, I'll then revert the hid_mouse_ignore_list[]
> addition peformed in a96d6ef34 and will push it for 2.6.29, so that it
> goes in together with bcm5974 driver modifications.
Yes, I think that is best.
> Thanks and sorry if I messed this up,
No harm done. :-)
Thanks,
Henrik
next prev parent reply other threads:[~2008-11-19 23:10 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-04 19:03 Henrik Rydberg
2008-11-11 17:36 ` Jiri Kosina
2008-11-11 18:05 ` Henrik Rydberg
2008-11-11 22:48 ` Jiri Kosina
2008-11-19 16:40 ` Dmitry Torokhov
2008-11-19 17:06 ` Jiri Kosina
2008-11-19 22:33 ` Henrik Rydberg
2008-11-19 22:43 ` Jiri Kosina
2008-11-19 23:10 ` Henrik Rydberg [this message]
2008-11-19 23:57 ` Jiri Kosina
2008-11-20 0:41 ` Henrik Rydberg
2008-11-20 10:37 ` Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49249CCB.7060807@euromail.se \
--to=rydberg@euromail.se \
--cc=akpm@linux-foundation.org \
--cc=dmitry.torokhov@gmail.com \
--cc=jkosina@suse.cz \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--subject='Re: [PATCH] hid: Complete support for the new unibody macbooks' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).