LKML Archive on
help / color / mirror / Atom feed
From: Sergei Shtylyov <>
To: Sergei Shtylyov <>
Cc: Bartlomiej Zolnierkiewicz <>,,
Subject: Re: [PATCH 2/5] ide: ->ide_dma_clear_irq() -> ->clear_irq()
Date: Thu, 21 May 2009 18:07:06 +0400	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

Hello, I wrote:

>>> * Rename ->ide_dma_clear_irq method to ->clear_irq
>>>   and move it from ide_hwif_t to struct ide_port_ops.

>>> * Move ->waiting_for_dma check inside ->clear_irq method.

>>> * Move ->dma_base check inside ->clear_irq method.

>>> piix.c:
>>> * Add ich_port_ops and remove init_hwif_ich() wrapper.

>>> There should be no functional changes caused by this patch.


>>   It may also be worth considering turning this method into 
>> test-and-clear, so that we can get the actual IDE interrupt state on 
>> the chips that implement this...

>   Probably might add the test_irq() method to be called on 
> !hwif->waiting_for_dma. Cleraing the status at once seems impractical...

    Yet this seems what ack_intr() method is doing already...
    What it does is testing IRQ status and "acknowledging" it (the semantics 
of "acknowledge" is not clear to me, yet it seems that it's clearing the 
interrupt latch in the drivers where it's implemented). And the call site of 
ack_intr() method corresponds to where test_irq() should have been called, 
so it seems we don't need yet another method and probably didn't even need 
clear_irq() method in the first place?..
    Bart, could you clarify about how ack_intr() is supposed to work?

MBR, Sergei

  parent reply	other threads:[~2009-05-21 14:06 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-19 18:31 Bartlomiej Zolnierkiewicz
2008-08-19 22:22 ` Sergei Shtylyov
2008-09-15 22:11   ` Sergei Shtylyov
2008-09-15 22:29     ` Bartlomiej Zolnierkiewicz
2008-09-16  9:16       ` Sergei Shtylyov
2008-11-12  2:01         ` Jeremy Higdon
2009-05-21 14:07     ` Sergei Shtylyov [this message]
2009-05-22 18:44       ` ->ack_intr in m68k IDE drivers [was: Re: [PATCH 2/5] ide: ->ide_dma_clear_irq() -> ->clear_irq()] Bartlomiej Zolnierkiewicz
2009-05-22 19:19         ` Sergei Shtylyov
2009-05-22 19:19         ` Sergei Shtylyov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \
    --subject='Re: [PATCH 2/5] ide: ->ide_dma_clear_irq() -> ->clear_irq()' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).