LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Yinghai Lu <yinghai@kernel.org>
To: Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@elte.hu>,
	"H. Peter Anvin" <hpa@zytor.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: [PATCH 5/6] x86, 64bit: Move out cleanup higmap [_brk_end, _end) out of init_memory_mapping()
Date: Mon, 27 Dec 2010 16:48:32 -0800	[thread overview]
Message-ID: <4D1933E0.7090305@kernel.org> (raw)
In-Reply-To: <4D19320B.7030007@kernel.org>


It is not related to init_memory_mapping(),  and init_memory_mapping() is
getting more bigger.

So make it as seperated function and call it from reserve_brk() and that is
point when _brk_end is concluded.

Signed-off-by: Yinghai Lu <yinghai@kernel.org>

---
 arch/x86/kernel/setup.c |   24 ++++++++++++++++++++++++
 arch/x86/mm/init.c      |   19 -------------------
 2 files changed, 24 insertions(+), 19 deletions(-)

Index: linux-2.6/arch/x86/kernel/setup.c
===================================================================
--- linux-2.6.orig/arch/x86/kernel/setup.c
+++ linux-2.6/arch/x86/kernel/setup.c
@@ -293,10 +293,32 @@ static void __init init_gbpages(void)
 	else
 		direct_gbpages = 0;
 }
+
+static void __init cleanup_highmap_brk_end(void)
+{
+	pud_t *pud;
+	pmd_t *pmd;
+
+	mmu_cr4_features = read_cr4();
+
+	/*
+	 * _brk_end cannot change anymore, but it and _end may be
+	 * located on different 2M pages. cleanup_highmap(), however,
+	 * can only consider _end when it runs, so destroy any
+	 * mappings beyond _brk_end here.
+	 */
+	pud = pud_offset(pgd_offset_k(_brk_end), _brk_end);
+	pmd = pmd_offset(pud, _brk_end - 1);
+	while (++pmd <= pmd_offset(pud, (unsigned long)_end - 1))
+		pmd_clear(pmd);
+}
 #else
 static inline void init_gbpages(void)
 {
 }
+static inline void cleanup_highmap_brk_end(void)
+{
+}
 #endif
 
 static void __init reserve_brk(void)
@@ -307,6 +329,8 @@ static void __init reserve_brk(void)
 	/* Mark brk area as locked down and no longer taking any
 	   new allocations */
 	_brk_start = 0;
+
+	cleanup_highmap_brk_end();
 }
 
 #ifdef CONFIG_BLK_DEV_INITRD
Index: linux-2.6/arch/x86/mm/init.c
===================================================================
--- linux-2.6.orig/arch/x86/mm/init.c
+++ linux-2.6/arch/x86/mm/init.c
@@ -270,25 +270,6 @@ unsigned long __init_refok init_memory_m
 	load_cr3(swapper_pg_dir);
 #endif
 
-#ifdef CONFIG_X86_64
-	if (!after_bootmem && !start) {
-		pud_t *pud;
-		pmd_t *pmd;
-
-		mmu_cr4_features = read_cr4();
-
-		/*
-		 * _brk_end cannot change anymore, but it and _end may be
-		 * located on different 2M pages. cleanup_highmap(), however,
-		 * can only consider _end when it runs, so destroy any
-		 * mappings beyond _brk_end here.
-		 */
-		pud = pud_offset(pgd_offset_k(_brk_end), _brk_end);
-		pmd = pmd_offset(pud, _brk_end - 1);
-		while (++pmd <= pmd_offset(pud, (unsigned long)_end - 1))
-			pmd_clear(pmd);
-	}
-#endif
 	__flush_tlb_all();
 
 	if (!after_bootmem && e820_table_end > e820_table_start)

  parent reply	other threads:[~2010-12-28  0:49 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-18  0:58 [PATCH 0/3] memblock related top down Yinghai Lu
2010-12-28  0:47 ` [PATCH 0/6] memblock related further cleanup for x86 Yinghai Lu
     [not found] ` <4D19320B.7030007@kernel.org>
2010-12-28  0:47   ` [PATCH 1/6] x86: Change get_max_mapped() to inline Yinghai Lu
2010-12-29 23:05     ` H. Peter Anvin
2010-12-29 23:30       ` Yinghai Lu
2010-12-29 23:37         ` Yinghai Lu
2010-12-29 23:42           ` H. Peter Anvin
2010-12-29 23:45     ` [PATCH -v2 " Yinghai Lu
2011-02-16  8:50     ` [tip:x86/mm] " tip-bot for Yinghai Lu
2010-12-28  0:48   ` [PATCH 2/6] x86, 64bit, numa: Allocate memnodemap under max_pfn_mapped Yinghai Lu
2011-02-16  8:50     ` [tip:x86/mm] x86-64, " tip-bot for Yinghai Lu
2010-12-28  0:48   ` [PATCH 3/6] x86, 64bit, numa: Put pgtable to local node memory Yinghai Lu
2010-12-29 23:46     ` [PATCH -v2 " Yinghai Lu
2010-12-29 23:50       ` H. Peter Anvin
2010-12-30  0:11         ` Yinghai Lu
2010-12-30  0:39           ` David Rientjes
2010-12-30  0:58             ` H. Peter Anvin
2010-12-30  1:07               ` David Rientjes
2010-12-30  1:53                 ` H. Peter Anvin
2010-12-30  9:06                   ` Ingo Molnar
2010-12-30 10:28                     ` [boot crash] " Ingo Molnar
2010-12-30 10:30                       ` Ingo Molnar
2010-12-30 12:01                         ` [build failure] " Ingo Molnar
2010-12-30 18:53                           ` David Rientjes
2010-12-30 18:54                             ` [patch] x86, numa: Fix CONFIG_DEBUG_PER_CPU_MAPS without NUMA emulation David Rientjes
2011-01-06 20:39                               ` David Rientjes
2011-01-06 21:25                                 ` Yinghai Lu
2011-01-06 23:58                                   ` David Rientjes
2011-01-07 15:32                               ` [tip:x86/numa] " tip-bot for David Rientjes
2010-12-30 21:18                         ` [boot crash] Re: [PATCH -v2 3/6] x86, 64bit, numa: Put pgtable to local node memory Yinghai Lu
     [not found]                           ` <AANLkTimpyRXS9dNFATh4GqtA46uynutAvK7Qb5S7WPFO@mail.gmail.com>
     [not found]                             ` <20110105134434.GA22816@elte.hu>
2011-01-05 21:24                               ` Yinghai Lu
2011-01-07 20:41                               ` [PATCH] memblock: Don't adjust size in memblock_find_base() Yinghai Lu
2011-01-10  5:56                                 ` Benjamin Herrenschmidt
2011-01-10  6:59                                   ` Yinghai Lu
2011-01-12  1:35                                   ` Yinghai Lu
2011-01-29  0:37                               ` [PATCH - resend] " Yinghai Lu
2011-02-03 20:25                                 ` Andrew Morton
2011-02-03 20:37                                   ` Yinghai Lu
2011-02-16  8:51     ` [tip:x86/mm] x86-64, numa: Put pgtable to local node memory tip-bot for Yinghai Lu
2010-12-28  0:48   ` [PATCH 4/6] x86: Use early pre-allocated page table buffer top-down Yinghai Lu
2010-12-28  0:48   ` Yinghai Lu [this message]
2011-02-16  8:51     ` [tip:x86/mm] x86-64: Move out cleanup higmap [_brk_end, _end) out of init_memory_mapping() tip-bot for Yinghai Lu
2010-12-28  0:48   ` [PATCH 6/6] x86: Rename e820_table_* to pgt_buf_* Yinghai Lu
2010-12-30 21:54     ` [PATCH -v2 " Yinghai Lu
2010-12-28 20:21 ` [PATCH 0/3] memblock related top down H. Peter Anvin
2010-12-28 21:36   ` Yinghai Lu
2010-12-28 22:09     ` H. Peter Anvin
2010-12-28 22:25       ` Yinghai Lu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D1933E0.7090305@kernel.org \
    --to=yinghai@kernel.org \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=tglx@linutronix.de \
    --subject='Re: [PATCH 5/6] x86, 64bit: Move out cleanup higmap [_brk_end, _end) out of init_memory_mapping()' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).