LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Yinghai Lu <yinghai@kernel.org>
To: David Rientjes <rientjes@google.com>
Cc: Ingo Molnar <mingo@elte.hu>, "H. Peter Anvin" <hpa@zytor.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	linux-kernel@vger.kernel.org
Subject: Re: [patch] x86, numa: Fix CONFIG_DEBUG_PER_CPU_MAPS without NUMA emulation
Date: Thu, 06 Jan 2011 13:25:36 -0800	[thread overview]
Message-ID: <4D263350.5070008@kernel.org> (raw)
In-Reply-To: <alpine.DEB.2.00.1101061238460.30820@chino.kir.corp.google.com>

On 01/06/2011 12:39 PM, David Rientjes wrote:
> On Thu, 30 Dec 2010, David Rientjes wrote:
> 
>> "x86, numa: Fake node-to-cpumask for NUMA emulation" broke the build when
>> CONFIG_DEBUG_PER_CPU_MAPS is set and CONFIG_NUMA_EMU is not.  This is
>> because it is possible to map a cpu to multiple nodes when NUMA emulation
>> is used; the patch required a physical node address table to find those
>> nodes that was only available when CONFIG_NUMA_EMU was enabled.
>>
>> This extracts the common debug functionality to its own function for
>> CONFIG_DEBUG_PER_CPU_MAPS and uses it regardless of whether
>> CONFIG_NUMA_EMU is set or not.
>>
>> NUMA emulation will now iterate over the set of possible nodes for each
>> cpu and call the new debug function whereas only the cpu's node will be
>> used without NUMA emulation enabled.
>>
>> Reported-by: Ingo Molnar <mingo@elte.hu>
>> Signed-off-by: David Rientjes <rientjes@google.com>
> 
> Ingo, do you know what the status of this fix is?  It's required for 
> x86/numa to build and I'd hate to see all of this fixes miss .38 because 
> of this failure.

If x86/numa would not be pushed to Linus. x86/apic-cleanups should be pushed at first.
or Thomas will take care of it?

Thanks

Yinghai



  reply	other threads:[~2011-01-06 21:26 UTC|newest]

Thread overview: 49+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-18  0:58 [PATCH 0/3] memblock related top down Yinghai Lu
2010-12-28  0:47 ` [PATCH 0/6] memblock related further cleanup for x86 Yinghai Lu
     [not found] ` <4D19320B.7030007@kernel.org>
2010-12-28  0:47   ` [PATCH 1/6] x86: Change get_max_mapped() to inline Yinghai Lu
2010-12-29 23:05     ` H. Peter Anvin
2010-12-29 23:30       ` Yinghai Lu
2010-12-29 23:37         ` Yinghai Lu
2010-12-29 23:42           ` H. Peter Anvin
2010-12-29 23:45     ` [PATCH -v2 " Yinghai Lu
2011-02-16  8:50     ` [tip:x86/mm] " tip-bot for Yinghai Lu
2010-12-28  0:48   ` [PATCH 2/6] x86, 64bit, numa: Allocate memnodemap under max_pfn_mapped Yinghai Lu
2011-02-16  8:50     ` [tip:x86/mm] x86-64, " tip-bot for Yinghai Lu
2010-12-28  0:48   ` [PATCH 3/6] x86, 64bit, numa: Put pgtable to local node memory Yinghai Lu
2010-12-29 23:46     ` [PATCH -v2 " Yinghai Lu
2010-12-29 23:50       ` H. Peter Anvin
2010-12-30  0:11         ` Yinghai Lu
2010-12-30  0:39           ` David Rientjes
2010-12-30  0:58             ` H. Peter Anvin
2010-12-30  1:07               ` David Rientjes
2010-12-30  1:53                 ` H. Peter Anvin
2010-12-30  9:06                   ` Ingo Molnar
2010-12-30 10:28                     ` [boot crash] " Ingo Molnar
2010-12-30 10:30                       ` Ingo Molnar
2010-12-30 12:01                         ` [build failure] " Ingo Molnar
2010-12-30 18:53                           ` David Rientjes
2010-12-30 18:54                             ` [patch] x86, numa: Fix CONFIG_DEBUG_PER_CPU_MAPS without NUMA emulation David Rientjes
2011-01-06 20:39                               ` David Rientjes
2011-01-06 21:25                                 ` Yinghai Lu [this message]
2011-01-06 23:58                                   ` David Rientjes
2011-01-07 15:32                               ` [tip:x86/numa] " tip-bot for David Rientjes
2010-12-30 21:18                         ` [boot crash] Re: [PATCH -v2 3/6] x86, 64bit, numa: Put pgtable to local node memory Yinghai Lu
     [not found]                           ` <AANLkTimpyRXS9dNFATh4GqtA46uynutAvK7Qb5S7WPFO@mail.gmail.com>
     [not found]                             ` <20110105134434.GA22816@elte.hu>
2011-01-05 21:24                               ` Yinghai Lu
2011-01-07 20:41                               ` [PATCH] memblock: Don't adjust size in memblock_find_base() Yinghai Lu
2011-01-10  5:56                                 ` Benjamin Herrenschmidt
2011-01-10  6:59                                   ` Yinghai Lu
2011-01-12  1:35                                   ` Yinghai Lu
2011-01-29  0:37                               ` [PATCH - resend] " Yinghai Lu
2011-02-03 20:25                                 ` Andrew Morton
2011-02-03 20:37                                   ` Yinghai Lu
2011-02-16  8:51     ` [tip:x86/mm] x86-64, numa: Put pgtable to local node memory tip-bot for Yinghai Lu
2010-12-28  0:48   ` [PATCH 4/6] x86: Use early pre-allocated page table buffer top-down Yinghai Lu
2010-12-28  0:48   ` [PATCH 5/6] x86, 64bit: Move out cleanup higmap [_brk_end, _end) out of init_memory_mapping() Yinghai Lu
2011-02-16  8:51     ` [tip:x86/mm] x86-64: " tip-bot for Yinghai Lu
2010-12-28  0:48   ` [PATCH 6/6] x86: Rename e820_table_* to pgt_buf_* Yinghai Lu
2010-12-30 21:54     ` [PATCH -v2 " Yinghai Lu
2010-12-28 20:21 ` [PATCH 0/3] memblock related top down H. Peter Anvin
2010-12-28 21:36   ` Yinghai Lu
2010-12-28 22:09     ` H. Peter Anvin
2010-12-28 22:25       ` Yinghai Lu
     [not found] <alpine.DEB.2.00.1012221700130.3701@chino.kir.corp.google.com>
2010-12-24 20:45 ` [patch 0/5] x86, numa: Fixes for NUMA emulation Ingo Molnar
2010-12-26 21:58   ` [patch] x86, numa: Fix CONFIG_DEBUG_PER_CPU_MAPS without " David Rientjes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D263350.5070008@kernel.org \
    --to=yinghai@kernel.org \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=rientjes@google.com \
    --cc=tglx@linutronix.de \
    --subject='Re: [patch] x86, numa: Fix CONFIG_DEBUG_PER_CPU_MAPS without NUMA emulation' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).