From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753859Ab1A1X2k (ORCPT ); Fri, 28 Jan 2011 18:28:40 -0500 Received: from mail-fx0-f46.google.com ([209.85.161.46]:48811 "EHLO mail-fx0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752836Ab1A1X2j (ORCPT ); Fri, 28 Jan 2011 18:28:39 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:x-enigmail-version:content-type :content-transfer-encoding; b=W8HuSDyMEQcaB7tf+qRZAJEhCebFped9UDj9CrQI7eRhIMUloiovtKJR4FXKmQ3iXi eS5fgOOfgmFUtU/IReEtIaPFLwZ0vJGhnzMZXKH8nEmwWVkkZ3g0ik0TPsQetJz42M0t 1z3hnxe7Ur8bqFSvcO+cP630lVfIaDnEoz3FA= Message-ID: <4D435123.3080003@suse.cz> Date: Sat, 29 Jan 2011 00:28:35 +0100 From: Jiri Slaby User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; cs-CZ; rv:1.9.2.13) Gecko/20101206 SUSE/3.1.7 Thunderbird/3.1.7 MIME-Version: 1.0 To: Kacper Kornet CC: Linus Torvalds , linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] Fix prlimit64 for suid/sgid processes References: <20110127134710.GB519@camk.edu.pl> <20110128232104.GA22667@camk.edu.pl> In-Reply-To: <20110128232104.GA22667@camk.edu.pl> X-Enigmail-Version: 1.1.2 Content-Type: text/plain; charset=ISO-8859-2 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/29/2011 12:21 AM, Kacper Kornet wrote: > Since check_prlimit_permission always fails in the case of SUID/GUID > processes, such processes are not able to read or set their own limits. > This commit changes this by assuming that process can always read/change > its own limits. > > Signed-off-by: Kacper Kornet ACK. The check comes from the ptrace code. I forgot to copy this test. > --- > kernel/sys.c | 3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) > > diff --git a/kernel/sys.c b/kernel/sys.c > index e9ad444..03bead7 100644 > --- a/kernel/sys.c > +++ b/kernel/sys.c > @@ -1375,7 +1375,8 @@ static int check_prlimit_permission(struct task_struct *task) > const struct cred *cred = current_cred(), *tcred; > > tcred = __task_cred(task); > - if ((cred->uid != tcred->euid || > + if (current != task && > + (cred->uid != tcred->euid || > cred->uid != tcred->suid || > cred->uid != tcred->uid || > cred->gid != tcred->egid || thanks, -- js suse labs