LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Jens Axboe <jaxboe@fusionio.com>
To: Jeff Moyer <jmoyer@redhat.com>
Cc: Vivek Goyal <vgoyal@redhat.com>,
	linux kernel mailing list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] blkio-throttle: Avoid calling blkiocg_lookup_group() for root group
Date: Mon, 31 Jan 2011 20:25:27 +0100	[thread overview]
Message-ID: <4D470CA7.7020508@fusionio.com> (raw)
In-Reply-To: <4D470C50.6010701@kernel.dk>

On 2011-01-31 20:24, Jens Axboe wrote:
> On 2011-01-31 20:20, Jeff Moyer wrote:
>> Vivek Goyal <vgoyal@redhat.com> writes:
>>
>>> On Mon, Jan 17, 2011 at 04:56:06PM -0500, Vivek Goyal wrote:
>>>> o Jeff Moyer was doing some testing on a RAM backed disk and
>>>>   blkiocg_lookup_group() showed up high overhead after memcpy(). Similarly
>>>>   somebody else reported that blkiocg_lookup_group() is eating 6% extra
>>>>   cpu. Though looking at the code I can't think why the overhead of
>>>>   this function is so high. One thing is that it is called with very high
>>>>   frequency (once for every IO).
>>>>
>>>> o For lot of folks blkio controller will be compiled in but they might
>>>>   not have actually created cgroups. Hence optimize the case of root
>>>>   cgroup where we can avoid calling blkiocg_lookup_group() if IO is happening
>>>>   in root group (common case).
>>>>
>>>> Reported-by: Jeff Moyer <jmoyer@redhat.com>
>>>> Signed-off-by: Vivek Goyal <vgoyal@redhat.com>
>>>
>>> Hi Jens,
>>>
>>> Do you have any concerns regarding this patch?
>>
>> Acked-by: Jeff Moyer <jmoyer@redhat.com>
>>
>> Jens, this is a pretty easy performance regression fixup.  I think it
>> should be pulled in sooner rather than later.  We've also witnessed this
>> slowdown on big performance testing rigs, so it's not just a ramdisk
>> issue.
> 
> Yep, will fold it into 2.6.38, thanks!

Just to be clear, it's queued up in for-linus so it will go to 2.6.38 on
the next push. It was updated last week, this is what it has so far:

Sergey Senozhatsky (1):
      loop: queue_lock NULL pointer derefence in blk_throtl_exit

Stephen M. Cameron (1):
      cciss: make cciss_revalidate not loop through CISS_MAX_LUNS volumes unnecessarily.

Tao Ma (1):
      blktrace: Don't output messages if NOTIFY isn't set.

Tracey Dent (2):
      drivers/block/Makefile: replace the use of <module>-objs with <module>-y
      drivers/block/aoe/Makefile: replace the use of <module>-objs with <module>-y

Vivek Goyal (2):
      cfq: rename a function to give it more appropriate name
      blkio-throttle: Avoid calling blkiocg_lookup_group() for root group

 block/blk-throttle.c       |   10 +++++++++-
 block/cfq-iosched.c        |    6 +++---
 drivers/block/Makefile     |    2 +-
 drivers/block/aoe/Makefile |    2 +-
 drivers/block/cciss.c      |    2 +-
 drivers/block/loop.c       |    3 +++
 kernel/trace/blktrace.c    |    7 +++++++
 7 files changed, 25 insertions(+), 7 deletions(-)

-- 
Jens Axboe


  reply	other threads:[~2011-01-31 19:28 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-17 21:56 Vivek Goyal
2011-01-17 22:00 ` Jeff Moyer
2011-01-26 18:57 ` Vivek Goyal
2011-01-31 19:20   ` Jeff Moyer
2011-01-31 19:24     ` Jens Axboe
2011-01-31 19:25       ` Jens Axboe [this message]
2011-01-31 19:30         ` Jeff Moyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D470CA7.7020508@fusionio.com \
    --to=jaxboe@fusionio.com \
    --cc=jmoyer@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=vgoyal@redhat.com \
    --subject='Re: [PATCH] blkio-throttle: Avoid calling blkiocg_lookup_group() for root group' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).