LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Patrick McHardy <kaber@trash.net>
To: Randy Dunlap <randy.dunlap@oracle.com>
Cc: Simon Horman <horms@verge.net.au>,
	netdev@vger.kernel.org, linux-next@vger.kernel.org,
	linux-kernel@vger.kernel.org, lvs-devel@vger.kernel.org,
	Stephen Rothwell <sfr@canb.auug.org.au>,
	Hans Schillstrom <hans@schillstrom.com>
Subject: Re: [GIT PULL nf-next-2.6] IPVS build fixes and clean-ups
Date: Tue, 01 Feb 2011 18:19:56 +0100	[thread overview]
Message-ID: <4D4840BC.4050303@trash.net> (raw)
In-Reply-To: <4D483D6E.5070007@oracle.com>

Am 01.02.2011 18:05, schrieb Randy Dunlap:
> On 02/01/11 02:04, Simon Horman wrote:
>> On Tue, Feb 01, 2011 at 03:06:37PM +1100, Simon Horman wrote:
>>> On Mon, Jan 31, 2011 at 04:50:09PM -0800, Randy Dunlap wrote:
>>>> On Tue,  1 Feb 2011 11:14:11 +1100 Simon Horman wrote:
>>>>
>>>>> Hi,
>>>>>
>>>>> This short patch series addresses two linux-next build problems
>>>>> raised by Randy Dunlap:
>>>>>
>>>>> * net/netfilter/ipvs/ip_vs_core.c:1891: warning: format '%lu' expects type 'long unsigned int', but argument 2 has type 'unsigned int'
>>>>> * ERROR: "unregister_net_sysctl_table" [net/netfilter/ipvs/ip_vs.ko]
>>>>>   ERROR: "register_net_sysctl_table" [net/netfilter/ipvs/ip_vs.ko] undefined!
>>>>>
>>>>> The remainder of the changset is cleanups that I noticed along the way.
>>>>
>>>> These 4 patches build successfully for me.
>>>> However, I do see these warnings (sorry I missed them earlier):
>>>>
>>>> WARNING: net/netfilter/ipvs/ip_vs.o(.init.text+0x161): Section mismatch in reference from the function init_module() to the function .exit.text:ip_vs_sync_cleanup()
>>>> WARNING: net/netfilter/ipvs/ip_vs.o(.init.text+0x161): Section mismatch in reference from the function init_module() to the function .exit.text:ip_vs_sync_cleanup()
>>>
>>> Thanks, I'll look into that. I will be travelling for a good portion of the
>>> next day and a bit so I apologise in advance if that delays my next patch.
>>
>> Hi,
>>
>> I the following patch seems to be the right fix for this to me.
>> I will send an amended pull request.
>>
>> IPVS: Remove ip_vs_sync_cleanup from section __exit
>>
>> ip_vs_sync_cleanup() may be called from ip_vs_init() on error
>> and thus needs to be accesible from section __init
>>
>> Reporte-by: Randy Dunlap <randy.dunlap@oracle.com>
>   Reported-by:
> 
>> Signed-off-by: Simon Horman <horms@verge.net.au>
> 
> Acked-by: Randy Dunlap <randy.dunlap@oracle.com>

Thanks, since Simon is travelling, I'll apply the patches now
with your and Hans's Acks and will push them to Dave later.

  reply	other threads:[~2011-02-01 17:19 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-01  0:14 Simon Horman
2011-02-01  0:14 ` [PATCH 1/4] IPVS: use z modifier for sizeof() argument Simon Horman
2011-02-01  0:14 ` [PATCH 2/4] IPVS: remove duplicate initialisation or rs_table Simon Horman
2011-02-01  0:14 ` [PATCH 3/4] IPVS: Remove unused variables Simon Horman
2011-02-01  0:14 ` [PATCH 4/4] IPVS: Allow compilation with CONFIG_SYSCTL disabled Simon Horman
2011-02-01  0:50 ` [GIT PULL nf-next-2.6] IPVS build fixes and clean-ups Randy Dunlap
2011-02-01  4:06   ` Simon Horman
2011-02-01 10:04     ` Simon Horman
2011-02-01 17:05       ` Randy Dunlap
2011-02-01 17:19         ` Patrick McHardy [this message]
2011-02-02 21:39           ` Simon Horman
2011-02-02 23:02             ` Patrick McHardy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D4840BC.4050303@trash.net \
    --to=kaber@trash.net \
    --cc=hans@schillstrom.com \
    --cc=horms@verge.net.au \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=lvs-devel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=randy.dunlap@oracle.com \
    --cc=sfr@canb.auug.org.au \
    --subject='Re: [GIT PULL nf-next-2.6] IPVS build fixes and clean-ups' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).