LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: "H. Peter Anvin" <hpa@zytor.com>
To: Gleb Natapov <gleb@redhat.com>
Cc: linux-kernel@vger.kernel.org,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	x86@kernel.org
Subject: Re: [PATCH] Fix EDD3.0 data verification.
Date: Wed, 02 Feb 2011 11:56:55 -0800	[thread overview]
Message-ID: <4D49B707.8000003@zytor.com> (raw)
In-Reply-To: <20110202175944.GC24871@redhat.com>

On 02/02/2011 09:59 AM, Gleb Natapov wrote:
> 
> Ah I see what length you were referring to params->device_path_info_length.
> If we will use that then we will get correct checksum for BIOSes that work
> according to phoenix spec too, but edd_show_interface() and edd_show_host_bus()
> handle only T13 spec so the information they show can be incorrect. I can
> change code to check that params->device_path_info_length == 44 in addition
> to checking csum. What do you think?
> 

Yes, you need to check both.

This is really a union of two similar-but-not-identical structures
distinguished by the length field.

	-hpa

  reply	other threads:[~2011-02-02 19:57 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-02 11:21 [PATCH] Fix EDD3.0 data verification Gleb Natapov
2011-02-02 13:30 ` Henrique de Moraes Holschuh
2011-02-02 13:38   ` Gleb Natapov
2011-02-02 17:14 ` H. Peter Anvin
2011-02-02 17:25   ` Gleb Natapov
2011-02-02 17:29     ` H. Peter Anvin
2011-02-02 17:38       ` Gleb Natapov
2011-02-02 17:59         ` Gleb Natapov
2011-02-02 19:56           ` H. Peter Anvin [this message]
2011-02-03 10:04             ` Gleb Natapov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D49B707.8000003@zytor.com \
    --to=hpa@zytor.com \
    --cc=gleb@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).