LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Thomas Chou <thomas@wytron.com.tw>
To: Grant Likely <grant.likely@secretlab.ca>
Cc: David Brownell <dbrownell@users.sourceforge.net>,
	linux-kernel@vger.kernel.org, nios2-dev@sopc.et.ntust.edu.tw,
	devicetree-discuss@lists.ozlabs.org,
	spi-devel-general@lists.sourceforge.net
Subject: Re: [PATCH v6] spi: New driver for Altera SPI
Date: Sat, 05 Feb 2011 21:08:38 +0800	[thread overview]
Message-ID: <4D4D4BD6.3040909@wytron.com.tw> (raw)
In-Reply-To: <20110203173430.GC6180@angua.secretlab.ca>

On 02/04/2011 01:34 AM, Grant Likely wrote:
> Hi Thomas, comments below, but looking pretty close.

Thanks a lot.

>> +config SPI_ALTERA
>> +	tristate "Altera SPI Controller"
>> +	select SPI_BITBANG
>
> Will this compile on all architectures?  Will it break allyesconfig
> on anything other than nios?

Yes, it compile on other architectures. I will add 'default n' though.

There are soft-core arm, mips and coldfire running on altera fpga. 
Others might use fpga as peripheral extender, too. So we shouldn't limit 
it to nios2.

>> +static int __init altera_spi_init(void)
>> +{
>> +	return platform_driver_probe(&altera_spidrv, altera_spi_probe);
>
> platform_driver_register() please, and put the altera_spi_probe()
> routine into the driver structure.

I will change it to register as you suggested.

- Thomas

  reply	other threads:[~2011-02-05 13:07 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-08  6:03 [PATCH] " Thomas Chou
2011-01-17  5:46 ` [PATCH v2] " Thomas Chou
2011-01-17  5:59   ` Stephen Rothwell
2011-01-17  6:22     ` Thomas Chou
2011-01-17  6:45       ` Grant Likely
2011-01-17  7:04         ` [PATCH v3] " Thomas Chou
2011-01-17  7:27           ` Sinan Akman
2011-01-18  1:33             ` Thomas Chou
2011-01-19  1:36             ` Thomas Chou
2011-01-17  6:56   ` [PATCH v2] " Grant Likely
2011-01-17  7:13     ` [PATCH v4] " Thomas Chou
2011-01-17  7:42       ` Grant Likely
2011-01-24  6:38         ` [PATCH v5] " Thomas Chou
2011-02-03 10:02           ` [PATCH v6] " Thomas Chou
2011-02-03 17:34             ` Grant Likely
2011-02-05 13:08               ` Thomas Chou [this message]
2011-02-05 14:02               ` [PATCH v7] " Thomas Chou
2011-02-06 20:23                 ` Peter Korsgaard
2011-02-08  2:43                   ` Thomas Chou
2011-02-08  5:21                   ` [PATCH v8] " Thomas Chou
2011-02-14  2:10                     ` [PATCH v9] " Thomas Chou
2011-02-14  2:20                       ` Ryan Mallon
2011-02-15  7:04                         ` Thomas Chou
2011-02-15  9:12                           ` Ryan Mallon
2011-02-15 19:42                           ` Grant Likely
2011-02-15 21:58                             ` Ryan Mallon
2011-02-16  2:47                       ` Grant Likely

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D4D4BD6.3040909@wytron.com.tw \
    --to=thomas@wytron.com.tw \
    --cc=dbrownell@users.sourceforge.net \
    --cc=devicetree-discuss@lists.ozlabs.org \
    --cc=grant.likely@secretlab.ca \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nios2-dev@sopc.et.ntust.edu.tw \
    --cc=spi-devel-general@lists.sourceforge.net \
    --subject='Re: [PATCH v6] spi: New driver for Altera SPI' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).