LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: "Jan Beulich" <JBeulich@novell.com>
To: <tj@kernel.org>, <cl@linux.com>
Cc: <mingo@elte.hu>, <tglx@linutronix.de>,
	<linux-kernel@vger.kernel.org>, <hpa@zytor.com>
Subject: x86: mis-named percpu_xchg_op() after switch to cmpxchg?
Date: Mon, 07 Feb 2011 11:01:09 +0000	[thread overview]
Message-ID: <4D4FDF050200007800030883@vpn.id2.novell.com> (raw)

Other than its name implies, with the switch to use cmpxchg instead of
xchg (commit 8270137a0d50507a5b40f880db636527045b8466) this
macro is no longer suitable for accessing anything that may be written
by other than the local CPU (i.e. anything but the various this_cpu
accessors). Shouldn't it therefore get renamed to eg this_cpu_xchg_op()?

Jan


             reply	other threads:[~2011-02-07 11:01 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-07 11:01 Jan Beulich [this message]
2011-02-07 17:17 ` Christoph Lameter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D4FDF050200007800030883@vpn.id2.novell.com \
    --to=jbeulich@novell.com \
    --cc=cl@linux.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=tglx@linutronix.de \
    --cc=tj@kernel.org \
    --subject='Re: x86: mis-named percpu_xchg_op() after switch to cmpxchg?' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).