LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH 1/1 V2] x86, apic: Make "broken BIOS!!" messages unique
@ 2011-02-07 13:58 John Villalovos
  2011-02-07 21:25 ` H. Peter Anvin
  0 siblings, 1 reply; 3+ messages in thread
From: John Villalovos @ 2011-02-07 13:58 UTC (permalink / raw)
  To: linux-kernel
  Cc: Thomas Gleixner, Ingo Molnar, H. Peter Anvin, x86, Yinghai Lu,
	Eric W. Biederman, linux-kernel, John Villalovos, prarit

x86, apic: Make "broken BIOS!!" messages unique

There are five identical "broken BIOS!!" messages.  This patch makes each
message unique so that it is easier to determine which message was actually
printed.  Changed to "broken MPBIOS: <unique identifier>!!"

The 'inconceivable' messages are because it should not be possible to reach
those code paths.

V2: Change to specify MPBIOS and remove exclamation marks.

Signed-off-by: John L. Villalovos <john.l.villalovos@intel.com>

diff --git a/arch/x86/kernel/apic/io_apic.c b/arch/x86/kernel/apic/io_apic.c
index 697dc34..5391276 100644
--- a/arch/x86/kernel/apic/io_apic.c
+++ b/arch/x86/kernel/apic/io_apic.c
@@ -841,7 +841,7 @@ static int MPBIOS_polarity(int idx)
 		}
 		case 2: /* reserved */
 		{
-			printk(KERN_WARNING "broken BIOS!!\n");
+			printk(KERN_WARNING "broken MPBIOS: polarity\n");
 			polarity = 1;
 			break;
 		}
@@ -852,7 +852,7 @@ static int MPBIOS_polarity(int idx)
 		}
 		default: /* invalid */
 		{
-			printk(KERN_WARNING "broken BIOS!!\n");
+			printk(KERN_WARNING "broken MPBIOS: inconceivable polarity\n");
 			polarity = 1;
 			break;
 		}
@@ -899,7 +899,7 @@ static int MPBIOS_trigger(int idx)
 				}
 				default:
 				{
-					printk(KERN_WARNING "broken BIOS!!\n");
+					printk(KERN_WARNING "broken MPBIOS: unknown bus type\n");
 					trigger = 1;
 					break;
 				}
@@ -913,7 +913,7 @@ static int MPBIOS_trigger(int idx)
 		}
 		case 2: /* reserved */
 		{
-			printk(KERN_WARNING "broken BIOS!!\n");
+			printk(KERN_WARNING "broken MPBIOS: trigger\n");
 			trigger = 1;
 			break;
 		}
@@ -924,7 +924,7 @@ static int MPBIOS_trigger(int idx)
 		}
 		default: /* invalid */
 		{
-			printk(KERN_WARNING "broken BIOS!!\n");
+			printk(KERN_WARNING "broken MPBIOS: inconceivable trigger\n");
 			trigger = 0;
 			break;
 		}

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH 1/1 V2] x86, apic: Make "broken BIOS!!" messages unique
  2011-02-07 13:58 [PATCH 1/1 V2] x86, apic: Make "broken BIOS!!" messages unique John Villalovos
@ 2011-02-07 21:25 ` H. Peter Anvin
  2011-02-07 21:33   ` John Villalovos
  0 siblings, 1 reply; 3+ messages in thread
From: H. Peter Anvin @ 2011-02-07 21:25 UTC (permalink / raw)
  To: John Villalovos
  Cc: linux-kernel, Thomas Gleixner, Ingo Molnar, x86, Yinghai Lu,
	Eric W. Biederman, John Villalovos, prarit

On 02/07/2011 05:58 AM, John Villalovos wrote:
> 
> The 'inconceivable' messages are because it should not be possible to reach
> those code paths.
> 

More standard terminology would be "invalid" or "impossible".
"Inconceivable" sounds like a combination of legal values which just
don't make sense.

	-hpa

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH 1/1 V2] x86, apic: Make "broken BIOS!!" messages unique
  2011-02-07 21:25 ` H. Peter Anvin
@ 2011-02-07 21:33   ` John Villalovos
  0 siblings, 0 replies; 3+ messages in thread
From: John Villalovos @ 2011-02-07 21:33 UTC (permalink / raw)
  To: H. Peter Anvin
  Cc: John Villalovos, linux-kernel, Thomas Gleixner, Ingo Molnar, x86,
	Yinghai Lu, Eric W. Biederman, prarit

On 02/07/2011 04:25 PM, H. Peter Anvin wrote:
> On 02/07/2011 05:58 AM, John Villalovos wrote:
>> The 'inconceivable' messages are because it should not be possible to reach
>> those code paths.
>>
> More standard terminology would be "invalid" or "impossible".
> "Inconceivable" sounds like a combination of legal values which just
> don't make sense.
To be honest I used it in homage to The Princess Bride movie.  And 
frankly it is 'inconcievable' that code will ever be called :)

John

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2011-02-07 21:33 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-02-07 13:58 [PATCH 1/1 V2] x86, apic: Make "broken BIOS!!" messages unique John Villalovos
2011-02-07 21:25 ` H. Peter Anvin
2011-02-07 21:33   ` John Villalovos

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).