LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Wolfgang Grandegger <wg@grandegger.com>
To: Tomoya MORINAGA <tomoya-linux@dsn.okisemi.com>
Cc: socketcan-core@lists.berlios.de, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org, andrew.chih.howe.khor@intel.com,
	qi.wang@intel.com, yong.y.wang@intel.com,
	toshiharu-linux@dsn.okisemi.com, kok.howg.ewe@intel.com,
	joel.clark@intel.com
Subject: Re: [PATCH 1/3] pch_can: fix 800k comms issue
Date: Wed, 09 Feb 2011 20:21:49 +0100	[thread overview]
Message-ID: <4D52E94D.8030400@grandegger.com> (raw)
In-Reply-To: <1297157343-3213-1-git-send-email-tomoya-linux@dsn.okisemi.com>

Hi Tomoya,

On 02/08/2011 10:29 AM, Tomoya MORINAGA wrote:
> Currently, 800k comms fails since prop_seg set zero.
> (EG20T PCH CAN register of prop_seg must be set more than 1)
> To prevent prop_seg set to zero, change tseg2_min 1 to 2.
> 
> Signed-off-by: Tomoya MORINAGA <tomoya-linux@dsn.okisemi.com>
> ---
>  drivers/net/can/pch_can.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/net/can/pch_can.c b/drivers/net/can/pch_can.c
> index c42e972..9b171d1 100644
> --- a/drivers/net/can/pch_can.c
> +++ b/drivers/net/can/pch_can.c
> @@ -187,7 +187,7 @@ static struct can_bittiming_const pch_can_bittiming_const = {
>  	.name = KBUILD_MODNAME,
>  	.tseg1_min = 1,
>  	.tseg1_max = 16,
> -	.tseg2_min = 1,
> +	.tseg2_min = 2,
>  	.tseg2_max = 8,
>  	.sjw_max = 4,
>  	.brp_min = 1,

I just realized that this fix is wrong. You wanted to set tseg1_min to 2
(and not tseg2_min). Could you please send a patch?

Thanks,

Wolfgang.

      parent reply	other threads:[~2011-02-09 19:19 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-08  9:29 Tomoya MORINAGA
2011-02-08  9:29 ` [PATCH 2/3] pch_can: fix rmmod issue Tomoya MORINAGA
2011-02-09  0:37   ` David Miller
2011-02-08  9:29 ` [PATCH 3/3] pch_can: fix module reload issue with MSI Tomoya MORINAGA
2011-02-09  0:37   ` David Miller
2011-02-09  0:37 ` [PATCH 1/3] pch_can: fix 800k comms issue David Miller
2011-02-09 19:21 ` Wolfgang Grandegger [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D52E94D.8030400@grandegger.com \
    --to=wg@grandegger.com \
    --cc=andrew.chih.howe.khor@intel.com \
    --cc=joel.clark@intel.com \
    --cc=kok.howg.ewe@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=qi.wang@intel.com \
    --cc=socketcan-core@lists.berlios.de \
    --cc=tomoya-linux@dsn.okisemi.com \
    --cc=toshiharu-linux@dsn.okisemi.com \
    --cc=yong.y.wang@intel.com \
    --subject='Re: [PATCH 1/3] pch_can: fix 800k comms issue' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).