LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Trinabh Gupta <trinabh@linux.vnet.ibm.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: arjan@linux.intel.com, lenb@kernel.org,
	suresh.b.siddha@intel.com, benh@kernel.crashing.org,
	venki@google.com, ak@linux.intel.com,
	linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH V3 0/3] cpuidle: Cleanup pm_idle and include driver/cpuidle.c in-kernel
Date: Thu, 10 Feb 2011 20:40:50 +0530	[thread overview]
Message-ID: <4D53FFFA.40704@linux.vnet.ibm.com> (raw)
In-Reply-To: <1297250478.13327.162.camel@laptop>

> On Tue, 2011-02-08 at 16:21 +0530, Trinabh Gupta wrote:
>>
>>   arch/x86/kernel/process.c     |  340 -------------------------------
>>   arch/x86/kernel/process_32.c  |    4
>>   arch/x86/kernel/process_64.c  |    4
>>   arch/x86/xen/setup.c          |    1
>>   drivers/acpi/processor_idle.c |    2
>>   drivers/cpuidle/Kconfig       |    9 +
>>   drivers/cpuidle/cpuidle.c     |   43 +++-
>>   drivers/cpuidle/driver.c      |  112 ++++++++++
>>   drivers/idle/Makefile         |    2
>>   drivers/idle/default_driver.c |  453 +++++++++++++++++++++++++++++++++++++++++
>>   include/linux/cpuidle.h       |    3
>>   11 files changed, 613 insertions(+), 360 deletions(-)
>>   create mode 100644 drivers/idle/default_driver.c
>
>
> # git grep -l "\<pm_idle\>" arch/x86/
> arch/x86/kernel/apm_32.c
> arch/x86/kernel/process.c
> arch/x86/kernel/process_32.c
> arch/x86/kernel/process_64.c
> arch/x86/xen/setup.c
>
> You seemed to have missed touching apm_32.c
>

Hi Peter,

Thanks for the review. Yes, I missed this; will take care of
this and cpu_idle_wait() in the next version.

Thanks,
-Trinabh

  reply	other threads:[~2011-02-10  9:41 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-08 10:51 Trinabh Gupta
2011-02-08 10:51 ` [RFC PATCH V3 1/3] cpuidle: Remove pm_idle pointer for x86 Trinabh Gupta
2011-02-08 10:52 ` [RFC PATCH V3 2/3] cpuidle: list based cpuidle driver registration and selection Trinabh Gupta
2011-02-09 11:17   ` Peter Zijlstra
2011-02-10  7:00     ` Vaidyanathan Srinivasan
2011-02-10  9:53       ` Peter Zijlstra
2011-02-10 17:16         ` Vaidyanathan Srinivasan
2011-02-08 10:52 ` [RFC PATCH V3 3/3] cpuidle: default idle driver for x86 Trinabh Gupta
2011-02-09 11:19   ` Peter Zijlstra
2011-02-09 11:21 ` [RFC PATCH V3 0/3] cpuidle: Cleanup pm_idle and include driver/cpuidle.c in-kernel Peter Zijlstra
2011-02-10 15:10   ` Trinabh Gupta [this message]
  -- strict thread matches above, loose matches on Subject: below --
2011-02-08 10:48 Trinabh Gupta

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D53FFFA.40704@linux.vnet.ibm.com \
    --to=trinabh@linux.vnet.ibm.com \
    --cc=ak@linux.intel.com \
    --cc=arjan@linux.intel.com \
    --cc=benh@kernel.crashing.org \
    --cc=lenb@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peterz@infradead.org \
    --cc=suresh.b.siddha@intel.com \
    --cc=venki@google.com \
    --subject='Re: [RFC PATCH V3 0/3] cpuidle: Cleanup pm_idle and include driver/cpuidle.c in-kernel' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).