LKML Archive on lore.kernel.org help / color / mirror / Atom feed
From: Ryan Mallon <ryan@bluewatersys.com> To: Thomas Chou <thomas@wytron.com.tw> Cc: David Brownell <dbrownell@users.sourceforge.net>, Grant Likely <grant.likely@secretlab.ca>, linux-kernel@vger.kernel.org, nios2-dev@sopc.et.ntust.edu.tw, devicetree-discuss@lists.ozlabs.org, spi-devel-general@lists.sourceforge.net Subject: Re: [PATCH v9] spi: New driver for Altera SPI Date: Mon, 14 Feb 2011 15:20:46 +1300 [thread overview] Message-ID: <4D58917E.9050408@bluewatersys.com> (raw) In-Reply-To: <1297649443-11491-1-git-send-email-thomas@wytron.com.tw> On 02/14/2011 03:10 PM, Thomas Chou wrote: > This patch adds a new SPI driver to support the Altera SOPC Builder > SPI component. It uses the bitbanging library. > > Signed-off-by: Thomas Chou <thomas@wytron.com.tw> > --- > +struct altera_spi { > + /* bitbang has to be first */ > + struct spi_bitbang bitbang; Is this still true? I had a quick look and can't see anything which relies on spi_bitbang being the first entry. Things like this should be using container_of so that position in the struct is irrelevant. ~Ryan -- Bluewater Systems Ltd - ARM Technology Solution Centre Ryan Mallon 5 Amuri Park, 404 Barbadoes St ryan@bluewatersys.com PO Box 13 889, Christchurch 8013 http://www.bluewatersys.com New Zealand Phone: +64 3 3779127 Freecall: Australia 1800 148 751 Fax: +64 3 3779135 USA 1800 261 2934
next prev parent reply other threads:[~2011-02-14 2:20 UTC|newest] Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top 2009-10-08 6:03 [PATCH] spi: New driver for Altera SPI Thomas Chou 2011-01-17 5:46 ` [PATCH v2] " Thomas Chou 2011-01-17 5:59 ` Stephen Rothwell 2011-01-17 6:22 ` Thomas Chou 2011-01-17 6:45 ` Grant Likely 2011-01-17 7:04 ` [PATCH v3] " Thomas Chou 2011-01-17 7:27 ` Sinan Akman 2011-01-18 1:33 ` Thomas Chou 2011-01-19 1:36 ` Thomas Chou 2011-01-17 6:56 ` [PATCH v2] " Grant Likely 2011-01-17 7:13 ` [PATCH v4] " Thomas Chou 2011-01-17 7:42 ` Grant Likely 2011-01-24 6:38 ` [PATCH v5] " Thomas Chou 2011-02-03 10:02 ` [PATCH v6] " Thomas Chou 2011-02-03 17:34 ` Grant Likely 2011-02-05 13:08 ` Thomas Chou 2011-02-05 14:02 ` [PATCH v7] " Thomas Chou 2011-02-06 20:23 ` Peter Korsgaard 2011-02-08 2:43 ` Thomas Chou 2011-02-08 5:21 ` [PATCH v8] " Thomas Chou 2011-02-14 2:10 ` [PATCH v9] " Thomas Chou 2011-02-14 2:20 ` Ryan Mallon [this message] 2011-02-15 7:04 ` Thomas Chou 2011-02-15 9:12 ` Ryan Mallon 2011-02-15 19:42 ` Grant Likely 2011-02-15 21:58 ` Ryan Mallon 2011-02-16 2:47 ` Grant Likely
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=4D58917E.9050408@bluewatersys.com \ --to=ryan@bluewatersys.com \ --cc=dbrownell@users.sourceforge.net \ --cc=devicetree-discuss@lists.ozlabs.org \ --cc=grant.likely@secretlab.ca \ --cc=linux-kernel@vger.kernel.org \ --cc=nios2-dev@sopc.et.ntust.edu.tw \ --cc=spi-devel-general@lists.sourceforge.net \ --cc=thomas@wytron.com.tw \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).