LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Corey Minyard <minyard@acm.org>
To: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
Cc: Grant Likely <grant.likely@secretlab.ca>,
	openipmi-developer@lists.sourceforge.net,
	linux-kernel@vger.kernel.org, Peter Huewe <peterhuewe@gmx.de>,
	Randy Dunlap <randy.dunlap@oracle.com>
Subject: Re: char/ipmi: cleanup_one_si section mismatch
Date: Mon, 14 Feb 2011 17:29:49 -0600	[thread overview]
Message-ID: <4D59BAED.9060501@acm.org> (raw)
In-Reply-To: <20110214150310.GA4350@swordfish.minsk.epam.com>

Yeah, I should have noticed this.

Acked-by: Corey Minyard <cminyard@mvista.com>

On 02/14/2011 09:03 AM, Sergey Senozhatsky wrote:
> Hello,
>
> commit d2478521afc20227658a10a8c5c2bf1a2aa615b3
> Author: Corey Minyard<minyard@acm.org>
> Date:   Thu Feb 10 16:08:38 2011 -0600
>
>      char/ipmi: fix OOPS caused by pnp_unregister_driver on unregistered driver
>
>
> Introduced section mismatch by calling __exit cleanup_ipmi_si
> from __devinit init_ipmi_si. Should we remove __exit annotation then?
>
>
> ---
>
>   drivers/char/ipmi/ipmi_si_intf.c |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/char/ipmi/ipmi_si_intf.c b/drivers/char/ipmi/ipmi_si_intf.c
> index 7855f9f..94cd2ce 100644
> --- a/drivers/char/ipmi/ipmi_si_intf.c
> +++ b/drivers/char/ipmi/ipmi_si_intf.c
> @@ -3532,7 +3532,7 @@ static void cleanup_one_si(struct smi_info *to_clean)
>   	kfree(to_clean);
>   }
>
> -static void __exit cleanup_ipmi_si(void)
> +static void cleanup_ipmi_si(void)
>   {
>   	struct smi_info *e, *tmp_e;
>
>


  reply	other threads:[~2011-02-14 23:30 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-14 15:03 Sergey Senozhatsky
2011-02-14 23:29 ` Corey Minyard [this message]
2011-02-15  9:52   ` [PATCH] char/ipmi: fix " Sergey Senozhatsky
2011-03-15 16:37     ` Randy Dunlap

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D59BAED.9060501@acm.org \
    --to=minyard@acm.org \
    --cc=grant.likely@secretlab.ca \
    --cc=linux-kernel@vger.kernel.org \
    --cc=openipmi-developer@lists.sourceforge.net \
    --cc=peterhuewe@gmx.de \
    --cc=randy.dunlap@oracle.com \
    --cc=sergey.senozhatsky@gmail.com \
    --subject='Re: char/ipmi: cleanup_one_si section mismatch' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).