LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Yinghai Lu <yinghai@kernel.org>
To: Ingo Molnar <mingo@elte.hu>, David Rientjes <rientjes@google.com>
Cc: Tejun Heo <tj@kernel.org>,
	linux-kernel@vger.kernel.org, x86@kernel.org, brgerst@gmail.com,
	gorcunov@gmail.com, shaohui.zheng@intel.com, rientjes@google.com,
	hpa@linux.intel.com, ankita@in.ibm.com
Subject: Re: [PATCHSET x86/numa] x86-64, NUMA: bring sanity to NUMA emulation
Date: Mon, 14 Feb 2011 21:44:42 -0800	[thread overview]
Message-ID: <4D5A12CA.3060908@kernel.org> (raw)
In-Reply-To: <20110215022842.GD31134@elte.hu>

On 02/14/2011 06:28 PM, Ingo Molnar wrote:
> 
> * Yinghai Lu <yinghai@kernel.org> wrote:
> 
>> On Mon, Feb 14, 2011 at 11:28 AM, Tejun Heo <tj@kernel.org> wrote:
>>> Hello,
>>>
>>> NUMA emulation is quite convoluted involving unnecessary mapping and
>>> reverse mapping between apicids, PXMs, nodes and memory addresses.
>>> This patchset tries to restore some sanity to the whole thing.
>>>
>>> Tested on an opteron NUMA machine which can do both ACPI and AMD
>>> configs.  All NUMA configs, emulations, !NUMA and UP work as expected.
>>>
>>> This patchset is on top of tip/x86/numa[1] +
>>> bring-sanity-to-NUMA-configuration patchset[2] and contains the
>>> following 7 patches.
>>>
>>>  0001-x86-64-NUMA-Trivial-changes-to-prepare-for-emulation.patch
>>>  0002-x86-64-NUMA-Build-and-use-direct-emulated-nid-phys-n.patch
>>>  0003-x86-64-NUMA-Make-emulation-code-build-numa_meminfo-a.patch
>>>  0004-x86-64-NUMA-Wrap-node-ID-during-emulation.patch
>>>  0005-x86-64-NUMA-Emulate-directly-from-numa_meminfo.patch
>>>  0006-x86-64-NUMA-Unify-emulated-apicid-node-mapping-trans.patch
>>>  0007-x86-64-NUMA-Unify-emulated-distance-mapping.patch
>>>
>>> The patchset is available in the following git branch.
>>>
>>>  git://git.kernel.org/pub/scm/linux/kernel/git/tj/misc.git x86_64-numa-emu-unify
>>>
>>> Diffstat follows.
>>>
>>>  arch/x86/include/asm/acpi.h    |    6
>>>  arch/x86/include/asm/amd_nb.h  |    4
>>>  arch/x86/include/asm/numa_64.h |    1
>>>  arch/x86/mm/amdtopology_64.c   |   47 ----
>>>  arch/x86/mm/numa_64.c          |  429 ++++++++++++++++++-----------------------
>>>  arch/x86/mm/srat_64.c          |   87 --------
>>>  6 files changed, 197 insertions(+), 377 deletions(-)
>>
>> wonder if numa_emu code could be put into one single file like numa_emu.c
> 
> That would be nice if it can be done sanely.
> 
> We could do it as a delta, on top of these existing patches, to not delay the 
> testing of these fixes/improvements, they are looking pretty good (on paper) 
> already, do you agree?

yes.

I went through TJ's numa-unify patches, and it looks good to me.
<except that I don't like putting setup_bootmem() etc in numa_register_memblks,
 but that could be addressed later>

For the numa-emu-unify, may need David to have a look on them.

Thanks

Yinghai


  reply	other threads:[~2011-02-15  5:46 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-14 19:28 Tejun Heo
2011-02-14 19:28 ` [PATCH 1/7] x86-64, NUMA: Trivial changes to prepare for emulation updates Tejun Heo
2011-02-14 19:28 ` [PATCH 2/7] x86-64, NUMA: Build and use direct emulated nid -> phys nid mapping Tejun Heo
2011-02-15 16:36   ` [PATCH UPDATED " Tejun Heo
2011-02-14 19:28 ` [PATCH 3/7] x86-64, NUMA: Make emulation code build numa_meminfo and share the registration path Tejun Heo
2011-02-14 19:28 ` [PATCH 4/7] x86-64, NUMA: Wrap node ID during emulation Tejun Heo
2011-02-14 19:28 ` [PATCH 5/7] x86-64, NUMA: Emulate directly from numa_meminfo Tejun Heo
2011-02-14 19:28 ` [PATCH 6/7] x86-64, NUMA: Unify emulated apicid -> node mapping transformation Tejun Heo
2011-02-14 19:28 ` [PATCH 7/7] x86-64, NUMA: Unify emulated distance mapping Tejun Heo
2011-02-14 20:00 ` [PATCHSET x86/numa] x86-64, NUMA: bring sanity to NUMA emulation Yinghai Lu
2011-02-15  2:28   ` Ingo Molnar
2011-02-15  5:44     ` Yinghai Lu [this message]
2011-02-15  9:26   ` Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D5A12CA.3060908@kernel.org \
    --to=yinghai@kernel.org \
    --cc=ankita@in.ibm.com \
    --cc=brgerst@gmail.com \
    --cc=gorcunov@gmail.com \
    --cc=hpa@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=rientjes@google.com \
    --cc=shaohui.zheng@intel.com \
    --cc=tj@kernel.org \
    --cc=x86@kernel.org \
    --subject='Re: [PATCHSET x86/numa] x86-64, NUMA: bring sanity to NUMA emulation' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).