LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Lars-Peter Clausen <lars@metafoo.de>
To: Kukjin Kim <kgene.kim@samsung.com>
Cc: "'Ben Dooks'" <ben-linux@fluff.org>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 09/09] ARM: s3c2440: gta02: Add touchscreen support
Date: Mon, 28 Feb 2011 11:44:53 +0100	[thread overview]
Message-ID: <4D6B7CA5.9010708@metafoo.de> (raw)
In-Reply-To: <000201cbd70d$4f67f1f0$ee37d5d0$%kim@samsung.com>

On 02/28/2011 07:04 AM, Kukjin Kim wrote:
> Lars-Peter Clausen wrote:
>>
>> This patch registers the s3c touchscreen and adc devices to add
> touchscreen
>> support for the gta02.
>>
>> Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
>> ---
>>  arch/arm/mach-s3c2440/mach-gta02.c |   12 ++++++++++++
>>  1 files changed, 12 insertions(+), 0 deletions(-)
>>
>> diff --git a/arch/arm/mach-s3c2440/mach-gta02.c
> b/arch/arm/mach-s3c2440/mach-
>> gta02.c
>> index 94456fa..2300ec5 100644
>> --- a/arch/arm/mach-s3c2440/mach-gta02.c
>> +++ b/arch/arm/mach-s3c2440/mach-gta02.c
>> @@ -79,6 +79,8 @@
>>  #include <mach/regs-mem.h>
>>  #include <mach/hardware.h>
>>
>> +#include <plat/ts.h>
>> +
> 
> Please group same/similar inclusion together like following.
> <linux/...> <asm/...> then <mach/...> or <plat/...>
> 
> In other words, please add your <plat/ts.h> inclusion after other <plat/...>

Ok.
> 
>>  #include <mach/gta02.h>
>>
>>  #include <plat/regs-serial.h>
>> @@ -480,6 +482,13 @@ static struct s3c2410_hcd_info gta02_usb_info
> __initdata
>> = {
>>  	},
>>  };
>>
>> +/* Touchscreen */
>> +static struct s3c2410_ts_mach_info gta02_ts_info = {
>> +	.delay = 10000,
>> +	.presc = 0xff, /* slow as we can go */
>> +	.oversampling_shift = 2,
>> +};
> 
> How about to use tab between member and = like following?
> 
> static struct s3c2410_ts_mach_info gta02_ts_info = {
> 	.delay			= 10000,
> 	.presc			= 0xff, /* slow as we can go */
> 	.oversampling_shift	= 2,
> };

Ok.

> 
>> +
>>  /* Buttons */
>>  static struct gpio_keys_button gta02_buttons[] = {
>>  	{
>> @@ -533,6 +542,8 @@ static struct platform_device *gta02_devices[]
> __initdata
>> = {
>>  	&samsung_asoc_dma,
>>  	&s3c_device_i2c0,
>>  	&gta02_buttons_device,
>> +	&s3c_device_adc,
> 
> No need to build plat-samsung/dev-adc.c for this?
> If you want to add '&s3c_deivce_adc', should add 'select SAMSUNG_DEV_ADC'
> into "config MACH_NEO1973_GTA02".

There appear to be two different definitions for s3c_deivce_adc one is in
plat-samsung/dev-adc.c the other is in plat-s3c24xx/devs.c. So if I select
SAMSUNG_DEV_ADC I'll actually get compile errors.
The definition in plat-s3c24xx/devs.c should probably be dropped, but thats
something for a different patch.


> 
>> +	&s3c_device_ts,
> 
> 'select SAMSUNG_DEV_TS'

Same here.

> 
>>  };
>>
>>  /* These guys DO need to be children of PMU. */
>> @@ -597,6 +608,7 @@ static void __init gta02_machine_init(void)
>>  #endif
>>
>>  	s3c24xx_udc_set_platdata(&gta02_udc_cfg);
>> +	s3c24xx_ts_set_platdata(&gta02_ts_info);
> 
> Same as above. 'select SAMSUNG_DEV_TS' should be added for
> plat-samsung/dev-ts.c.

And here.

> 
>>  	s3c_ohci_set_platdata(&gta02_usb_info);
>>  	s3c_nand_set_platdata(&gta02_nand_info);
>>  	s3c_i2c0_set_platdata(NULL);
>> --
>> 1.7.2.3
> 
> 
> Thanks.
> 
> Best regards,
> Kgene.
> --
> Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
> SW Solution Development Team, Samsung Electronics Co., Ltd.
> 


  reply	other threads:[~2011-02-28 10:43 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-07  1:51 [PATCH 01/09] ARM: s3c2442: gta02: Fix usage gpio bank j pin definitions Lars-Peter Clausen
2011-02-07  1:51 ` [PATCH 02/09] ARM: s3c2440: gta02: Register PCM device Lars-Peter Clausen
2011-02-28  6:38   ` Kukjin Kim
2011-02-07  1:51 ` [PATCH 03/09] ARM: s3c2440: gta02: Add button support Lars-Peter Clausen
2011-02-28  6:37   ` Kukjin Kim
2011-02-07  1:51 ` [PATCH 04/09] ARM: s3c2440: gta02: Select missing S3C_DEV_USB_HOST Lars-Peter Clausen
2011-02-28  6:31   ` Kukjin Kim
2011-02-07  1:51 ` [PATCH 05/09] ARM: s3c2440: gta02: Fix regulator valid_modes_ops Lars-Peter Clausen
2011-02-28  6:48   ` Kukjin Kim
2011-02-07  1:51 ` [PATCH 06/09] ARM: s3c2440: gta02: Remove state_mem constraints for the pcf50633 regulators Lars-Peter Clausen
2011-02-28  6:26   ` Kukjin Kim
2011-02-28 10:28     ` Lars-Peter Clausen
2011-02-28 10:58       ` Kukjin Kim
2011-02-07  1:51 ` [PATCH 07/09] ARM: s3c2440: gta02: Call regulator_has_full_constraints Lars-Peter Clausen
2011-02-07 11:58   ` Mark Brown
2011-02-08  2:55   ` [PATCH v2 " Lars-Peter Clausen
2011-02-28  6:47     ` Kukjin Kim
2011-02-07  1:52 ` [PATCH 08/09] ARM: s3c2440: gta02: Request usb pullup pin before using it Lars-Peter Clausen
2011-02-28  6:16   ` Kukjin Kim
2011-02-28 10:25     ` Lars-Peter Clausen
2011-02-28 10:44       ` Kukjin Kim
2011-02-28 10:58         ` Lars-Peter Clausen
2011-03-07  6:42           ` Kukjin Kim
2011-03-07  7:00             ` Lars-Peter Clausen
2011-02-07  1:52 ` [PATCH 09/09] ARM: s3c2440: gta02: Add touchscreen support Lars-Peter Clausen
2011-02-28  6:04   ` Kukjin Kim
2011-02-28 10:44     ` Lars-Peter Clausen [this message]
2011-02-28 10:57       ` Kukjin Kim
2011-02-28 11:17   ` [PATCH v2 " Lars-Peter Clausen
2011-02-28 11:56     ` Kukjin Kim
2011-02-18 10:41 ` [PATCH 01/09] ARM: s3c2442: gta02: Fix usage gpio bank j pin definitions Lars-Peter Clausen
2011-02-21  9:58   ` Kukjin Kim
2011-02-28  6:41 ` Kukjin Kim
2011-02-28 10:46   ` Lars-Peter Clausen
2011-02-28 10:49     ` Kukjin Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D6B7CA5.9010708@metafoo.de \
    --to=lars@metafoo.de \
    --cc=ben-linux@fluff.org \
    --cc=kgene.kim@samsung.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --subject='Re: [PATCH 09/09] ARM: s3c2440: gta02: Add touchscreen support' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).