LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Mike Christie <michaelc@cs.wisc.edu>
To: Randy Dunlap <rdunlap@xenotime.net>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
	scsi <linux-scsi@vger.kernel.org>,
	iscsi-driver@qlogic.com, linux-next@vger.kernel.org,
	LKML <linux-kernel@vger.kernel.org>,
	jejbscsi <jbottomley@parallels.com>,
	akpm <akpm@linux-foundation.org>
Subject: Re: [PATCH] scsi: qla4xxx needs libiscsi.o
Date: Thu, 15 Sep 2011 16:41:41 -0500	[thread overview]
Message-ID: <4E727115.8060603@cs.wisc.edu> (raw)
In-Reply-To: <20110831150200.54bec12e.rdunlap@xenotime.net>

On 08/31/2011 05:02 PM, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@xenotime.net>
> 
> qla4xxx driver needs to be linked with libiscsi.o to fix
> build errors.  This happens when no other drivers that use
> libiscsi.o are enabled.
> 
> Found in linux-next but applies to mainline also.
> 
> ERROR: "iscsi_conn_stop" [drivers/scsi/qla4xxx/qla4xxx.ko] undefined!
> ERROR: "iscsi_conn_get_addr_param" [drivers/scsi/qla4xxx/qla4xxx.ko] undefined!
> ERROR: "iscsi_session_teardown" [drivers/scsi/qla4xxx/qla4xxx.ko] undefined!
> ERROR: "iscsi_host_alloc" [drivers/scsi/qla4xxx/qla4xxx.ko] undefined!
> ERROR: "iscsi_conn_start" [drivers/scsi/qla4xxx/qla4xxx.ko] undefined!
> ERROR: "iscsi_conn_send_pdu" [drivers/scsi/qla4xxx/qla4xxx.ko] undefined!
> ERROR: "iscsi_session_get_param" [drivers/scsi/qla4xxx/qla4xxx.ko] undefined!
> ERROR: "iscsi_conn_get_param" [drivers/scsi/qla4xxx/qla4xxx.ko] undefined!
> ERROR: "iscsi_set_param" [drivers/scsi/qla4xxx/qla4xxx.ko] undefined!
> ERROR: "iscsi_session_failure" [drivers/scsi/qla4xxx/qla4xxx.ko] undefined!
> ERROR: "iscsi_complete_pdu" [drivers/scsi/qla4xxx/qla4xxx.ko] undefined!
> ERROR: "iscsi_session_setup" [drivers/scsi/qla4xxx/qla4xxx.ko] undefined!
> ERROR: "iscsi_conn_bind" [drivers/scsi/qla4xxx/qla4xxx.ko] undefined!
> ERROR: "iscsi_conn_setup" [drivers/scsi/qla4xxx/qla4xxx.ko] undefined!
> ERROR: "iscsi_itt_to_task" [drivers/scsi/qla4xxx/qla4xxx.ko] undefined!
> 
> Signed-off-by: Randy Dunlap <rdunlap@xenotime.net>
> ---
>  drivers/scsi/Makefile |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- linux-next-20110831.orig/drivers/scsi/Makefile
> +++ linux-next-20110831/drivers/scsi/Makefile
> @@ -88,7 +88,7 @@ obj-$(CONFIG_SCSI_QLOGIC_FAS)	+= qlogicf
>  obj-$(CONFIG_PCMCIA_QLOGIC)	+= qlogicfas408.o
>  obj-$(CONFIG_SCSI_QLOGIC_1280)	+= qla1280.o 
>  obj-$(CONFIG_SCSI_QLA_FC)	+= qla2xxx/
> -obj-$(CONFIG_SCSI_QLA_ISCSI)	+= qla4xxx/
> +obj-$(CONFIG_SCSI_QLA_ISCSI)	+= libiscsi.o qla4xxx/
>  obj-$(CONFIG_SCSI_LPFC)		+= lpfc/
>  obj-$(CONFIG_SCSI_BFA_FC)	+= bfa/
>  obj-$(CONFIG_SCSI_PAS16)	+= pas16.o


Sorry. Mixed this patch up with the other one sent that day. Looks ok.

Reviewed-by: Mike Christie <michaelc@cs.wisc.edu>

  reply	other threads:[~2011-09-15 21:37 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-31  5:01 linux-next: Tree for Aug 31 Stephen Rothwell
2011-08-31 22:02 ` [PATCH] scsi: qla4xxx needs libiscsi.o Randy Dunlap
2011-09-15 21:41   ` Mike Christie [this message]
2011-09-01 17:11 ` linux-next: Tree for Aug 31 (bridge + llc) Randy Dunlap

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E727115.8060603@cs.wisc.edu \
    --to=michaelc@cs.wisc.edu \
    --cc=akpm@linux-foundation.org \
    --cc=iscsi-driver@qlogic.com \
    --cc=jbottomley@parallels.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=rdunlap@xenotime.net \
    --cc=sfr@canb.auug.org.au \
    --subject='Re: [PATCH] scsi: qla4xxx needs libiscsi.o' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).