From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 851C8C10F25 for ; Wed, 11 Mar 2020 03:32:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5F3D621D56 for ; Wed, 11 Mar 2020 03:32:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728087AbgCKDco convert rfc822-to-8bit (ORCPT ); Tue, 10 Mar 2020 23:32:44 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:37154 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727659AbgCKDcn (ORCPT ); Tue, 10 Mar 2020 23:32:43 -0400 Received: from mail-pj1-f70.google.com ([209.85.216.70]) by youngberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1jBs6r-0007tk-S7 for linux-kernel@vger.kernel.org; Wed, 11 Mar 2020 03:32:42 +0000 Received: by mail-pj1-f70.google.com with SMTP id z20so358061pjn.3 for ; Tue, 10 Mar 2020 20:32:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=TO0qv6efKA7cZs1yfHfT13W25PN4EYUJVO1YMN34FnQ=; b=hNLp50cVtbsMIiFy8L19Bm1gBBQewCRRrGaV3LQlXIqxVEhPtN/o6KtvofUId586z1 p8wZNtNYk6IUH/ADT3NMYDw8ehGImtMnk65GOKSb22P5KxiVJQF6Wu1fm7YoYGPf+5VC bsuhJGAZklQaytwmBWsVeKQwYIjVmuYwvwdCQX7/QQruzKw5yHYUWgqu8pJvN/i2UZnO siUouhzAN59Cywi1jsZ5wxCeDHJD0uKox1k+Vbx/gEaobrKdBxmPqKc9q+7JgmoXDIQ0 ZlM0N66AYFPav20ZpC7mahRLyKnQ0V3p06Vjpt3e7wc5IvbMdCecB9KTv4Hbl7uPY6Dk xLfw== X-Gm-Message-State: ANhLgQ0C9zi6r5veLgbWiFO44MgrzVUcUq53Uzozd1Q0Dz4FtdJfO4n2 l9TehSGgyj5p/soRglq3NhM5ghETmkxVoWQbPivhS800+GTe4TY/LOzYBoeCR1l/VQ3NPoL2NcW 7eant6LJlIg9FlbfP3hHLx+0skb4MdPmZNBjIYItUIg== X-Received: by 2002:a65:53c5:: with SMTP id z5mr956094pgr.0.1583897559831; Tue, 10 Mar 2020 20:32:39 -0700 (PDT) X-Google-Smtp-Source: ADFU+vvHaCAuDG8ZXxP6dI2E0k+Q5QuKeZli0FiRJpCet81PmNlzXAF3LuHsh7RN9iPMIp47894dLg== X-Received: by 2002:a65:53c5:: with SMTP id z5mr956085pgr.0.1583897559542; Tue, 10 Mar 2020 20:32:39 -0700 (PDT) Received: from [192.168.1.208] (220-133-187-190.HINET-IP.hinet.net. [220.133.187.190]) by smtp.gmail.com with ESMTPSA id s23sm3567125pjp.28.2020.03.10.20.32.28 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 10 Mar 2020 20:32:38 -0700 (PDT) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 13.0 \(3608.60.0.2.5\)) Subject: Re: [RESEND] [PATCH v2 3/3] USB: Disable LPM on WD19's Realtek Hub From: Kai-Heng Feng In-Reply-To: <20200205112633.25995-3-kai.heng.feng@canonical.com> Date: Wed, 11 Mar 2020 11:32:27 +0800 Cc: Alan Stern , Mathias Nyman , AceLan Kao , "open list:USB NETWORKING DRIVERS" , open list Content-Transfer-Encoding: 8BIT Message-Id: <4F77B65D-77B0-4E63-ADB3-BF127BDE3BA2@canonical.com> References: <20200205112633.25995-1-kai.heng.feng@canonical.com> <20200205112633.25995-3-kai.heng.feng@canonical.com> To: Greg Kroah-Hartman X-Mailer: Apple Mail (2.3608.60.0.2.5) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Greg, > On Feb 5, 2020, at 19:26, Kai-Heng Feng wrote: > > Realtek Hub (0bda:0x0487) used in Dell Dock WD19 sometimes drops off the > bus when bringing underlying ports from U3 to U0. > > Disabling LPM on the hub during setting link state is not enough, so > let's disable LPM completely for this hub. > > Signed-off-by: Kai-Heng Feng As Mathias stated, this patch can be considered as a separate one. Can you please review and merge this patch? Kai-Heng > --- > v2: > - Use quirk instead of the original approach. > > drivers/usb/core/quirks.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/usb/core/quirks.c b/drivers/usb/core/quirks.c > index 6b6413073584..2fb7c1602280 100644 > --- a/drivers/usb/core/quirks.c > +++ b/drivers/usb/core/quirks.c > @@ -371,6 +371,9 @@ static const struct usb_device_id usb_quirk_list[] = { > { USB_DEVICE(0x0b05, 0x17e0), .driver_info = > USB_QUIRK_IGNORE_REMOTE_WAKEUP }, > > + /* Realtek hub in Dell WD19 (Type-C) */ > + { USB_DEVICE(0x0bda, 0x0487), .driver_info = USB_QUIRK_NO_LPM }, > + > /* Action Semiconductor flash disk */ > { USB_DEVICE(0x10d6, 0x2200), .driver_info = > USB_QUIRK_STRING_FETCH_255 }, > -- > 2.17.1 >