LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: skakit@codeaurora.org
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Rob Herring <robh+dt@kernel.org>, Andy Gross <agross@kernel.org>,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	David Collins <collinsd@codeaurora.org>,
	Kiran Gunda <kgunda@codeaurora.org>,
	"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
	<devicetree@vger.kernel.org>, MSM <linux-arm-msm@vger.kernel.org>
Subject: Re: [PATCH 1/2] pinctrl: qcom: spmi-gpio: correct parent irqspec translation
Date: Mon, 16 Aug 2021 12:20:37 +0530	[thread overview]
Message-ID: <4af8171aefd6f0387438225666ec1ccc@codeaurora.org> (raw)
In-Reply-To: <CACRpkdZteWY6X+prHeAF0rtPVbCk+X9=ZYgpjgAMH24LhOjhaQ@mail.gmail.com>

Hi Linus,

On 2021-08-13 14:27, Linus Walleij wrote:
> Hi Satya/David,
> 
> nice work on identifying this bug!
> 
> On Fri, Aug 13, 2021 at 6:56 AM satya priya <skakit@codeaurora.org> 
> wrote:
>> 
>> From: David Collins <collinsd@codeaurora.org>
>> 
>> pmic_gpio_child_to_parent_hwirq() and
>> gpiochip_populate_parent_fwspec_fourcell() translate a pinctrl-
>> spmi-gpio irqspec to an SPMI controller irqspec.  When they do
>> this, they use a fixed SPMI slave ID of 0 and a fixed GPIO
>> peripheral offset of 0xC0 (corresponding to SPMI address 0xC000).
>> This translation results in an incorrect irqspec for secondary
>> PMICs that don't have a slave ID of 0 as well as for PMIC chips
>> which have GPIO peripherals located at a base address other than
>> 0xC000.
>> 
>> Correct this issue by passing the slave ID of the pinctrl-spmi-
>> gpio device's parent in the SPMI controller irqspec and by
>> calculating the peripheral ID base from the device tree 'reg'
>> property of the pinctrl-spmi-gpio device.
>> 
>> Signed-off-by: David Collins <collinsd@codeaurora.org>
>> Signed-off-by: satya priya <skakit@codeaurora.org>
> 
> Is this a regression or is it fine if I just apply it for v5.15?
> I was thinking v5.15 since it isn't yet used in device trees.
> 

Without this fix, [2/2] Vol+ support is failing. If possible please 
merge it on current branch.

> Yours,
> Linus Walleij

  reply	other threads:[~2021-08-16  6:51 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-13  4:55 [PATCH 0/2] Add Vol+ support for sc7280-idp satya priya
2021-08-13  4:55 ` [PATCH 1/2] pinctrl: qcom: spmi-gpio: correct parent irqspec translation satya priya
2021-08-13  8:57   ` Linus Walleij
2021-08-16  6:50     ` skakit [this message]
2021-08-16 21:08       ` Stephen Boyd
2021-08-17  9:06         ` skakit
2021-08-17 19:15           ` Stephen Boyd
2021-08-18  5:26             ` skakit
2021-09-02  3:37               ` Stephen Boyd
2021-08-13  4:55 ` [PATCH 2/2] arm64: dts: sc7280: Add volume up support for sc7280-idp satya priya

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4af8171aefd6f0387438225666ec1ccc@codeaurora.org \
    --to=skakit@codeaurora.org \
    --cc=agross@kernel.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=collinsd@codeaurora.org \
    --cc=devicetree@vger.kernel.org \
    --cc=kgunda@codeaurora.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --subject='Re: [PATCH 1/2] pinctrl: qcom: spmi-gpio: correct parent irqspec translation' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).