From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E40ACC4320E for ; Mon, 16 Aug 2021 06:51:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BD24261406 for ; Mon, 16 Aug 2021 06:51:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233604AbhHPGvc (ORCPT ); Mon, 16 Aug 2021 02:51:32 -0400 Received: from m43-7.mailgun.net ([69.72.43.7]:36788 "EHLO m43-7.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233571AbhHPGvb (ORCPT ); Mon, 16 Aug 2021 02:51:31 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1629096660; h=Message-ID: References: In-Reply-To: Subject: Cc: To: From: Date: Content-Transfer-Encoding: Content-Type: MIME-Version: Sender; bh=gdILqRmVTD/TFVQVBfNPgHl11ZlKVgr1wHcPFQbbszM=; b=Ag7pMNo9NM4YEz/piukAZgstpiYn19UHawj4Se3F3q6DPcRHz7WnXE8Ptkj4I6sCoa/Cq41q 6c+tNgRzxUmmZwEfQmuLCPrznhPM8J3bfZkNAGbodZeEKcgNxffThPPaz7hLtLbCp9gTFacS NjAXusbjtjiLA/40kVcSckbCd48= X-Mailgun-Sending-Ip: 69.72.43.7 X-Mailgun-Sid: WyI0MWYwYSIsICJsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n03.prod.us-west-2.postgun.com with SMTP id 611a0abef746c298d91898e3 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Mon, 16 Aug 2021 06:50:38 GMT Sender: skakit=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 2391BC43617; Mon, 16 Aug 2021 06:50:38 +0000 (UTC) Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: skakit) by smtp.codeaurora.org (Postfix) with ESMTPSA id 69BFCC4360C; Mon, 16 Aug 2021 06:50:37 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Mon, 16 Aug 2021 12:20:37 +0530 From: skakit@codeaurora.org To: Linus Walleij Cc: Rob Herring , Andy Gross , Bjorn Andersson , David Collins , Kiran Gunda , "open list:GPIO SUBSYSTEM" , linux-kernel , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , MSM Subject: Re: [PATCH 1/2] pinctrl: qcom: spmi-gpio: correct parent irqspec translation In-Reply-To: References: <1628830531-14648-1-git-send-email-skakit@codeaurora.org> <1628830531-14648-2-git-send-email-skakit@codeaurora.org> Message-ID: <4af8171aefd6f0387438225666ec1ccc@codeaurora.org> X-Sender: skakit@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Linus, On 2021-08-13 14:27, Linus Walleij wrote: > Hi Satya/David, > > nice work on identifying this bug! > > On Fri, Aug 13, 2021 at 6:56 AM satya priya > wrote: >> >> From: David Collins >> >> pmic_gpio_child_to_parent_hwirq() and >> gpiochip_populate_parent_fwspec_fourcell() translate a pinctrl- >> spmi-gpio irqspec to an SPMI controller irqspec. When they do >> this, they use a fixed SPMI slave ID of 0 and a fixed GPIO >> peripheral offset of 0xC0 (corresponding to SPMI address 0xC000). >> This translation results in an incorrect irqspec for secondary >> PMICs that don't have a slave ID of 0 as well as for PMIC chips >> which have GPIO peripherals located at a base address other than >> 0xC000. >> >> Correct this issue by passing the slave ID of the pinctrl-spmi- >> gpio device's parent in the SPMI controller irqspec and by >> calculating the peripheral ID base from the device tree 'reg' >> property of the pinctrl-spmi-gpio device. >> >> Signed-off-by: David Collins >> Signed-off-by: satya priya > > Is this a regression or is it fine if I just apply it for v5.15? > I was thinking v5.15 since it isn't yet used in device trees. > Without this fix, [2/2] Vol+ support is failing. If possible please merge it on current branch. > Yours, > Linus Walleij