LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Eugene Shalygin <eugene.shalygin@gmail.com>,
Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Denis Pauk <pauk.denis@gmail.com>,
Platform Driver <platform-driver-x86@vger.kernel.org>,
thomas@weissschuh.net, Jean Delvare <jdelvare@suse.com>,
linux-hwmon@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/3] hwmon: (nct6775) Implement custom lock by ACPI mutex.
Date: Thu, 25 Nov 2021 05:51:06 -0800 [thread overview]
Message-ID: <4b00cd7e-4d40-8220-b313-6a5f8381b5af@roeck-us.net> (raw)
In-Reply-To: <CAB95QASDiwM+-AwPgGfc7dP=Ctm0s2WP4xrapJzNHJ22B9foAw@mail.gmail.com>
On 11/25/21 5:14 AM, Eugene Shalygin wrote:
> Dear Andy, Denis, and Günter,
>
> Denis worked on my code with the first attempt to read EC sensors from
> ASUS motherboards and submitted it as a driver named
> "asus_wmi_ec_sensors", which is not in hwmon-next. Now he adds the
> ACPI lock feature to support other motherboards, and I have another
> iteration of the EC sensor driver under development (needs some
> polishment) that utilizes the same concept (ACPI lock instead of WMI
> methods), which is smaller, cleaner and faster than the WMI-based one.
> I'm going to submit it to the mainline too. I think it should replace
> the WMI one. In anticipation of that, can we change the name of the
> accepted driver (asus_wmi_ec_sensors -> asus_ec_sensors) now, in order
> to not confuse users in the next version and to remove implementation
> detail from the module name? The drivers provide indistinguishable
> data to HWMON.
>
Two drivers with the same functionality ? What would be the benefit of that ?
Why not drop the current one entirely instead ?
Guenter
next prev parent reply other threads:[~2021-11-25 13:56 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-22 21:28 [PATCH 0/3] hwmon: (nct6775) Support lock by ACPI mutex Denis Pauk
2021-11-22 21:28 ` [PATCH 1/3] hwmon: (nct6775) Use nct6775_*() lock function pointers in nct6775_data Denis Pauk
2021-11-24 16:03 ` Andy Shevchenko
2021-11-25 21:07 ` Denis Pauk
2021-11-25 21:50 ` Andy Shevchenko
2021-11-22 21:28 ` [PATCH 2/3] hwmon: (nct6775) Implement custom lock by ACPI mutex Denis Pauk
2021-11-24 16:10 ` Andy Shevchenko
2021-11-25 13:14 ` Eugene Shalygin
2021-11-25 13:16 ` Eugene Shalygin
2021-11-25 13:51 ` Guenter Roeck [this message]
2021-11-25 13:54 ` Eugene Shalygin
2021-11-25 13:51 ` Andy Shevchenko
2021-11-25 14:00 ` Eugene Shalygin
2021-11-25 19:54 ` Guenter Roeck
2021-11-25 20:05 ` Eugene Shalygin
2021-11-25 20:09 ` Andy Shevchenko
2021-11-25 20:25 ` Denis Pauk
2021-11-25 20:33 ` Eugene Shalygin
2021-11-25 21:52 ` Andy Shevchenko
2021-11-25 20:28 ` Eugene Shalygin
2021-11-22 21:28 ` [PATCH 3/3] hwmon: (nct6775) add MAXIMUS VII HERO Denis Pauk
2021-11-24 16:21 ` Andy Shevchenko
2021-11-24 16:24 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4b00cd7e-4d40-8220-b313-6a5f8381b5af@roeck-us.net \
--to=linux@roeck-us.net \
--cc=andy.shevchenko@gmail.com \
--cc=eugene.shalygin@gmail.com \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pauk.denis@gmail.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=thomas@weissschuh.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).