LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Baolin Wang <baolin.wang@linux.alibaba.com>
To: Shuah Khan <skhan@linuxfoundation.org>,
	shuah@kernel.org, Christian Brauner <christian@brauner.io>,
	Aleksa Sarai <cyphar@cyphar.com>
Cc: linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] selftests: openat2: Fix testing failure for O_LARGEFILE flag
Date: Tue, 24 Aug 2021 13:26:00 +0800	[thread overview]
Message-ID: <4b7f320a-53d0-982a-b441-60e2ce86bfae@linux.alibaba.com> (raw)
In-Reply-To: <a9dc1616-61b9-c010-950c-521693c74247@linuxfoundation.org>

Hi Shuah,

On 2021/8/24 3:23, Shuah Khan wrote:
> Hi Baolin,
> 
> On 8/22/21 8:40 PM, Baolin Wang wrote:
>> Hi Shuah,
>>
>> On 2021/7/28 20:32, Baolin Wang wrote:
>>> Hi,
>>>
>>>> When running the openat2 test suite on ARM64 platform, we got below 
>>>> failure,
>>>> since the definition of the O_LARGEFILE is different on ARM64. So we 
>>>> can
>>>> set the correct O_LARGEFILE definition on ARM64 to fix this issue.
>>>
>>> Sorry, I forgot to copy the failure log:
>>>
> 
> Please cc everybody get_maintainers.pl suggests. You are missing
> key reviewers for this change.
> 
> Adding Christian Brauner and Aleksa Sarai to the thread.

Thanks.

> 
>>> # openat2 unexpectedly returned # 
>>> 3['/lkp/benchmarks/kernel_selftests/tools/testing/selftests/openat2'] 
>>> with 208000 (!= 208000)
> 
> Not sure I understand this. 208000 (!= 208000) look sthe same to me.

These are not the error message, just show the fd flags. The error is it 
should return -22 (-EINVAL) for this test case, but it returns 3 which 
indicates a successful openat2() calling.

>>> not ok 102 openat2 with incompatible flags (O_PATH | O_LARGEFILE) 
>>> fails with -22 (Invalid argument)
>>>
>>>>
>>>> Signed-off-by: Baolin Wang <baolin.wang@linux.alibaba.com>
>>
>> Could you apply this patch if no objection from your side? Thanks.
>>
> 
> Ideally this define should come from an include file.
> 
> Christian, Aleksa,
> 
> Can you review this patch and let me know if this approach looks right.
> 
>>>> ---
>>>>   tools/testing/selftests/openat2/openat2_test.c | 4 ++++
>>>>   1 file changed, 4 insertions(+)
>>>>
>>>> diff --git a/tools/testing/selftests/openat2/openat2_test.c 
>>>> b/tools/testing/selftests/openat2/openat2_test.c
>>>> index d7ec1e7..1bddbe9 100644
>>>> --- a/tools/testing/selftests/openat2/openat2_test.c
>>>> +++ b/tools/testing/selftests/openat2/openat2_test.c
>>>> @@ -22,7 +22,11 @@
>>>>    * XXX: This is wrong on {mips, parisc, powerpc, sparc}.
>>>>    */
>>>>   #undef    O_LARGEFILE
>>>> +#ifdef __aarch64__
>>>> +#define    O_LARGEFILE 0x20000
>>>> +#else
>>>>   #define    O_LARGEFILE 0x8000
>>>> +#endif
>>>>   struct open_how_ext {
>>>>       struct open_how inner;
>>>>
>>
> 
> thanks,
> -- Shuah

  reply	other threads:[~2021-08-24  5:25 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-28 12:29 Baolin Wang
2021-07-28 12:32 ` Baolin Wang
2021-08-23  2:40   ` Baolin Wang
2021-08-23 19:23     ` Shuah Khan
2021-08-24  5:26       ` Baolin Wang [this message]
2021-08-24 11:21       ` Aleksa Sarai
2021-08-24 11:36         ` Christian Brauner
2021-08-24 14:33           ` Shuah Khan
2021-08-24 16:50             ` Shuah Khan
2021-08-25  1:49               ` Baolin Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4b7f320a-53d0-982a-b441-60e2ce86bfae@linux.alibaba.com \
    --to=baolin.wang@linux.alibaba.com \
    --cc=christian@brauner.io \
    --cc=cyphar@cyphar.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=shuah@kernel.org \
    --cc=skhan@linuxfoundation.org \
    --subject='Re: [PATCH] selftests: openat2: Fix testing failure for O_LARGEFILE flag' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).