LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: "Mukunda,Vijendar" <vijendar.mukunda@amd.com>
To: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
	broonie@kernel.org, alsa-devel@alsa-project.org
Cc: Sunil-kumar.Dommati@amd.com,
	open list <linux-kernel@vger.kernel.org>,
	Takashi Iwai <tiwai@suse.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Alexander.Deucher@amd.com, krisman@collabora.com
Subject: Re: [PATCH v4 09/12] ASoC: amd: add vangogh i2s dai driver ops
Date: Wed, 21 Jul 2021 04:38:08 +0530	[thread overview]
Message-ID: <4bba4d88-c064-7ee3-cddd-edfc5a047a1c@amd.com> (raw)
In-Reply-To: <6983b9cf-d270-1033-5481-f8aa5bb378d9@linux.intel.com>

On 7/21/21 12:00 AM, Pierre-Louis Bossart wrote:
> 
>> diff --git a/sound/soc/amd/vangogh/acp5x.h b/sound/soc/amd/vangogh/acp5x.h
>> index 2300e63534e7..c94ed8795b9c 100644
>> --- a/sound/soc/amd/vangogh/acp5x.h
>> +++ b/sound/soc/amd/vangogh/acp5x.h
>> @@ -74,9 +74,20 @@
>>  #define I2S_MASTER_MODE_ENABLE 0x01
>>  #define I2S_MASTER_MODE_DISABLE 0x00
>>  
>> +#define SLOT_WIDTH_8 0x08
>> +#define SLOT_WIDTH_16 0x10
>> +#define SLOT_WIDTH_24 0x18
>> +#define SLOT_WIDTH_32 0x20
> 
> nit-pick: it's not incorrect but is the hex notation necessary?

Will fix it and post the new version

> 
>> +#define TDM_ENABLE 1
>> +#define TDM_DISABLE 0
>> +#define ACP5x_ITER_IRER_SAMP_LEN_MASK	0x38


  reply	other threads:[~2021-07-20 22:51 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20210720163732.23003-1-Vijendar.Mukunda@amd.com>
2021-07-20 16:37 ` [PATCH v4 01/12] ASoC: amd: add Vangogh ACP5x IP register header Vijendar Mukunda
2021-07-20 16:37 ` [PATCH v4 02/12] ASoC: amd: add Vangogh ACP PCI driver Vijendar Mukunda
2021-07-20 16:37 ` [PATCH v4 03/12] ASoc: amd: add acp5x init/de-init functions Vijendar Mukunda
2021-07-20 16:37 ` [PATCH v4 04/12] ASoC: amd: create acp5x platform devices Vijendar Mukunda
2021-07-20 16:37 ` [PATCH v4 05/12] ASoC: amd: add ACP5x PCM platform driver Vijendar Mukunda
2021-07-20 18:12   ` Pierre-Louis Bossart
2021-07-20 23:11     ` Mukunda,Vijendar
2021-07-20 16:37 ` [PATCH v4 06/12] ASoC: amd: irq handler changes for ACP5x PCM dma driver Vijendar Mukunda
2021-07-20 16:37 ` [PATCH v4 07/12] ASoC: amd: add ACP5x pcm dma driver ops Vijendar Mukunda
2021-07-20 18:27   ` Pierre-Louis Bossart
2021-07-20 23:10     ` Mukunda,Vijendar
2021-07-20 16:37 ` [PATCH v4 08/12] ASoC: amd: add vangogh i2s controller driver Vijendar Mukunda
2021-07-20 16:37 ` [PATCH v4 09/12] ASoC: amd: add vangogh i2s dai driver ops Vijendar Mukunda
2021-07-20 18:30   ` Pierre-Louis Bossart
2021-07-20 23:08     ` Mukunda,Vijendar [this message]
2021-07-20 16:37 ` [PATCH v4 10/12] ASoC: amd: add vangogh pci driver pm ops Vijendar Mukunda
2021-07-20 16:37 ` [PATCH v4 11/12] ASoC: amd: add vangogh i2s dma " Vijendar Mukunda
2021-07-20 16:37 ` [PATCH v4 12/12] ASoC: amd: enable vangogh acp5x driver build Vijendar Mukunda
2021-07-20 18:31   ` Pierre-Louis Bossart
2021-07-20 23:06     ` Mukunda,Vijendar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4bba4d88-c064-7ee3-cddd-edfc5a047a1c@amd.com \
    --to=vijendar.mukunda@amd.com \
    --cc=Alexander.Deucher@amd.com \
    --cc=Sunil-kumar.Dommati@amd.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=krisman@collabora.com \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pierre-louis.bossart@linux.intel.com \
    --cc=tiwai@suse.com \
    --subject='Re: [PATCH v4 09/12] ASoC: amd: add vangogh i2s dai driver ops' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).