LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Tianyu Lan <ltykernel@gmail.com>
To: Praveen Kumar <kumarpraveen@linux.microsoft.com>,
	kys@microsoft.com, haiyangz@microsoft.com,
	sthemmin@microsoft.com, wei.liu@kernel.org, decui@microsoft.com,
	tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
	x86@kernel.org, hpa@zytor.com, michael.h.kelley@microsoft.com
Cc: Tianyu Lan <Tianyu.Lan@microsoft.com>,
	linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org,
	vkuznets@redhat.com
Subject: Re: [PATCH] x86/Hyper-V: Initialize Hyper-V stimer after enabling lapic
Date: Thu, 5 Aug 2021 20:45:43 +0800	[thread overview]
Message-ID: <4ceb1504-205a-26fc-2fec-2d87f8601b31@gmail.com> (raw)
In-Reply-To: <db8d38c9-e11d-1abe-8617-d8a231cc22e2@linux.microsoft.com>

Hi Praveen:
     Thanks for your review.

On 8/5/2021 2:41 PM, Praveen Kumar wrote:
>> +
>> +static void __init hv_setup_initr_mode(void)
>> +{
>> +	if (old_setup_initr_mode)
>> +		old_setup_initr_mode();
>> +
>> +	/*
>> +	 * The direct-mode STIMER depends on LAPIC and so allocate
>> +	 * STIMER after calling initr node callback.
>> +	 */
>> +	(void)hv_stimer_alloc(false);
> In my understanding, in previous implementation we were ignoring the return error as there was a fallback handling for LAPIC.
> However, I'm not seeing the same here, or am I missing something ?
> 

Nice catch. The original comment should be keep and will add back in the 
next version.


  reply	other threads:[~2021-08-05 12:45 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-04 18:48 [PATCH] x86/Hyper-V: Initialize Hyper-V stimer after enabling lapic Tianyu Lan
2021-08-05  6:41 ` Praveen Kumar
2021-08-05 12:45   ` Tianyu Lan [this message]
2021-08-05 17:35 ` Michael Kelley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4ceb1504-205a-26fc-2fec-2d87f8601b31@gmail.com \
    --to=ltykernel@gmail.com \
    --cc=Tianyu.Lan@microsoft.com \
    --cc=bp@alien8.de \
    --cc=decui@microsoft.com \
    --cc=haiyangz@microsoft.com \
    --cc=hpa@zytor.com \
    --cc=kumarpraveen@linux.microsoft.com \
    --cc=kys@microsoft.com \
    --cc=linux-hyperv@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michael.h.kelley@microsoft.com \
    --cc=mingo@redhat.com \
    --cc=sthemmin@microsoft.com \
    --cc=tglx@linutronix.de \
    --cc=vkuznets@redhat.com \
    --cc=wei.liu@kernel.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).