LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: "Paolo Ciarrocchi" <paolo.ciarrocchi@gmail.com>
To: "Bartlomiej Zolnierkiewicz" <bzolnier@gmail.com>
Cc: "Borislav Petkov" <petkovbb@googlemail.com>,
linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org,
"Borislav Petkov" <petkovbb@gmail.com>
Subject: Re: [PATCH] ide-cd: fix some codestyle and most of the checkpatch.pl issues
Date: Tue, 26 Feb 2008 23:46:53 +0030 [thread overview]
Message-ID: <4d8e3fd30802261516g5f4ca763kd4f8405f136b9847@mail.gmail.com> (raw)
In-Reply-To: <200802262337.29873.bzolnier@gmail.com>
On 2/26/08, Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> wrote:
>
> On Tuesday 26 February 2008, Borislav Petkov wrote:
> > Signed-off-by: Borislav Petkov <petkovbb@gmail.com>
> > ---
> > drivers/ide/ide-cd.c | 634
> +++++++++++++++++++++++++------------------------
> > 1 files changed, 323 insertions(+), 311 deletions(-)
>
> With 300 lines changed this is not trivial to review/apply anymore
> (yeah, I sound like a broken record ;-) and since I've already applied
> Paolo's patch from two days ago this one heavily rejects...
>
> Moreover md5sum is different before/after the patch - I tried really hard
> to figure out why (by reverting some changes) but finally I gave up.
is it because of the changes in the include section?
and was the change suggested by checkpatch.pl?
ciao,
--
Paolo
http://paolo.ciarrocchi.googlepages.com/
prev parent reply other threads:[~2008-02-26 23:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-26 7:49 ide-cd: trivial fixes Borislav Petkov
2008-02-26 7:49 ` [PATCH] ide-cd: put proc-related functions together under single ifdef Borislav Petkov
2008-02-26 22:25 ` Bartlomiej Zolnierkiewicz
2008-02-26 7:49 ` [PATCH] ide-cd: fix some codestyle and most of the checkpatch.pl issues Borislav Petkov
2008-02-26 22:37 ` Bartlomiej Zolnierkiewicz
2008-02-26 23:16 ` Paolo Ciarrocchi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4d8e3fd30802261516g5f4ca763kd4f8405f136b9847@mail.gmail.com \
--to=paolo.ciarrocchi@gmail.com \
--cc=bzolnier@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=petkovbb@gmail.com \
--cc=petkovbb@googlemail.com \
--subject='Re: [PATCH] ide-cd: fix some codestyle and most of the checkpatch.pl issues' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).