LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Aakash Hemadri <aakashhemadri123@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Larry Finger <Larry.Finger@lwfinger.net>,
Phillip Potter <phil@philpotter.co.uk>
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: [PATCH v4 2/5] staging: r8188eu: cast to restricted __be32
Date: Mon, 23 Aug 2021 22:30:27 +0530 [thread overview]
Message-ID: <50439a81aca7ce8c3c97ec1c7247f4cd03f645a5.1629563318.git.aakashhemadri123@gmail.com> (raw)
In-Reply-To: <cover.1629563318.git.aakashhemadri123@gmail.com>
Fix sparse warning:
> rtw_br_ext.c:836:54: warning: cast to restricted __be32
dhpch->cookie is be32, change it's type.
Suggested-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Aakash Hemadri <aakashhemadri123@gmail.com>
---
I had incorrectly removed bytsewapping without considering the hardware
runs in big endian rather change type to __be32 as sugessted by Larry.
drivers/staging/r8188eu/core/rtw_br_ext.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/r8188eu/core/rtw_br_ext.c b/drivers/staging/r8188eu/core/rtw_br_ext.c
index f6d1f6029ec3..f65d94bfa286 100644
--- a/drivers/staging/r8188eu/core/rtw_br_ext.c
+++ b/drivers/staging/r8188eu/core/rtw_br_ext.c
@@ -649,7 +649,7 @@ struct dhcpMessage {
u_int8_t chaddr[16];
u_int8_t sname[64];
u_int8_t file[128];
- u_int32_t cookie;
+ __be32 cookie;
u_int8_t options[308]; /* 312 - cookie */
};
@@ -671,7 +671,7 @@ void dhcp_flag_bcast(struct adapter *priv, struct sk_buff *skb)
(udph->dest == __constant_htons(SERVER_PORT))) { /* DHCP request */
struct dhcpMessage *dhcph =
(struct dhcpMessage *)((size_t)udph + sizeof(struct udphdr));
- u32 cookie = be32_to_cpu((__be32)dhcph->cookie);
+ u32 cookie = be32_to_cpu(dhcph->cookie);
if (cookie == DHCP_MAGIC) { /* match magic word */
if (!(dhcph->flags & htons(BROADCAST_FLAG))) {
--
2.32.0
next prev parent reply other threads:[~2021-08-23 17:00 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-23 17:00 [PATCH v4 0/5] staging: r8188eu: fix sparse warnings Aakash Hemadri
2021-08-23 17:00 ` [PATCH v4 1/5] staging: r8188eu: restricted __be16 degrades to int Aakash Hemadri
2021-08-23 17:00 ` Aakash Hemadri [this message]
2021-08-23 17:00 ` [PATCH v4 3/5] staging: r8188eu: incorrect type in csum_ipv6_magic Aakash Hemadri
2021-08-25 9:23 ` David Laight
2021-08-28 8:45 ` Aakash Hemadri
2021-08-23 17:00 ` [PATCH v4 4/5] staging: r8188eu: restricted __be16 degrades to int Aakash Hemadri
2021-08-23 17:00 ` [PATCH v4 5/5] staging: r8188eu: incorrect type in assignment Aakash Hemadri
2021-08-28 8:50 ` [PATCH v4 0/5] staging: r8188eu: fix sparse warnings Aakash Hemadri
2021-08-28 9:44 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50439a81aca7ce8c3c97ec1c7247f4cd03f645a5.1629563318.git.aakashhemadri123@gmail.com \
--to=aakashhemadri123@gmail.com \
--cc=Larry.Finger@lwfinger.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=phil@philpotter.co.uk \
--subject='Re: [PATCH v4 2/5] staging: r8188eu: cast to restricted __be32' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).