From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1754407AbeDBLNg (ORCPT <rfc822;w@1wt.eu>);
        Mon, 2 Apr 2018 07:13:36 -0400
Received: from fllnx209.ext.ti.com ([198.47.19.16]:46680 "EHLO
        fllnx209.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1754303AbeDBLNe (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 2 Apr 2018 07:13:34 -0400
Subject: Re: [PATCH v8 42/42] ARM: dts: da850: Add clocks
To: David Lechner <david@lechnology.com>, <linux-clk@vger.kernel.org>,
        <devicetree@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org>
CC: Michael Turquette <mturquette@baylibre.com>,
        Stephen Boyd <sboyd@codeaurora.org>, Rob Herring <robh+dt@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>, Kevin Hilman <khilman@kernel.org>,
        Bartosz Golaszewski <bgolaszewski@baylibre.com>,
        Adam Ford <aford173@gmail.com>, <linux-kernel@vger.kernel.org>
References: <1521168778-27236-1-git-send-email-david@lechnology.com>
 <1521168778-27236-43-git-send-email-david@lechnology.com>
 <cf0c4153-b65d-da57-cd0f-0a16cb186377@lechnology.com>
From: Sekhar Nori <nsekhar@ti.com>
Message-ID: <510309d2-2df0-a915-a6f6-082b41c6b28b@ti.com>
Date: Mon, 2 Apr 2018 16:42:21 +0530
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.7.0
MIME-Version: 1.0
In-Reply-To: <cf0c4153-b65d-da57-cd0f-0a16cb186377@lechnology.com>
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 8bit
X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Friday 16 March 2018 10:50 PM, David Lechner wrote:
> On 03/15/2018 09:52 PM, David Lechner wrote:
>> This adds clock provider nodes for da850 and wires them up to all of the
>> devices.
>>
>> Signed-off-by: David Lechner <david@lechnology.com>
>> ---
> 
> ...
> 
> This is the mcasp0: mcasp@100000 node...
> 
>> @@ -560,6 +720,7 @@
>>               dmas = <&edma0 1 1>,
>>                   <&edma0 0 1>;
>>               dma-names = "tx", "rx";
>> +            clocks = <&psc1 7>;
> 
> After some testing, it looks like it needs to be:
> 
> +            power-domains = <&psc1 7>;
> 
> instead of
> 
> +            clocks = <&psc1 7>;

We should probably have both clocks and power-domains properties for all
PSC clocks. This way, the driver can change without a corresponding DT
update dependency.

Thanks,
Sekhar