LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] soc: bcm: brcmstb: biuctrl: Register writes require a barrier
@ 2019-05-10 19:46 Florian Fainelli
  2019-05-13 18:08 ` Florian Fainelli
  0 siblings, 1 reply; 2+ messages in thread
From: Florian Fainelli @ 2019-05-10 19:46 UTC (permalink / raw)
  To: linux-arm-kernel
  Cc: Florian Fainelli, Brian Norris, Gregory Fong,
	maintainer:BROADCOM BCM7XXX ARM ARCHITECTURE, open list

The BIUCTRL register writes require that a data barrier be inserted
after comitting the write to the register for the block to latch in the
recently written values. Reads have no such requirement and are not
changed.

Fixes: 34642650e5bc ("soc: Move brcmstb to bcm/brcmstb")
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
---
 drivers/soc/bcm/brcmstb/biuctrl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/soc/bcm/brcmstb/biuctrl.c b/drivers/soc/bcm/brcmstb/biuctrl.c
index c16273b31b94..20b63bee5b09 100644
--- a/drivers/soc/bcm/brcmstb/biuctrl.c
+++ b/drivers/soc/bcm/brcmstb/biuctrl.c
@@ -56,7 +56,7 @@ static inline void cbc_writel(u32 val, int reg)
 	if (offset == -1)
 		return;
 
-	writel_relaxed(val,  cpubiuctrl_base + offset);
+	writel(val, cpubiuctrl_base + offset);
 }
 
 enum cpubiuctrl_regs {
-- 
2.17.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] soc: bcm: brcmstb: biuctrl: Register writes require a barrier
  2019-05-10 19:46 [PATCH] soc: bcm: brcmstb: biuctrl: Register writes require a barrier Florian Fainelli
@ 2019-05-13 18:08 ` Florian Fainelli
  0 siblings, 0 replies; 2+ messages in thread
From: Florian Fainelli @ 2019-05-13 18:08 UTC (permalink / raw)
  To: Florian Fainelli, linux-arm-kernel
  Cc: Brian Norris, Gregory Fong,
	maintainer:BROADCOM BCM7XXX ARM ARCHITECTURE, open list

On 5/10/19 12:46 PM, Florian Fainelli wrote:
> The BIUCTRL register writes require that a data barrier be inserted
> after comitting the write to the register for the block to latch in the
> recently written values. Reads have no such requirement and are not
> changed.
> 
> Fixes: 34642650e5bc ("soc: Move brcmstb to bcm/brcmstb")
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>

Applied to drivers/fixes, thanks!
-- 
Florian

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-05-13 18:08 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-10 19:46 [PATCH] soc: bcm: brcmstb: biuctrl: Register writes require a barrier Florian Fainelli
2019-05-13 18:08 ` Florian Fainelli

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).