LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: "Suhabe Bugrara" <suhabe@stanford.edu>
To: linux-kernel@vger.kernel.org
Subject: user pointer bugs
Date: Sun, 14 Jan 2007 15:58:11 -0800	[thread overview]
Message-ID: <5166c2f30701141558td770dfbt13fd5098f76bcde6@mail.gmail.com> (raw)

Hello,

In linux-2.6.19.2, do the following lines have bugs in them? It looks
like they dereference a user pointer without first being checked by
the "access_ok" macro to ensure that they point into userspace.

Suhabe

========================
File: sound/isa/sscape.c
Lines: 550, 665
Description: The pointer "bb" is dereferenced in the expression
"bb->code" without being checked first.
Fix: Replace "bb->code" with "&bb->code"

========================
File: block/scsi_ioctl.c
Lines: 406, 427, 430, 482, 486
Description: The pointer "sic" is dereferenced in the expression
"sic->data" without being checked first.
Fix: Replace "sic->code" with "&sic->code"

========================
File: sound/pci/rme9652/hdsp.c
Line: 4589
Description: The pointer "mixer" is dereferenced in the expression
"mixer->data" without being checked first.
Fix: Replace "mixer->matrix" with "&mixer->matrix"

             reply	other threads:[~2007-01-14 23:58 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-01-14 23:58 Suhabe Bugrara [this message]
2007-01-15 16:56 ` Jan Engelhardt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5166c2f30701141558td770dfbt13fd5098f76bcde6@mail.gmail.com \
    --to=suhabe@stanford.edu \
    --cc=linux-kernel@vger.kernel.org \
    --subject='Re: user pointer bugs' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).