LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Lu Baolu <baolu.lu@linux.intel.com>
To: Alex Williamson <alex.williamson@redhat.com>
Cc: baolu.lu@linux.intel.com, kevin.tian@intel.com,
ashok.raj@intel.com, dima@arista.com, tmurphy@arista.com,
linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org,
jacob.jun.pan@intel.com, David Woodhouse <dwmw2@infradead.org>,
Joerg Roedel <jroedel@suse.de>
Subject: Re: [PATCH v4 12/15] iommu/vt-d: Cleanup get_valid_domain_for_dev()
Date: Fri, 2 Aug 2019 15:17:45 +0800 [thread overview]
Message-ID: <5258f18f-101e-8a43-edea-3f4bb88ca58b@linux.intel.com> (raw)
In-Reply-To: <20190801193013.19444803@x1.home>
Hi Alex,
Thanks for reporting this. I will try to find a machine with a
pcie-to-pci bridge and get this issue fixed. I will update you
later.
Best regards,
Baolu
On 8/2/19 9:30 AM, Alex Williamson wrote:
> On Fri, 19 Jul 2019 09:23:03 -0600
> Alex Williamson <alex.williamson@redhat.com> wrote:
>
>> On Fri, 19 Jul 2019 17:04:26 +0800
>> Lu Baolu <baolu.lu@linux.intel.com> wrote:
>>
>>> Hi Alex,
>>>
>>> On 7/18/19 11:12 AM, Alex Williamson wrote:
>>>> On Sat, 25 May 2019 13:41:33 +0800
>>>> Lu Baolu <baolu.lu@linux.intel.com> wrote:
>>>>
>>>>> Previously, get_valid_domain_for_dev() is used to retrieve the
>>>>> DMA domain which has been attached to the device or allocate one
>>>>> if no domain has been attached yet. As we have delegated the DMA
>>>>> domain management to upper layer, this function is used purely to
>>>>> allocate a private DMA domain if the default domain doesn't work
>>>>> for ths device. Cleanup the code for readability.
>>>>>
>>>>> Signed-off-by: Lu Baolu <baolu.lu@linux.intel.com>
>>>>> ---
>>>>> drivers/iommu/intel-iommu.c | 18 ++++++++----------
>>>>> include/linux/intel-iommu.h | 1 -
>>>>> 2 files changed, 8 insertions(+), 11 deletions(-)
>>>>
>>>> System fails to boot bisected to this commit:
>>>
>>> Is this the same issue as this https://lkml.org/lkml/2019/7/18/840?
>>
>> Yes, the above link is after bisecting with all the bugs and fixes
>> squashed together to avoid landing in local bugs. Thanks,
>
> Well, it turns out this patch is still broken too. I was excited that
> the system booted again with reverting the commit in the link above and
> didn't notice that VT-d failed and de-initialized itself:
>
> DMAR: No ATSR found
> DMAR: dmar0: Using Queued invalidation
> DMAR: dmar1: Using Queued invalidation
> pci 0000:00:00.0: DMAR: Software identity mapping
> pci 0000:00:01.0: DMAR: Software identity mapping
> pci 0000:00:02.0: DMAR: Software identity mapping
> pci 0000:00:16.0: DMAR: Software identity mapping
> pci 0000:00:1a.0: DMAR: Software identity mapping
> pci 0000:00:1b.0: DMAR: Software identity mapping
> pci 0000:00:1c.0: DMAR: Software identity mapping
> pci 0000:00:1c.5: DMAR: Software identity mapping
> pci 0000:00:1c.6: DMAR: Software identity mapping
> pci 0000:00:1c.7: DMAR: Software identity mapping
> pci 0000:00:1d.0: DMAR: Software identity mapping
> pci 0000:00:1f.0: DMAR: Software identity mapping
> pci 0000:00:1f.2: DMAR: Software identity mapping
> pci 0000:00:1f.3: DMAR: Software identity mapping
> pci 0000:01:00.0: DMAR: Software identity mapping
> pci 0000:01:00.1: DMAR: Software identity mapping
> pci 0000:03:00.0: DMAR: Software identity mapping
> pci 0000:04:00.0: DMAR: Software identity mapping
> DMAR: Setting RMRR:
> pci 0000:00:02.0: DMAR: Setting identity map [0xbf800000 - 0xcf9fffff]
> pci 0000:00:1a.0: DMAR: Setting identity map [0xbe8d1000 - 0xbe8dffff]
> pci 0000:00:1d.0: DMAR: Setting identity map [0xbe8d1000 - 0xbe8dffff]
> DMAR: Prepare 0-16MiB unity mapping for LPC
> pci 0000:00:1f.0: DMAR: Setting identity map [0x0 - 0xffffff]
> pci 0000:00:00.0: Adding to iommu group 0
> pci 0000:00:00.0: Using iommu direct mapping
> pci 0000:00:01.0: Adding to iommu group 1
> pci 0000:00:01.0: Using iommu direct mapping
> pci 0000:00:02.0: Adding to iommu group 2
> pci 0000:00:02.0: Using iommu direct mapping
> pci 0000:00:16.0: Adding to iommu group 3
> pci 0000:00:16.0: Using iommu direct mapping
> pci 0000:00:1a.0: Adding to iommu group 4
> pci 0000:00:1a.0: Using iommu direct mapping
> pci 0000:00:1b.0: Adding to iommu group 5
> pci 0000:00:1b.0: Using iommu direct mapping
> pci 0000:00:1c.0: Adding to iommu group 6
> pci 0000:00:1c.0: Using iommu direct mapping
> pci 0000:00:1c.5: Adding to iommu group 7
> pci 0000:00:1c.5: Using iommu direct mapping
> pci 0000:00:1c.6: Adding to iommu group 8
> pci 0000:00:1c.6: Using iommu direct mapping
> pci 0000:00:1c.7: Adding to iommu group 9
> pci 0000:00:1c.7: Using iommu direct mapping
> pci 0000:00:1d.0: Adding to iommu group 10
> pci 0000:00:1d.0: Using iommu direct mapping
> pci 0000:00:1f.0: Adding to iommu group 11
> pci 0000:00:1f.0: Using iommu direct mapping
> pci 0000:00:1f.2: Adding to iommu group 11
> pci 0000:00:1f.3: Adding to iommu group 11
> pci 0000:01:00.0: Adding to iommu group 1
> pci 0000:01:00.1: Adding to iommu group 1
> pci 0000:03:00.0: Adding to iommu group 12
> pci 0000:03:00.0: Using iommu direct mapping
> pci 0000:04:00.0: Adding to iommu group 13
> pci 0000:04:00.0: Using iommu direct mapping
> pci 0000:05:00.0: Adding to iommu group 9
> pci 0000:05:00.0: DMAR: Failed to get a private domain.
> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> pci 0000:00:00.0: Removing from iommu group 0
> pci 0000:00:01.0: Removing from iommu group 1
> pci 0000:00:02.0: Removing from iommu group 2
> pci 0000:00:16.0: Removing from iommu group 3
> pci 0000:00:1a.0: Removing from iommu group 4
> pci 0000:00:1b.0: Removing from iommu group 5
> pci 0000:00:1c.0: Removing from iommu group 6
> pci 0000:00:1c.5: Removing from iommu group 7
> pci 0000:00:1c.6: Removing from iommu group 8
> pci 0000:00:1c.7: Removing from iommu group 9
> pci 0000:00:1d.0: Removing from iommu group 10
> pci 0000:00:1f.0: Removing from iommu group 11
> pci 0000:00:1f.2: Removing from iommu group 11
> pci 0000:00:1f.3: Removing from iommu group 11
> pci 0000:01:00.0: Removing from iommu group 1
> pci 0000:01:00.1: Removing from iommu group 1
> pci 0000:03:00.0: Removing from iommu group 12
> pci 0000:04:00.0: Removing from iommu group 13
> pci 0000:05:00.0: Removing from iommu group 9
> DMAR: Intel(R) Virtualization Technology for Directed I/O
>
> -[0000:00]-+-00.0 Intel Corporation Xeon E3-1200 v2/Ivy Bridge DRAM Controller
> +-01.0-[01]--+-00.0 NVIDIA Corporation GK208 [GeForce GT 635]
> | \-00.1 NVIDIA Corporation GK208 HDMI/DP Audio Controller
> +-02.0 Intel Corporation Xeon E3-1200 v2/3rd Gen Core processor Graphics Controller
> +-16.0 Intel Corporation 6 Series/C200 Series Chipset Family MEI Controller #1
> +-1a.0 Intel Corporation 6 Series/C200 Series Chipset Family USB Enhanced Host Controller #2
> +-1b.0 Intel Corporation 6 Series/C200 Series Chipset Family High Definition Audio Controller
> +-1c.0-[02]--
> +-1c.5-[03]----00.0 ASMedia Technology Inc. ASM1042 SuperSpeed USB Host Controller
> +-1c.6-[04]----00.0 Realtek Semiconductor Co., Ltd. RTL8111/8168/8411 PCI Express Gigabit Ethernet Controller
> +-1c.7-[05-06]----00.0-[06]--
> +-1d.0 Intel Corporation 6 Series/C200 Series Chipset Family USB Enhanced Host Controller #1
> +-1f.0 Intel Corporation H67 Express Chipset LPC Controller
> +-1f.2 Intel Corporation 6 Series/C200 Series Chipset Family 6 port Desktop SATA AHCI Controller
> \-1f.3 Intel Corporation 6 Series/C200 Series Chipset Family SMBus Controller
>
> 05:00.0 PCI bridge: ASMedia Technology Inc. ASM1083/1085 PCIe to PCI Bridge (rev 01) (prog-if 01 [Subtractive decode])
> Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR+ FastB2B- DisINTx-
> Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort- <TAbort- <MAbort- >SERR- <PERR- INTx-
> Latency: 0, Cache Line Size: 32 bytes
> Interrupt: pin A routed to IRQ 5
> Bus: primary=05, secondary=06, subordinate=06, sec-latency=64
> I/O behind bridge: None
> Memory behind bridge: None
> Prefetchable memory behind bridge: None
> Secondary status: 66MHz+ FastB2B- ParErr- DEVSEL=fast >TAbort- <TAbort- <MAbort+ <SERR- <PERR-
> BridgeCtl: Parity- SERR+ NoISA- VGA- VGA16+ MAbort- >Reset- FastB2B-
> PriDiscTmr- SecDiscTmr- DiscTmrStat- DiscTmrSERREn-
> Capabilities: [c0] Subsystem: ASUSTeK Computer Inc. Device 8489
>
>
> With commit 4ec066c7b1476e0ca66a7acdb575627a5d1a1ee6 reverted on
> v5.3-rc2:
>
> DMAR: No ATSR found
> DMAR: dmar0: Using Queued invalidation
> DMAR: dmar1: Using Queued invalidation
> pci 0000:00:00.0: Adding to iommu group 0
> pci 0000:00:00.0: Using iommu direct mapping
> pci 0000:00:01.0: Adding to iommu group 1
> pci 0000:00:01.0: Using iommu direct mapping
> pci 0000:00:02.0: Adding to iommu group 2
> pci 0000:00:02.0: Using iommu direct mapping
> pci 0000:00:16.0: Adding to iommu group 3
> pci 0000:00:16.0: Using iommu direct mapping
> pci 0000:00:1a.0: Adding to iommu group 4
> pci 0000:00:1a.0: Using iommu direct mapping
> pci 0000:00:1b.0: Adding to iommu group 5
> pci 0000:00:1b.0: Using iommu direct mapping
> pci 0000:00:1c.0: Adding to iommu group 6
> pci 0000:00:1c.0: Using iommu direct mapping
> pci 0000:00:1c.5: Adding to iommu group 7
> pci 0000:00:1c.5: Using iommu direct mapping
> pci 0000:00:1c.6: Adding to iommu group 8
> pci 0000:00:1c.6: Using iommu direct mapping
> pci 0000:00:1c.7: Adding to iommu group 9
> pci 0000:00:1c.7: Using iommu direct mapping
> pci 0000:00:1d.0: Adding to iommu group 10
> pci 0000:00:1d.0: Using iommu direct mapping
> pci 0000:00:1f.0: Adding to iommu group 11
> pci 0000:00:1f.0: Using iommu direct mapping
> pci 0000:00:1f.2: Adding to iommu group 11
> pci 0000:00:1f.3: Adding to iommu group 11
> pci 0000:01:00.0: Adding to iommu group 1
> pci 0000:01:00.1: Adding to iommu group 1
> pci 0000:03:00.0: Adding to iommu group 12
> pci 0000:03:00.0: Using iommu direct mapping
> pci 0000:04:00.0: Adding to iommu group 13
> pci 0000:04:00.0: Using iommu direct mapping
> pci 0000:05:00.0: Adding to iommu group 9
> pci 0000:05:00.0: DMAR: Device uses a private dma domain.
> DMAR: Intel(R) Virtualization Technology for Directed I/O
>
> I'm guessing this series was maybe never tested on and doesn't account
> for PCIe-to-PCI bridges. Please fix. Thanks,
>
> Alex
>
next prev parent reply other threads:[~2019-08-02 7:18 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-25 5:41 [PATCH v4 00/15] iommu/vt-d: Delegate DMA domain to generic iommu Lu Baolu
2019-05-25 5:41 ` [PATCH v4 01/15] iommu: Add API to request DMA domain for device Lu Baolu
2019-05-25 5:41 ` [PATCH v4 02/15] iommu/vt-d: Implement apply_resv_region iommu ops entry Lu Baolu
2019-05-25 5:41 ` [PATCH v4 03/15] iommu/vt-d: Expose ISA direct mapping region via iommu_get_resv_regions Lu Baolu
2019-05-25 5:41 ` [PATCH v4 04/15] iommu/vt-d: Enable DMA remapping after rmrr mapped Lu Baolu
2019-05-25 5:41 ` [PATCH v4 05/15] iommu/vt-d: Add device_def_domain_type() helper Lu Baolu
2019-05-25 5:41 ` [PATCH v4 06/15] iommu/vt-d: Delegate the identity domain to upper layer Lu Baolu
2019-05-25 5:41 ` [PATCH v4 07/15] iommu/vt-d: Delegate the dma " Lu Baolu
2020-08-21 18:33 ` Chris Wilson
2020-08-24 6:31 ` Lu Baolu
2020-08-24 8:35 ` Chris Wilson
2020-08-25 3:13 ` Lu Baolu
2019-05-25 5:41 ` [PATCH v4 08/15] iommu/vt-d: Identify default domains replaced with private Lu Baolu
2019-05-25 5:41 ` [PATCH v4 09/15] iommu/vt-d: Handle 32bit device with identity default domain Lu Baolu
2019-05-25 5:41 ` [PATCH v4 10/15] iommu/vt-d: Probe DMA-capable ACPI name space devices Lu Baolu
2019-05-29 6:16 ` Christoph Hellwig
2019-06-03 0:35 ` Lu Baolu
2019-05-25 5:41 ` [PATCH v4 11/15] iommu/vt-d: Implement is_attach_deferred iommu ops entry Lu Baolu
2019-05-25 5:41 ` [PATCH v4 12/15] iommu/vt-d: Cleanup get_valid_domain_for_dev() Lu Baolu
2019-07-18 3:12 ` Alex Williamson
2019-07-19 9:04 ` Lu Baolu
2019-07-19 15:23 ` Alex Williamson
2019-08-02 1:30 ` Alex Williamson
2019-08-02 7:17 ` Lu Baolu [this message]
2019-08-02 16:54 ` Alex Williamson
2019-08-04 3:16 ` Lu Baolu
2019-08-06 0:06 ` Lu Baolu
2019-05-25 5:41 ` [PATCH v4 13/15] iommu/vt-d: Remove startup parameter from device_def_domain_type() Lu Baolu
2019-05-25 5:41 ` [PATCH v4 14/15] iommu/vt-d: Remove duplicated code for device hotplug Lu Baolu
2019-05-25 5:41 ` [PATCH v4 15/15] iommu/vt-d: Remove static identity map code Lu Baolu
2019-05-27 15:00 ` [PATCH v4 00/15] iommu/vt-d: Delegate DMA domain to generic iommu Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5258f18f-101e-8a43-edea-3f4bb88ca58b@linux.intel.com \
--to=baolu.lu@linux.intel.com \
--cc=alex.williamson@redhat.com \
--cc=ashok.raj@intel.com \
--cc=dima@arista.com \
--cc=dwmw2@infradead.org \
--cc=iommu@lists.linux-foundation.org \
--cc=jacob.jun.pan@intel.com \
--cc=jroedel@suse.de \
--cc=kevin.tian@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tmurphy@arista.com \
--subject='Re: [PATCH v4 12/15] iommu/vt-d: Cleanup get_valid_domain_for_dev()' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).