LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH v2 00/11] ext4: number of long lived errors
@ 2018-10-30 21:57 Vasily Averin
  0 siblings, 0 replies; only message in thread
From: Vasily Averin @ 2018-10-30 21:57 UTC (permalink / raw)
  To: linux-ext4, Theodore Ts'o; +Cc: Andreas Dilger, linux-kernel

Last week I've investigated the reason of ext4 resize troubles
on RHEL6 and RHEL7 based OpenVZ kernels.
Failed resize generated lot of "access beyond end of device" messages
followed by warning in __brelse.

 EXT4-fs (dm-3): resizing filesystem from 2620416 to 4096256 blocks
 attempt to access beyond end of device
 dm-3: rw=1, want=32770056, limit=32770048
 attempt to access beyond end of device
 dm-3: rw=1, want=32770064, limit=32770048
 ...
 attempt to access beyond end of device
 dm-3: rw=1, want=32776216, limit=32770048
 EXT4-fs (dm-3): resized filesystem to 4096256
 WARNING: CPU: 2 PID: 113370 at fs/buffer.c:1171 __brelse+0x2e/0x50
 VFS: brelse: Trying to free free buffer

"access beyond end of device" was fixed in mainline by recent commit
f0a459dec5495a ("ext4: fix online resize's handling of a too-small final block group")
However fixed error did not affected bh accounting
and should not lead to warning in __brelse.

Then I've reviewed fs/ext4/resize.c and found a number of long-lived errors,
earliest of them was imported from ext3 in 2.6.19.

First patch in this patch-set fixes the observed problem:
sb_issue_zeroout() failed during attempt to write beyond end of device
rollback switched to "goto end" and called brelse(bh).
however bh was not assigned yet in current iteration,
the pointer was not cleaned properly and was inherited from previous iteration.
To fix the problem I've moved brelse() calls in body of the cycle 
to avoid having to call him on rollback.

Other patches fixes visually-found mistakes.

v2 changes:
 I've found error in one of v1 patches and fixed it,
 then I've found 4 additional issues, mostly related to iloc.bh accounting 

Vasily Averin (11):
  ext4 resise: extra brelse in setup_new_flex_group_blocks()
  ext4 resize: missing brelse() after errors in
    set_flexbg_block_bitmap()
  ext4 resize: brelse() cleanup in add_new_gdb_meta_bg()
  ext4 resize: lost brelse() in update_backups()
  ext4 resize: lost rollback in ext4_resize_fs()
  ext4 resize: lost resize_inode cleanup before retry in
    ext4_resize_fs()
  ext4: lost put_bh in ext4_mark_iloc_dirty()
  ext4: lost brelse in ext4_orphan_add()
  ext4: iloc.bh cleanup in add_new_gdb()
  ext4: remove useless brelse call in ext4_xattr_inode_update_ref()
  ext4: access to uninitialized bh fields in ext4_xattr_set_handle()

 fs/ext4/inode.c  |  5 +++--
 fs/ext4/namei.c  |  4 +++-
 fs/ext4/resize.c | 32 ++++++++++++++++++--------------
 fs/ext4/xattr.c  |  8 +++-----
 4 files changed, 27 insertions(+), 22 deletions(-)

-- 
2.17.1

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2018-10-30 21:57 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-30 21:57 [PATCH v2 00/11] ext4: number of long lived errors Vasily Averin

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).