LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH v2] soundwire: debugfs: use controller id and link_id for debugfs
@ 2021-09-07 10:53 Srinivas Kandagatla
2021-09-07 15:44 ` Pierre-Louis Bossart
2021-10-01 4:23 ` Vinod Koul
0 siblings, 2 replies; 3+ messages in thread
From: Srinivas Kandagatla @ 2021-09-07 10:53 UTC (permalink / raw)
To: vkoul, yung-chuan.liao
Cc: pierre-louis.bossart, sanyog.r.kale, alsa-devel, linux-kernel,
Srinivas Kandagatla
link_id can be zero and if we have multiple controller instances
in a system like Qualcomm debugfs will end-up with duplicate namespace
resulting in incorrect debugfs entries.
Using bus-id and link-id combination should give a unique debugfs directory
entry and should fix below warning too.
"debugfs: Directory 'master-0' with parent 'soundwire' already present!"
Fixes: bf03473d5bcc ("soundwire: add debugfs support")
Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
---
Changes since v1:
Added Link ID along with bus id.
drivers/soundwire/debugfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/soundwire/debugfs.c b/drivers/soundwire/debugfs.c
index b6cad0d59b7b..49900cd207bc 100644
--- a/drivers/soundwire/debugfs.c
+++ b/drivers/soundwire/debugfs.c
@@ -19,7 +19,7 @@ void sdw_bus_debugfs_init(struct sdw_bus *bus)
return;
/* create the debugfs master-N */
- snprintf(name, sizeof(name), "master-%d", bus->link_id);
+ snprintf(name, sizeof(name), "master-%d-%d", bus->id, bus->link_id);
bus->debugfs = debugfs_create_dir(name, sdw_debugfs_root);
}
--
2.21.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] soundwire: debugfs: use controller id and link_id for debugfs
2021-09-07 10:53 [PATCH v2] soundwire: debugfs: use controller id and link_id for debugfs Srinivas Kandagatla
@ 2021-09-07 15:44 ` Pierre-Louis Bossart
2021-10-01 4:23 ` Vinod Koul
1 sibling, 0 replies; 3+ messages in thread
From: Pierre-Louis Bossart @ 2021-09-07 15:44 UTC (permalink / raw)
To: Srinivas Kandagatla, vkoul, yung-chuan.liao
Cc: sanyog.r.kale, alsa-devel, linux-kernel
On 9/7/21 5:53 AM, Srinivas Kandagatla wrote:
> link_id can be zero and if we have multiple controller instances
> in a system like Qualcomm debugfs will end-up with duplicate namespace
> resulting in incorrect debugfs entries.
>
> Using bus-id and link-id combination should give a unique debugfs directory
> entry and should fix below warning too.
> "debugfs: Directory 'master-0' with parent 'soundwire' already present!"
>
> Fixes: bf03473d5bcc ("soundwire: add debugfs support")
> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
> ---
> Changes since v1:
> Added Link ID along with bus id.
>
> drivers/soundwire/debugfs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/soundwire/debugfs.c b/drivers/soundwire/debugfs.c
> index b6cad0d59b7b..49900cd207bc 100644
> --- a/drivers/soundwire/debugfs.c
> +++ b/drivers/soundwire/debugfs.c
> @@ -19,7 +19,7 @@ void sdw_bus_debugfs_init(struct sdw_bus *bus)
> return;
>
> /* create the debugfs master-N */
> - snprintf(name, sizeof(name), "master-%d", bus->link_id);
> + snprintf(name, sizeof(name), "master-%d-%d", bus->id, bus->link_id);
> bus->debugfs = debugfs_create_dir(name, sdw_debugfs_root);
> }
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] soundwire: debugfs: use controller id and link_id for debugfs
2021-09-07 10:53 [PATCH v2] soundwire: debugfs: use controller id and link_id for debugfs Srinivas Kandagatla
2021-09-07 15:44 ` Pierre-Louis Bossart
@ 2021-10-01 4:23 ` Vinod Koul
1 sibling, 0 replies; 3+ messages in thread
From: Vinod Koul @ 2021-10-01 4:23 UTC (permalink / raw)
To: Srinivas Kandagatla
Cc: yung-chuan.liao, pierre-louis.bossart, sanyog.r.kale, alsa-devel,
linux-kernel
On 07-09-21, 11:53, Srinivas Kandagatla wrote:
> link_id can be zero and if we have multiple controller instances
> in a system like Qualcomm debugfs will end-up with duplicate namespace
> resulting in incorrect debugfs entries.
>
> Using bus-id and link-id combination should give a unique debugfs directory
> entry and should fix below warning too.
> "debugfs: Directory 'master-0' with parent 'soundwire' already present!"
Applied, thanks
--
~Vinod
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-10-01 4:24 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-07 10:53 [PATCH v2] soundwire: debugfs: use controller id and link_id for debugfs Srinivas Kandagatla
2021-09-07 15:44 ` Pierre-Louis Bossart
2021-10-01 4:23 ` Vinod Koul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).