LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: "Salyzyn, Mark" <Mark_Salyzyn@adaptec.com>
To: "marcin.slusarz@gmail.com" <marcin.slusarz@gmail.com>,
	LKML <linux-kernel@vger.kernel.org>
Cc: "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
	"James.Bottomley@HansenPartnership.com" 
	<James.Bottomley@HansenPartnership.com>
Subject: RE: [PATCH] scsi: le*_add_cpu conversion
Date: Wed, 13 Feb 2008 06:06:22 -0800	[thread overview]
Message-ID: <532ABFBDAAC3A34EB12EBA6CEC2838F439963FA2@ADPE2K703.adaptec.com> (raw)
In-Reply-To: <1202857582-15450-9-git-send-email-marcin.slusarz@gmail.com>

ACK

Sincerely -- Mark Salyzyn

> -----Original Message-----
> From: marcin.slusarz@gmail.com [mailto:marcin.slusarz@gmail.com]
> Sent: Tuesday, February 12, 2008 6:06 PM
> To: LKML
> Cc: Marcin Slusarz; linux-scsi@vger.kernel.org; AACRAID;
> James.Bottomley@HansenPartnership.com
> Subject: [PATCH] scsi: le*_add_cpu conversion
>
> From: Marcin Slusarz <marcin.slusarz@gmail.com>
>
> replace all:
> little_endian_variable =
> cpu_to_leX(leX_to_cpu(little_endian_variable) +
>                                         expression_in_cpu_byteorder);
> with:
>         leX_add_cpu(&little_endian_variable,
> expression_in_cpu_byteorder);
> generated with semantic patch
>
> Signed-off-by: Marcin Slusarz <marcin.slusarz@gmail.com>
> Cc: linux-scsi@vger.kernel.org
> Cc: aacraid@adaptec.com
> Cc: James.Bottomley@HansenPartnership.com
> ---
>  drivers/scsi/aacraid/commsup.c |    2 +-
>  drivers/scsi/ips.c             |    8 ++------
>  2 files changed, 3 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/scsi/aacraid/commsup.c
> b/drivers/scsi/aacraid/commsup.c
> index 81b3692..3ac8c82 100644
> --- a/drivers/scsi/aacraid/commsup.c
> +++ b/drivers/scsi/aacraid/commsup.c
> @@ -594,7 +594,7 @@ void aac_consumer_free(struct aac_dev *
> dev, struct aac_queue *q, u32 qid)
>         if (le32_to_cpu(*q->headers.consumer) >= q->entries)
>                 *q->headers.consumer = cpu_to_le32(1);
>         else
> -               *q->headers.consumer =
> cpu_to_le32(le32_to_cpu(*q->headers.consumer)+1);
> +               le32_add_cpu(q->headers.consumer, 1);
>
>         if (wasfull) {
>                 switch (qid) {
> diff --git a/drivers/scsi/ips.c b/drivers/scsi/ips.c
> index bb152fb..f45770a 100644
> --- a/drivers/scsi/ips.c
> +++ b/drivers/scsi/ips.c
> @@ -3696,9 +3696,7 @@ ips_send_cmd(ips_ha_t * ha, ips_scb_t * scb)
>                         scb->cmd.basic_io.sg_count = scb->sg_len;
>
>                         if (scb->cmd.basic_io.lba)
> -                               scb->cmd.basic_io.lba =
> -                                   cpu_to_le32(le32_to_cpu
> -
> (scb->cmd.basic_io.lba) +
> +                               le32_add_cpu(&scb->cmd.basic_io.lba,
>
> le16_to_cpu(scb->cmd.basic_io.
>
> sector_count));
>                         else
> @@ -3744,9 +3742,7 @@ ips_send_cmd(ips_ha_t * ha, ips_scb_t * scb)
>                         scb->cmd.basic_io.sg_count = scb->sg_len;
>
>                         if (scb->cmd.basic_io.lba)
> -                               scb->cmd.basic_io.lba =
> -                                   cpu_to_le32(le32_to_cpu
> -
> (scb->cmd.basic_io.lba) +
> +                               le32_add_cpu(&scb->cmd.basic_io.lba,
>
> le16_to_cpu(scb->cmd.basic_io.
>
> sector_count));
>                         else
> --
> 1.5.3.7

  reply	other threads:[~2008-02-13 14:06 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-12 23:06 [PATCHSET] [bl]e*_add_cpu conversions marcin.slusarz
2008-02-12 23:06 ` [PATCH] crypto: be*_add_cpu conversion marcin.slusarz
2008-02-13  8:25   ` Roel Kluin
2008-02-13 18:36     ` Marcin Slusarz
2008-03-14  8:24       ` Herbert Xu
2008-02-12 23:06 ` [PATCH] ieee 1394: " marcin.slusarz
2008-02-16 16:54   ` Stefan Richter
2008-02-12 23:06 ` [PATCH] infiniband: " marcin.slusarz
2008-02-13  0:32   ` Roland Dreier
2008-02-12 23:06 ` [PATCH] affs: " marcin.slusarz
2008-02-12 23:06 ` [PATCH] gfs2: " marcin.slusarz
2008-02-13  9:55   ` Steven Whitehouse
2008-02-12 23:06 ` [PATCH] hfs/hfsplus: " marcin.slusarz
2008-02-12 23:06 ` [PATCH] ipw2200: le*_add_cpu conversion marcin.slusarz
2008-02-13 16:54   ` Chatre, Reinette
2008-02-12 23:06 ` [PATCH] scsi: " marcin.slusarz
2008-02-13 14:06   ` Salyzyn, Mark [this message]
2008-02-12 23:06 ` [PATCH] ext2: " marcin.slusarz
2008-02-12 23:06 ` [PATCH] ext4: " marcin.slusarz
2008-02-12 23:06 ` [PATCH] jfs: " marcin.slusarz
2008-02-13 21:51   ` Dave Kleikamp
2008-02-12 23:06 ` [PATCH] ntfs: " marcin.slusarz
2008-02-12 23:06 ` [PATCH] ocfs2: " marcin.slusarz
2008-02-18 21:03   ` Mark Fasheh
2008-02-12 23:06 ` [PATCH] quota: " marcin.slusarz
2008-02-13  9:52   ` Jan Kara
2008-02-12 23:06 ` [PATCH] reiserfs: " marcin.slusarz
2008-02-12 23:06 ` [PATCH] sysv: [bl]e*_add_cpu conversion marcin.slusarz
2008-02-14  7:04   ` Christoph Hellwig
2008-02-16 13:31     ` Christoph Hellwig
2008-02-12 23:06 ` [PATCH] ufs: " marcin.slusarz
2008-02-13  9:41   ` Roel Kluin
2008-02-13 18:21     ` Marcin Slusarz
2008-02-16  5:28     ` Andrew Morton
2008-02-18 23:22       ` Roel Kluin
2008-02-19 17:45         ` Marcin Slusarz
2008-02-19 19:16           ` Evgeniy Dushistov
2008-03-09 10:21             ` Marcin Slusarz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=532ABFBDAAC3A34EB12EBA6CEC2838F439963FA2@ADPE2K703.adaptec.com \
    --to=mark_salyzyn@adaptec.com \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=marcin.slusarz@gmail.com \
    --subject='RE: [PATCH] scsi: le*_add_cpu conversion' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).