* [PATCH 1/4] ARM: dts: am437x-gp-evm: Correct tps65218 irq type
2018-04-20 11:38 [PATCH 0/4] ARM: dts: am437x boards: Correct tps65218 irq type Peter Ujfalusi
@ 2018-04-20 11:38 ` Peter Ujfalusi
2018-04-20 11:38 ` [PATCH 2/4] ARM: dts: am437x-cm-t43: " Peter Ujfalusi
` (3 subsequent siblings)
4 siblings, 0 replies; 7+ messages in thread
From: Peter Ujfalusi @ 2018-04-20 11:38 UTC (permalink / raw)
To: tony; +Cc: bcousson, linux-omap, devicetree, linux-kernel, j-keerthy
According to the documentation the interrupt line is active low.
The patch will silence the warning from gic_irq_domain_translate():
"Make it clear that broken DTs are... broken"
Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
---
arch/arm/boot/dts/am437x-gp-evm.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/am437x-gp-evm.dts b/arch/arm/boot/dts/am437x-gp-evm.dts
index 8fe95cd7232a..d0192e07adc6 100644
--- a/arch/arm/boot/dts/am437x-gp-evm.dts
+++ b/arch/arm/boot/dts/am437x-gp-evm.dts
@@ -543,7 +543,7 @@
tps65218: tps65218@24 {
reg = <0x24>;
compatible = "ti,tps65218";
- interrupts = <GIC_SPI 7 IRQ_TYPE_NONE>; /* NMIn */
+ interrupts = <GIC_SPI 7 IRQ_TYPE_LEVEL_LOW>; /* NMIn */
interrupt-controller;
#interrupt-cells = <2>;
--
Peter
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
^ permalink raw reply [flat|nested] 7+ messages in thread* [PATCH 2/4] ARM: dts: am437x-cm-t43: Correct tps65218 irq type
2018-04-20 11:38 [PATCH 0/4] ARM: dts: am437x boards: Correct tps65218 irq type Peter Ujfalusi
2018-04-20 11:38 ` [PATCH 1/4] ARM: dts: am437x-gp-evm: " Peter Ujfalusi
@ 2018-04-20 11:38 ` Peter Ujfalusi
2018-04-20 11:38 ` [PATCH 3/4] ARM: dts: am437x-epos-evm: " Peter Ujfalusi
` (2 subsequent siblings)
4 siblings, 0 replies; 7+ messages in thread
From: Peter Ujfalusi @ 2018-04-20 11:38 UTC (permalink / raw)
To: tony; +Cc: bcousson, linux-omap, devicetree, linux-kernel, j-keerthy
According to the documentation the interrupt line is active low.
The patch will silence the warning from gic_irq_domain_translate():
"Make it clear that broken DTs are... broken"
Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
---
arch/arm/boot/dts/am437x-cm-t43.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/am437x-cm-t43.dts b/arch/arm/boot/dts/am437x-cm-t43.dts
index 3b9a94c274a7..54f67f98046c 100644
--- a/arch/arm/boot/dts/am437x-cm-t43.dts
+++ b/arch/arm/boot/dts/am437x-cm-t43.dts
@@ -203,7 +203,7 @@
tps65218: tps65218@24 {
compatible = "ti,tps65218";
reg = <0x24>;
- interrupts = <GIC_SPI 7 IRQ_TYPE_NONE>; /* NMIn */
+ interrupts = <GIC_SPI 7 IRQ_TYPE_LEVEL_LOW>; /* NMIn */
interrupt-parent = <&gic>;
interrupt-controller;
#interrupt-cells = <2>;
--
Peter
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
^ permalink raw reply [flat|nested] 7+ messages in thread* [PATCH 3/4] ARM: dts: am437x-epos-evm: Correct tps65218 irq type
2018-04-20 11:38 [PATCH 0/4] ARM: dts: am437x boards: Correct tps65218 irq type Peter Ujfalusi
2018-04-20 11:38 ` [PATCH 1/4] ARM: dts: am437x-gp-evm: " Peter Ujfalusi
2018-04-20 11:38 ` [PATCH 2/4] ARM: dts: am437x-cm-t43: " Peter Ujfalusi
@ 2018-04-20 11:38 ` Peter Ujfalusi
2018-04-20 11:38 ` [PATCH 4/4] ARM: dts: am437x-sk-evm: " Peter Ujfalusi
2018-04-23 10:31 ` [PATCH 0/4] ARM: dts: am437x boards: " Keerthy
4 siblings, 0 replies; 7+ messages in thread
From: Peter Ujfalusi @ 2018-04-20 11:38 UTC (permalink / raw)
To: tony; +Cc: bcousson, linux-omap, devicetree, linux-kernel, j-keerthy
According to the documentation the interrupt line is active low.
The patch will silence the warning from gic_irq_domain_translate():
"Make it clear that broken DTs are... broken"
Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
---
arch/arm/boot/dts/am43x-epos-evm.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/am43x-epos-evm.dts b/arch/arm/boot/dts/am43x-epos-evm.dts
index a66941885c11..7a5b06fb2cff 100644
--- a/arch/arm/boot/dts/am43x-epos-evm.dts
+++ b/arch/arm/boot/dts/am43x-epos-evm.dts
@@ -595,7 +595,7 @@
tps65218: tps65218@24 {
reg = <0x24>;
compatible = "ti,tps65218";
- interrupts = <GIC_SPI 7 IRQ_TYPE_NONE>; /* NMIn */
+ interrupts = <GIC_SPI 7 IRQ_TYPE_LEVEL_LOW>; /* NMIn */
interrupt-controller;
#interrupt-cells = <2>;
--
Peter
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
^ permalink raw reply [flat|nested] 7+ messages in thread* [PATCH 4/4] ARM: dts: am437x-sk-evm: Correct tps65218 irq type
2018-04-20 11:38 [PATCH 0/4] ARM: dts: am437x boards: Correct tps65218 irq type Peter Ujfalusi
` (2 preceding siblings ...)
2018-04-20 11:38 ` [PATCH 3/4] ARM: dts: am437x-epos-evm: " Peter Ujfalusi
@ 2018-04-20 11:38 ` Peter Ujfalusi
2018-04-23 10:31 ` [PATCH 0/4] ARM: dts: am437x boards: " Keerthy
4 siblings, 0 replies; 7+ messages in thread
From: Peter Ujfalusi @ 2018-04-20 11:38 UTC (permalink / raw)
To: tony; +Cc: bcousson, linux-omap, devicetree, linux-kernel, j-keerthy
According to the documentation the interrupt line is active low.
The patch will silence the warning from gic_irq_domain_translate():
"Make it clear that broken DTs are... broken"
Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
---
arch/arm/boot/dts/am437x-sk-evm.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/am437x-sk-evm.dts b/arch/arm/boot/dts/am437x-sk-evm.dts
index 4118802b7fea..ca5c9070476c 100644
--- a/arch/arm/boot/dts/am437x-sk-evm.dts
+++ b/arch/arm/boot/dts/am437x-sk-evm.dts
@@ -429,7 +429,7 @@
tps@24 {
compatible = "ti,tps65218";
reg = <0x24>;
- interrupts = <GIC_SPI 7 IRQ_TYPE_LEVEL_HIGH>;
+ interrupts = <GIC_SPI 7 IRQ_TYPE_LEVEL_LOW>;
interrupt-controller;
#interrupt-cells = <2>;
--
Peter
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH 0/4] ARM: dts: am437x boards: Correct tps65218 irq type
2018-04-20 11:38 [PATCH 0/4] ARM: dts: am437x boards: Correct tps65218 irq type Peter Ujfalusi
` (3 preceding siblings ...)
2018-04-20 11:38 ` [PATCH 4/4] ARM: dts: am437x-sk-evm: " Peter Ujfalusi
@ 2018-04-23 10:31 ` Keerthy
2018-05-01 15:33 ` Tony Lindgren
4 siblings, 1 reply; 7+ messages in thread
From: Keerthy @ 2018-04-23 10:31 UTC (permalink / raw)
To: Peter Ujfalusi, tony; +Cc: bcousson, linux-omap, devicetree, linux-kernel
On Friday 20 April 2018 05:08 PM, Peter Ujfalusi wrote:
> Hi,
>
> In linux-next I started to see: https://pastebin.com/wrDdptzh
> [ 2.813985] ------------[ cut here ]------------
> [ 2.818746] WARNING: CPU: 0 PID: 19 at /home/ujfalusi/work/kernel/github.omap-audio.linux-audio/drivers/irqchip/irq-gic.c:1016 gic_irq_domain_translate+0xd4/0xec
> [ 2.833311] Modules linked in:
> [ 2.836417] CPU: 0 PID: 19 Comm: kworker/0:2 Not tainted 4.17.0-rc1-next-20180420-00057-gffd03ee19b9b #182
> [ 2.846113] Hardware name: Generic AM43 (Flattened Device Tree)
> [ 2.852073] Workqueue: events deferred_probe_work_func
> ...
>
> Becasue most of the am437x boards had IRQ_TYPE_NONE for tps65218.
>
> According to the datasheet [1] the interrult line is low active, so fix up the board
> DTS files.
>
> Interestingly the am437x-sk-evm had IRQ_TYPE_LEVEL_HIGH, which is not matching
> with the datasheet.
>
> [1] http://www.ti.com/lit/ds/symlink/tps65218.pdf, page 8.
For the series:
Reviewed-by: Keerthy <j-keerthy@ti.com>
Also Boot tested on AM437X-GP-EVM with the patch 1 of the series and i
do not see the error above.
>
> Regards,
> Peter
> ---
> Peter Ujfalusi (4):
> ARM: dts: am437x-gp-evm: Correct tps65218 irq type
> ARM: dts: am437x-cm-t43: Correct tps65218 irq type
> ARM: dts: am437x-epos-evm: Correct tps65218 irq type
> ARM: dts: am437x-sk-evm: Correct tps65218 irq type
>
> arch/arm/boot/dts/am437x-cm-t43.dts | 2 +-
> arch/arm/boot/dts/am437x-gp-evm.dts | 2 +-
> arch/arm/boot/dts/am437x-sk-evm.dts | 2 +-
> arch/arm/boot/dts/am43x-epos-evm.dts | 2 +-
> 4 files changed, 4 insertions(+), 4 deletions(-)
>
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH 0/4] ARM: dts: am437x boards: Correct tps65218 irq type
2018-04-23 10:31 ` [PATCH 0/4] ARM: dts: am437x boards: " Keerthy
@ 2018-05-01 15:33 ` Tony Lindgren
0 siblings, 0 replies; 7+ messages in thread
From: Tony Lindgren @ 2018-05-01 15:33 UTC (permalink / raw)
To: Keerthy; +Cc: Peter Ujfalusi, bcousson, linux-omap, devicetree, linux-kernel
* Keerthy <j-keerthy@ti.com> [180423 10:32]:
>
>
> On Friday 20 April 2018 05:08 PM, Peter Ujfalusi wrote:
> > Hi,
> >
> > In linux-next I started to see: https://pastebin.com/wrDdptzh
> > [ 2.813985] ------------[ cut here ]------------
> > [ 2.818746] WARNING: CPU: 0 PID: 19 at /home/ujfalusi/work/kernel/github.omap-audio.linux-audio/drivers/irqchip/irq-gic.c:1016 gic_irq_domain_translate+0xd4/0xec
> > [ 2.833311] Modules linked in:
> > [ 2.836417] CPU: 0 PID: 19 Comm: kworker/0:2 Not tainted 4.17.0-rc1-next-20180420-00057-gffd03ee19b9b #182
> > [ 2.846113] Hardware name: Generic AM43 (Flattened Device Tree)
> > [ 2.852073] Workqueue: events deferred_probe_work_func
> > ...
> >
> > Becasue most of the am437x boards had IRQ_TYPE_NONE for tps65218.
> >
> > According to the datasheet [1] the interrult line is low active, so fix up the board
> > DTS files.
> >
> > Interestingly the am437x-sk-evm had IRQ_TYPE_LEVEL_HIGH, which is not matching
> > with the datasheet.
> >
> > [1] http://www.ti.com/lit/ds/symlink/tps65218.pdf, page 8.
>
> For the series:
>
> Reviewed-by: Keerthy <j-keerthy@ti.com>
>
> Also Boot tested on AM437X-GP-EVM with the patch 1 of the series and i
> do not see the error above.
Thanks applying all into omap-for-v4.18/dt.
Tony
^ permalink raw reply [flat|nested] 7+ messages in thread