From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751926AbeFEQ0N (ORCPT ); Tue, 5 Jun 2018 12:26:13 -0400 Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70]:58196 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751748AbeFEQ0M (ORCPT ); Tue, 5 Jun 2018 12:26:12 -0400 Cc: Sudeep Holla , Linux Kernel Mailing List , ACPI Devel Maling List , linux-arm Mailing List , Jeremy Linton , Catalin Marinas , Lorenzo Pieralisi , Greg Kroah-Hartman Subject: Re: [PATCH v2] drivers: base: cacheinfo: use OF property_read_u32 instead of get_property,read_number To: Andy Shevchenko References: <1526898749-17263-1-git-send-email-sudeep.holla@arm.com> <1526907189-10031-1-git-send-email-sudeep.holla@arm.com> From: Sudeep Holla Organization: ARM Message-ID: <54785881-da7c-db68-c6a4-70cfd489c1fe@arm.com> Date: Tue, 5 Jun 2018 17:26:08 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/06/18 17:21, Andy Shevchenko wrote: > On Mon, May 21, 2018 at 3:53 PM, Sudeep Holla wrote: >> of_property_read_u32 searches for a property in a device node and read >> a 32-bit value from it. Instead of using of_get_property to get the >> property and then read 32-bit value using of_read_number, we can >> simplify it by using of_property_read_u32. >> > > LGTM. > Thanks! > Thanks, can I take is Ack ? Anyways it's too late for v4.18, will repost after the merge window for v4.19 with your Ack if you agree. -- Regards, Sudeep