LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Peter Ujfalusi <firstname.lastname@example.org>
To: Arnd Bergmann <email@example.com>
Liam Girdwood <firstname.lastname@example.org>,
Tony Lindgren <email@example.com>, Mark Brown <firstname.lastname@example.org>,
Subject: Re: [PATCH 2/3] ARM: edma: Rename header file for dmaengine filter function definition
Date: Fri, 28 Nov 2014 13:48:42 +0200 [thread overview]
Message-ID: <5478611A.email@example.com> (raw)
On 11/28/2014 12:51 PM, Arnd Bergmann wrote:
> On Friday 28 November 2014 09:16:24 Peter Ujfalusi wrote:
>> On 11/27/2014 11:52 PM, Arnd Bergmann wrote:
>>> On Thursday 27 November 2014 20:46:12 Peter Ujfalusi wrote:
>>>> I see. With this series I did not planed to fix all edma related issues, just
>>>> as a start clean up the related header files. I would rather not add fixes to
>>>> mmc, spi, etc drivers since while you have valid point it is not in the scope
>>>> of this series.
>>>> Can we do the changes you are suggesting in an incremental manner?
>>> Sure, but I'd leave the existing filter function declaration alone then
>>> and not move it, since we wouldn't want to keep it in the long run.
>> but if you want to reference the filter function (which is in
>> drivers/dma/edma.c) in arch/arm/mach-davinci/ directory, we will need it.
>> Don't we?
> Yes, unless you move the definition of the filter function into
> arch/arm/common/edma.c or arch/arm/mach-davinci/devices.c, but that
> would require other changes.
At the end the aim is to get rid of the edma code form arch/arm and have only
dmaengine API towards eDMA. The ASoC davinci-pcm is the only user of the
legacy API AFAIK. It has a mode called ping-pong which is not possible with
the dmaeingine at all. This is to overcome underflow situations on parts where
the audio IP does not have FIFO.
My edma-pcm (which is using dmaengine) should be able to handle this
situation, but I need to verify it before I can remove the davinci-pcm and
then we can get rid of the direct eDMA API and code.
>> If I leave the header as it is, then how would we clean up the edma headers? I
>> would not put the API definitions for the arch code into the same file as we
>> have the filter definition.
> Ok, just go ahead with your current patch then, we can always follow up.
> The most important cleanup for edma is elsewhere anyway, so once the asoc
> drivers can use the dmaengine interface, this should be easier.
next prev parent reply other threads:[~2014-11-28 11:49 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-27 10:41 [PATCH 0/3] ARM: edma: Correct header file usage Peter Ujfalusi
2014-11-27 10:41 ` [PATCH 1/3] ASoC: davinci-evm: Do not include edma headers Peter Ujfalusi
2014-11-27 10:58 ` Mark Brown
2014-11-27 10:41 ` [PATCH 2/3] ARM: edma: Rename header file for dmaengine filter function definition Peter Ujfalusi
2014-11-27 11:14 ` Arnd Bergmann
2014-11-27 14:23 ` Peter Ujfalusi
2014-11-27 14:50 ` Arnd Bergmann
2014-11-27 18:46 ` Peter Ujfalusi
2014-11-27 21:52 ` Arnd Bergmann
2014-11-28 7:16 ` Peter Ujfalusi
2014-11-28 10:51 ` Arnd Bergmann
2014-11-28 11:48 ` Peter Ujfalusi [this message]
2014-11-28 10:57 ` Ulf Hansson
2014-11-27 10:41 ` [PATCH 3/3] ARM: edma: Split up header file to platform_data and API file Peter Ujfalusi
2014-12-08 12:49 ` Vinod Koul
2014-12-08 13:16 ` Arnd Bergmann
2014-12-30 13:17 ` Peter Ujfalusi
2015-01-22 1:40 ` Olof Johansson
2015-01-26 7:29 ` Peter Ujfalusi
2015-01-14 9:51 ` [PATCH 0/3] ARM: edma: Correct header file usage Sekhar Nori
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--subject='Re: [PATCH 2/3] ARM: edma: Rename header file for dmaengine filter function definition' \
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).