LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Nicolas Ferre <nicolas.ferre@atmel.com>
To: Bo Shen <voice.shen@atmel.com>,
	Alexandre Belloni <alexandre.belloni@free-electrons.com>
Cc: Boris Brezillon <boris.brezillon@free-electrons.com>,
	"Jean-Christophe Plagniol-Villard" <plagnioj@jcrosoft.com>,
	<linux-kernel@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 6/7] ARM: at91: remove useless at91rm9200_dt_initialize()
Date: Tue, 13 Jan 2015 16:58:26 +0100	[thread overview]
Message-ID: <54B540A2.1020805@atmel.com> (raw)
In-Reply-To: <54B473D3.6090008@atmel.com>

Le 13/01/2015 02:24, Bo Shen a écrit :
> Hi Alexandre,
> 
> On 01/13/2015 02:42 AM, Alexandre Belloni wrote:
>> at91rm9200_dt_initialize() is doing the same as at91_dit_initialize(), use that
> 
> s/at91_dit_initialize/at91_dt_initialize

Alex I'll correct that when including it to the at91-3.20-cleanup
branch. No need to resend.

Voice: thanks for the review.

Bye,


>> one instead.
>>
>> Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
>> ---
>>   arch/arm/mach-at91/board-dt-rm9200.c | 2 +-
>>   arch/arm/mach-at91/generic.h         | 1 -
>>   arch/arm/mach-at91/setup.c           | 7 -------
>>   3 files changed, 1 insertion(+), 9 deletions(-)
>>
>> diff --git a/arch/arm/mach-at91/board-dt-rm9200.c b/arch/arm/mach-at91/board-dt-rm9200.c
>> index 76dfe8f9af50..a15ab6f8de00 100644
>> --- a/arch/arm/mach-at91/board-dt-rm9200.c
>> +++ b/arch/arm/mach-at91/board-dt-rm9200.c
>> @@ -38,6 +38,6 @@ static const char *at91rm9200_dt_board_compat[] __initdata = {
>>   DT_MACHINE_START(at91rm9200_dt, "Atmel AT91RM9200 (Device Tree)")
>>   	.init_time      = at91rm9200_dt_timer_init,
>>   	.map_io		= at91_map_io,
>> -	.init_early	= at91rm9200_dt_initialize,
>> +	.init_early	= at91_dt_initialize,
>>   	.dt_compat	= at91rm9200_dt_board_compat,
>>   MACHINE_END
>> diff --git a/arch/arm/mach-at91/generic.h b/arch/arm/mach-at91/generic.h
>> index e0368aa06390..c10c2ddaae6d 100644
>> --- a/arch/arm/mach-at91/generic.h
>> +++ b/arch/arm/mach-at91/generic.h
>> @@ -22,7 +22,6 @@ extern void __init at91_init_sram(int bank, unsigned long base,
>>
>>    /* Processors */
>>   extern void __init at91rm9200_set_type(int type);
>> -extern void __init at91rm9200_dt_initialize(void);
>>   extern void __init at91_dt_initialize(void);
>>
>>    /* Timer */
>> diff --git a/arch/arm/mach-at91/setup.c b/arch/arm/mach-at91/setup.c
>> index ce25e85720fb..acb8d7724609 100644
>> --- a/arch/arm/mach-at91/setup.c
>> +++ b/arch/arm/mach-at91/setup.c
>> @@ -429,13 +429,6 @@ static void at91_dt_ramc(void)
>>   	at91_pm_set_standby(standby);
>>   }
>>
>> -void __init at91rm9200_dt_initialize(void)
>> -{
>> -	at91_dt_ramc();
>> -
>> -	at91_boot_soc.init();
>> -}
>> -
>>   void __init at91_dt_initialize(void)
>>   {
>>   	at91_dt_ramc();
>>
> 
> Best Regards,
> Bo Shen
> 


-- 
Nicolas Ferre

  reply	other threads:[~2015-01-13 15:58 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-12 18:42 [PATCH 0/7] AT91 cleanup for 3.20 #1 Alexandre Belloni
2015-01-12 18:42 ` [PATCH 1/7] ARM: at91: remove unused mach/memory.h Alexandre Belloni
2015-01-12 18:42 ` [PATCH 2/7] ARM: at91: remove useless config MACH_AT91RM9200_DT Alexandre Belloni
2015-01-12 18:42 ` [PATCH 3/7] ARM: at91: remove useless config MACH_AT91SAM9_DT Alexandre Belloni
2015-01-12 18:42 ` [PATCH 4/7] ARM: at91: remove useless at91_sysirq_mask_rtx Alexandre Belloni
2015-01-12 18:42 ` [PATCH 5/7] ARM: at91: move debug-macro.S into the common space Alexandre Belloni
2015-01-20  9:23   ` Paul Bolle
2015-01-20 10:54     ` [PATCH] ARM: at91: fix Kconfig.debug by adding DEBUG_AT91_UART option Nicolas Ferre
2015-01-23 23:03       ` Olof Johansson
2015-01-12 18:42 ` [PATCH 6/7] ARM: at91: remove useless at91rm9200_dt_initialize() Alexandre Belloni
2015-01-13  1:24   ` Bo Shen
2015-01-13 15:58     ` Nicolas Ferre [this message]
2015-01-12 18:42 ` [PATCH 7/7] ARM: at91: remove useless at91rm9200_set_type() Alexandre Belloni
2015-01-12 19:26 ` [PATCH 0/7] AT91 cleanup for 3.20 #1 Boris Brezillon
2015-01-15 14:09   ` Nicolas Ferre

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54B540A2.1020805@atmel.com \
    --to=nicolas.ferre@atmel.com \
    --cc=alexandre.belloni@free-electrons.com \
    --cc=boris.brezillon@free-electrons.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=plagnioj@jcrosoft.com \
    --cc=voice.shen@atmel.com \
    --subject='Re: [PATCH 6/7] ARM: at91: remove useless at91rm9200_dt_initialize()' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).