From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752017AbbASLwh (ORCPT ); Mon, 19 Jan 2015 06:52:37 -0500 Received: from szxga01-in.huawei.com ([119.145.14.64]:62757 "EHLO szxga01-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750850AbbASLwf (ORCPT ); Mon, 19 Jan 2015 06:52:35 -0500 Message-ID: <54BCEFDA.4050803@huawei.com> Date: Mon, 19 Jan 2015 19:51:54 +0800 From: Wang Nan User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:24.0) Gecko/20100101 Thunderbird/24.0.1 MIME-Version: 1.0 To: Jiri Olsa CC: , , , , , , Jiri Olsa Subject: Re: [PATCH] perf: perl: force to use stdbool. References: <1421301354-58012-1-git-send-email-wangnan0@huawei.com> <54BCDF89.5070008@huawei.com> <20150119112313.GC11009@krava.brq.redhat.com> In-Reply-To: <20150119112313.GC11009@krava.brq.redhat.com> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.111.69.129] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2015/1/19 19:23, Jiri Olsa wrote: > On Mon, Jan 19, 2015 at 06:42:17PM +0800, Wang Nan wrote: >> Add Jiri Olsa jolsa@kernel.org to CC list. I think jolsa@kernel.org should be the main >> email address he uses. > > ack ;-) > > jirka > >> >> On 2015/1/15 13:55, Wang Nan wrote: >>> When building perf for arm64 I hit a warning (and be treated as an >>> error) like below: >>> >>> aarch64-oe-linux-gcc -o .../util/scripting-engines/trace-event-python.o -c -Wbad-function-cast \ >>> ... util/scripting-engines/trace-event-python.c >>> >>> In file included from .../usr/lib64/perl/5.14.3/CORE/perl.h:2464:0, >>> from Context.xs:23: >>> /.../usr/lib64/perl/5.14.3/CORE/handy.h:108:0: error: "bool" redefined [-Werror] >>> # define bool char >>> ^ >>> In file included from /.../usr/src/kernel/tools/include/linux/types.h:4:0, >>> from /.../usr/src/kernel/arch/arm64/include/uapi/asm/sigcontext.h:19, >>> from /.../usr/include/bits/sigcontext.h:27, >>> from /.../usr/include/signal.h:340, >>> from /.../usr/include/sys/param.h:28, >>> from /.../usr/lib64/perl/5.14.3/CORE/perl.h:678, >>> from Context.xs:23: >>> /.../usr/lib/aarch64-oe-linux/gcc/aarch64-oe-linux/4.9.2/include/stdbool.h:33:0: note: this is the location of the previous definition >>> #define bool _Bool >>> >>> Looks like the failure is caused by arm64 uapi/asm/sigcontext.h, which >>> includes linux/types.h while other archs not. >>> >>> This patch includes stdbool.h before Context.xs and define HAS_BOOL to >>> prevent perl'e headers define its own 'bool'. >>> >>> Signed-off-by: Wang Nan >>> --- >>> tools/perf/scripts/perl/Perf-Trace-Util/Context.c | 3 ++- >>> 1 file changed, 2 insertions(+), 1 deletion(-) >>> >>> diff --git a/tools/perf/scripts/perl/Perf-Trace-Util/Context.c b/tools/perf/scripts/perl/Perf-Trace-Util/Context.c >>> index 790ceba..69c3572 100644 >>> --- a/tools/perf/scripts/perl/Perf-Trace-Util/Context.c >>> +++ b/tools/perf/scripts/perl/Perf-Trace-Util/Context.c >>> @@ -5,7 +5,8 @@ >>> * ANY CHANGES MADE HERE WILL BE LOST! >>> * >>> */ >>> - >>> +#include >>> +#define HAS_BOOL 1 > > I saw this patch before.. but I had no idea ;-) > > seems hacky to me? Is there any doc saying 'this is how you handle this with perl' ? ;-) > It is hacky. I'm not very familiar with perl, I just try to build it. I checked perl's repository and found that newest perl does consider this problem: http://perl5.git.perl.org/perl.git/commit/bd31be4baa3ee68abdb92c0db3200efe0fad903b So the root cause is in my perl version. What's your policy then? Do you think we should provid a workaround or just force users update their perl? Thank you. > I couldn't find any.. or more detailed explanation why we should > define HAS_BOOL and not perl headers.. > > thanks, > jirka >