LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Jon Masters <jonathan@jonmasters.org>
To: Laszlo Ersek <lersek@redhat.com>,
Matt Fleming <matt@console-pimps.org>,
Borislav Petkov <bp@alien8.de>
Cc: Dave Young <dyoung@redhat.com>,
linux-efi <linux-efi@vger.kernel.org>,
Ard Biesheuvel <ard.biesheuvel@linaro.org>,
Matt Fleming <matt.fleming@intel.com>,
Ricardo Neri <ricardo.neri-calderon@linux.intel.com>,
lkml <linux-kernel@vger.kernel.org>
Subject: Re: Shorten efi regions output
Date: Wed, 21 Jan 2015 00:48:58 -0500 [thread overview]
Message-ID: <54BF3DCA.4070708@jonmasters.org> (raw)
In-Reply-To: <54AAA723.1070605@redhat.com>
On 1/5/15, 10:00 AM, Laszlo Ersek wrote:
> On 01/05/15 15:03, Matt Fleming wrote:
>> On Wed, 10 Dec, at 11:46:28AM, Borislav Petkov wrote:
>>> On Wed, Dec 10, 2014 at 10:17:41AM +0800, Dave Young wrote:
>>>> I have same feeling with you, it is too long for most of people.
>>>>
>>>> Since the printk code are for EFI_DEBUG, they are around the #ifdef
>>>> so I would like to see a kernel param like efi_debug=on, so only
>>>> efi_debug is specified then these verbose messages are printed.
>>>> Without the param kernel can print some basic infomation about the
>>>> memory ranges.
>>>>
>>>> In arm64 code there's already a uefi_debug param it can be moved to
>>>> general code so that there will be a goable switch.
>>>
>>> Hmm, makes sense to me. Maybe we should really hide those behind a
>>> debug switch, the question is whether asking the user to boot with
>>> "efi_debug=on" in order to see the regions is ok. And I think it is ok
>>> because we do that when debugging other stuff so I don't see anything
>>> different here.
>>>
>>> And then when they're disabled by default, we don't really need to
>>> shorten them as they're pure debug output then.
>>>
>>> Matt?
>>
>> I'm fine with disabling the EFI memory output regions by default.
>>
>> Printing the regions is still useful for debugging, but like you
>> mention, we frequently ask users to enable other debug options when
>> tracking down issues.
>>
>> Laszlo, would you be OK with that?
>
> Sure.
Pardon my intrusion into this thread (just going over the past month's
LKML for things I missed). I'd like to see some map output by default in
the kernel. We have on a number of occasions found just this output
useful in debugging boot issues on ARM servers and I suspect that will
remain the case over the coming months. Sure, you can always tell
someone to reboot, but then you have to rely on them doing it.
Jon.
next prev parent reply other threads:[~2015-01-21 6:13 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-09 9:58 Borislav Petkov
2014-12-09 12:42 ` Ard Biesheuvel
2014-12-09 12:48 ` Borislav Petkov
2014-12-09 15:35 ` Laszlo Ersek
2014-12-09 16:45 ` Borislav Petkov
2014-12-10 2:17 ` Dave Young
2014-12-10 10:46 ` Borislav Petkov
2015-01-05 14:03 ` Matt Fleming
2015-01-05 15:00 ` Laszlo Ersek
2015-01-21 5:48 ` Jon Masters [this message]
2015-01-21 10:06 ` Borislav Petkov
2015-01-26 10:49 ` Matt Fleming
2015-01-30 16:43 ` [PATCH] efi, x86: Add a "debug" option to the efi= cmdline Borislav Petkov
2015-01-30 16:58 ` Laszlo Ersek
2015-01-30 18:06 ` Randy Dunlap
2015-01-30 21:17 ` Borislav Petkov
2015-02-04 12:18 ` Parmeshwr Prasad
2015-02-05 3:18 ` Dave Young
2015-02-05 8:11 ` Borislav Petkov
2015-02-05 8:41 ` Dave Young
2015-02-05 10:44 ` [PATCH v2] " Borislav Petkov
2015-02-05 12:45 ` Parmeshwr Prasad
2015-02-05 14:28 ` Borislav Petkov
2015-02-06 6:00 ` Parmeshwr Prasad
2015-02-06 10:49 ` Borislav Petkov
2015-02-24 22:33 ` Matt Fleming
2015-04-02 12:27 ` [tip:core/efi] x86/efi: " tip-bot for Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54BF3DCA.4070708@jonmasters.org \
--to=jonathan@jonmasters.org \
--cc=ard.biesheuvel@linaro.org \
--cc=bp@alien8.de \
--cc=dyoung@redhat.com \
--cc=lersek@redhat.com \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matt.fleming@intel.com \
--cc=matt@console-pimps.org \
--cc=ricardo.neri-calderon@linux.intel.com \
--subject='Re: Shorten efi regions output' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).